Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Namotion.Messaging.Json to Namotion.Messaging.Newtonsoft.Json #18

Open
RicoSuter opened this issue Oct 25, 2021 · 1 comment
Open

Comments

@RicoSuter
Copy link
Owner

No description provided.

@SeanFarrow
Copy link

As someone who is about to use this and requires System.Text.Json support, I'd be happy to do this as well as making it possible to provide serializer settingsto the currently implemented message retriever and publisher.

Ideally, we should do the following:
Firstly, Rename the project in this issue.
Secondly, extract any implementations of IMessageReceiver and IMessagePublisher to a new project, tentatively Namotion.Messaging.Json. This project also needs a way of being able to inject serializer settings.

To do this I am suggesting an interface such as IProvideJsonSerializerSettings.
This interface should have a method GetSerializerSettings, Which is generic and returns the settings for either System.Text.Json or NewtonSoft.Json, depending on the implementation.

We then need another project Namotion.Messaging.Json.SystemTextJson which has an implementation of the previously described interface.

Does that sound a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants