poc of kubernetes entity provider #51
Conversation
| await Promise.all(namespaces.items.map(async namespace => { | ||
| await Promise.all(this.opts.objectMappings.map(async objectMapping => { | ||
| if (namespace.metadata?.name) { | ||
| if (objectMapping.plural === 'pods') { |
There was a problem hiding this comment.
For the core api, I am only allow pods to be collected, in the ultimate version we would allow collecting any of the other core api resources.
| })) | ||
| }) | ||
| } catch (e: any) { | ||
| logger.info(`handling entity request failed: ${e}`); |
There was a problem hiding this comment.
We probably need better error handling here.
| const brokerServer = process.env.BROKER_SERVER || 'http://localhost:7341'; | ||
|
|
||
| RoadieAgent.fromConfig({ | ||
| server: brokerServer, |
There was a problem hiding this comment.
The settings here will need to be provided from the outside.. and some of the settings should be defaulted in the implementation of fromConfig.
| @@ -24,6 +24,9 @@ | |||
| "build/types/**/*", | |||
| "config/accept.json" | |||
| ], | |||
| "bin": { | |||
| "kubernetes-entity-provider": "./bin/kubernetes-entity-provider" | |||
There was a problem hiding this comment.
This could be maybe better in a format like agent-entity-provider --variant kubernetes or something
| createRoadieAgentEntityProvider({ | ||
| name: 'kube', | ||
| handler: new KubernetesEntityProvider({ | ||
| namespaceFilters: { |
There was a problem hiding this comment.
All of these settings should be configurable with sensible defaults.
| const namespaces = await this.listNamespaces(); | ||
|
|
||
| await Promise.all(namespaces.items.map(async namespace => { | ||
| await Promise.all(this.opts.objectMappings.map(async objectMapping => { |
There was a problem hiding this comment.
await for...of probably easier to read here since you are mutating the external var already
| const k8sCustomObjectsApi = this.kc.makeApiClient(CustomObjectsApi) | ||
| const namespaces = await this.listNamespaces(); | ||
|
|
||
| await Promise.all(namespaces.items.map(async namespace => { |
There was a problem hiding this comment.
I think flatMapping should probably achieve the same things here, depending how you decide to modify the loop below
| RUN npm install && npm install typescript -g | ||
| COPY . . | ||
| RUN yarn build | ||
| CMD ["node", "./bin/kubernetes-entity-provider"] |
There was a problem hiding this comment.
need the ability to configure the entity provider entity mappings and the broker client server url and token.
No description provided.