Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trade IDs are not secure #11

Open
f321x opened this issue Aug 26, 2024 · 0 comments
Open

Trade IDs are not secure #11

f321x opened this issue Aug 26, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.1

Comments

@f321x
Copy link
Collaborator

f321x commented Aug 26, 2024

The current coordinator creates a 16 byte random offer id when trades are created. This would need to be larger or not random to avoid collisions. Possibly this could adopt to existing Robosats logic of offer identification.
@f321x f321x added the enhancement New feature or request label Aug 26, 2024
@f321x f321x added this to the v0.1 milestone Aug 26, 2024
@RoboSats RoboSats deleted a comment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@f321x