You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Reviewing the situation with some other vendor packages inside ROS, their version (the version in package.xml and CMakeLists.txt) can be out of sync and cause confusion if at some point changes in the code of the vendor package (this same ros-drake-vendor repo) needs to be made.
To ship changes in this repository code we would need to somehow bump the version in any of its members (major, minor, patch). That would leave the versions out of sync with upstream Drake.
A possible workaround is to encode the major and minor to be fully in sync with upstream while playing with the patch part somehow to allow bumps while encoding the upstream patch info. See https://github.com/ros2/cartographer/blob/ros2/package.xml#L20-L41 about how the cartographer package makes this.
The text was updated successfully, but these errors were encountered:
The version tracking is useful but not strictly necessary. The alternative for keeping in sync is abusing the patch releases which can get packages into bad states. Or the other is to just clarify that this is the vendor package and the version refers to the vendoring only not the underlying library. I think that the approach from cartographer is probably a pretty good compromise.
Reviewing the situation with some other vendor packages inside ROS, their version (the version in
package.xml
andCMakeLists.txt
) can be out of sync and cause confusion if at some point changes in the code of the vendor package (this sameros-drake-vendor
repo) needs to be made.To ship changes in this repository code we would need to somehow bump the version in any of its members (major, minor, patch). That would leave the versions out of sync with upstream Drake.
A possible workaround is to encode the major and minor to be fully in sync with upstream while playing with the patch part somehow to allow bumps while encoding the upstream patch info. See https://github.com/ros2/cartographer/blob/ros2/package.xml#L20-L41 about how the
cartographer
package makes this.The text was updated successfully, but these errors were encountered: