Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IMU references. #16

Open
rafa-martin opened this issue Sep 20, 2024 · 2 comments · Fixed by #18
Open

Fix IMU references. #16

rafa-martin opened this issue Sep 20, 2024 · 2 comments · Fixed by #18
Assignees

Comments

@rafa-martin
Copy link
Member

rafa-martin commented Sep 20, 2024

  • Remove parameters:

    • tf_ned_to_nwu
    • tf_ned_to_enu
    • frame_based_nwu
    • frame_based_enu
  • Allow to set reference frame for orientation (must change only orientation and orientation covariance):

    • ned, sensor's original data.
    • enu, ROS' standard. Must be the default setting.
  • Rotate angular velocity and linear accelerations to convert from sensors internal frame (x forward, y right, z down) to match ROS standard (x forward, y left, z up).

  • Keep rotation_reference_frame as a way to specify mounting pose of sensor

@marbosjo
Copy link

Test with:

  • standard odometry test,
  • cartographer,
  • robot_localization & navsat_transform.

@marbosjo
Copy link

done & merged:

  • removed parameters for ned/enu/nwu

to be done:

  • publish mag/odom/etc messages

not to be done:

  • allow for ned publishing

@github-staff github-staff deleted a comment from SAMBILI Oct 28, 2024
@github-staff github-staff deleted a comment from SAMBILI Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants