Fix: getchannelavatarurl function in chatHeader and RoomInformation to Reflect Updated Avatar Changes. #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
| @@ -78,7 +84,7 @@ const ChatHeader = ({ | |||
| ); | |||
| const workspaceLevelRoles = useUserStore((state) => state.roles); | |||
|
|
|||
| const { RCInstance, ECOptions } = useRCContext(); | |||
There was a problem hiding this comment.
Any specific reason for removing this and using useContext here ?
| @@ -369,7 +385,7 @@ const ChatHeader = ({ | |||
| <Avatar | |||
| size="36px" | |||
| style={{ marginRight: '6px' }} | |||
| url={getChannelAvatarURL(channelInfo.name)} | |||
|
Looks like a great addition, @AyushKumar123456789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Fix getChannelAvatarURL to Reflect Updated Avatar Changes in rocket.chat.
Acceptance Criteria fulfillment
Fixes #887
Video/Screenshots
Room.Avatar.bug.solved.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.