feat: Enhance fileUpload modal. #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
|
Please use mp4 formats and clearly explain the difference in the PR description |
|
Done. |
|
when you get large photos(large height) then the modal size does not increase Let's keep the modal size fixed |
|
@Spiral-Memory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
In this PR i work on enhancing the FileUpload modal and make it look similar as RC as much as possible
Edited: In a file upload modal when you click on label it does not focus on the input field i have added this in my PR.
Acceptance Criteria fulfillment
Fixes #891
Video/Screenshots
Before:
Screencast.from.2025-01-15.00-33-09.mp4
After:
Screencast.from.2025-01-15.00-31-17.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-899 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.