Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tool Tips positioned above for Message Toolbox #901

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KrishnaShuk
Copy link

@KrishnaShuk KrishnaShuk commented Jan 15, 2025

Tool-Tips positioned above Message Toolbox

Acceptance Criteria fulfillment

  • The tooltip should be fully visible and display the complete text without being truncated.

Fixes #900

Video/Screenshots

Screencast.from.2025-01-15.15-20-10.webm

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr- 901 after approval.

@dhairyashiil
Copy link
Contributor

Hello @KrishnaShuk, the tooltip arrow should point to the message toolbox, not the icon inside. If you want to change the position from bottom to top, please consider this point as well: Observe the current tooltip position, it's not directly on the icon.

@KrishnaShuk
Copy link
Author

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

@dhairyashiil
Copy link
Contributor

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

Well, I have an idea. Instead of changing the position of the tooltip from bottom to top, you can change the positioning of the message toolbox by shifting it upwards. However, there's a catch: the message toolbar positioning differs for normal messages and quoted messages, so you need to ensure that the toolbar is usable for both types of messages.

@Spiral-Memory
Copy link
Collaborator

If you shift it to top, then the problem will again be the same when a message is at the top i believe, can we make it dynamic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tooltip Content Not Fully Visible in UI Element
3 participants