Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions List Not Fetching All mentions in EmbeddedChat #915

Open
SinghaAnirban005 opened this issue Jan 16, 2025 · 9 comments
Open

Mentions List Not Fetching All mentions in EmbeddedChat #915

SinghaAnirban005 opened this issue Jan 16, 2025 · 9 comments
Labels
bug Something isn't working

Comments

@SinghaAnirban005
Copy link
Contributor

Description:

When opening the mentions list in Rocket.Chat (RC), all user mentions are fetched as expected. This behavior is inconsistent with the behavior in Embedded Chat (EC), where the mentions are not properly fetched and displayed.

Steps to reproduce:

  1. Navigate to a chat room in EC
  2. Open the mentions list by clicking on @
  3. Observe that the full list of user mentions is not fetched

Expected behavior:

All user mentions should be fetched and displayed in the mentions list when @ is clicked

Actual behavior:

In RC

Image

In EC

Image

@SinghaAnirban005 SinghaAnirban005 added the bug Something isn't working label Jan 16, 2025
@SinghaAnirban005
Copy link
Contributor Author

Working on it !!

@abirc8010
Copy link
Contributor

abirc8010 commented Jan 16, 2025

Hey @SinghaAnirban005, I believe this issue affects not only mentions but all items in the sidebar. We could create an issue to address the older items fetching feature in the sidebar, which can then be handled in a single PR under one consolidated issue.

@SinghaAnirban005
Copy link
Contributor Author

@abirc8010 can i include this in one of my PR's #836
I believe it wont takes much lines of change particularly for the mentions part because there is an existing API that is not being used

@abirc8010
Copy link
Contributor

abirc8010 commented Jan 17, 2025

Hey @SinghaAnirban005, the PR you're referring to seems to address a different issue, so including these changes there might not be ideal. Additionally, I believe the existing API alone won’t fetch older mentions—you’d likely need a "load more mentions" functionality to handle that effectively.

Since none of the items in the sidebar currently have this functionality, implementing it could be a valuable improvement. Creating a dedicated issue for this and addressing it in a separate PR might be a better approach. This would help keep the changes focused and make the review process easier for the maintainer.

@Spiral-Memory what are your thoughts on this?

@SinghaAnirban005
Copy link
Contributor Author

@abirc8010 do you have any ongoing work related to this or should i go for it ??

@abirc8010
Copy link
Contributor

I had plans to fix this issue for the sidebar, but I’m currently working on improving the 'Jump to Message' feature.

do you have any ongoing work related to this or should i go for it ??

We can definitely collaborate on this !

@abirc8010
Copy link
Contributor

I also noticed a similar issue for threads in #895, reported by @smritidoneria. Maybe a single PR could address these for the sidebar items.

@SinghaAnirban005
Copy link
Contributor Author

Alright then we shall collaborate once you are done with your work on the feature

@abirc8010
Copy link
Contributor

Alright then we shall collaborate once you are done with your work on the feature

Let's wait for @Spiral-Memory to confirm. After that you can proceed and I’ll reach out to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants