Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : added icon to show Update ChannelHeader and RoomInfo UI for (Channels Converted to Teams). #926

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AyushKumar123456789
Copy link
Contributor

@AyushKumar123456789 AyushKumar123456789 commented Jan 20, 2025

Brief Title

Update Channelheader and RoomInfo UI for (Channels Converted to Teams).

Acceptance Criteria fulfillment

  • When a channel is converted to a team, the channelheader icon now displays the team icon instead of the regular hash icon.
  • Inside the Room Information component, the displayed icon updates, If the channel has been converted to a team.
  • The title in the Room Information component conditionally changes to Team Information for channels that have been converted to teams.

Fixes #923

Video/Screenshots

image
image

In rocket.chat
image
image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory
Copy link
Collaborator

Hi @AyushKumar123456789
Run prettier on your code

@Spiral-Memory Spiral-Memory added the nudge minor tweaks suggested label Jan 27, 2025
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory added testing and removed nudge minor tweaks suggested labels Jan 27, 2025
@AyushKumar123456789
Copy link
Contributor Author

I apologize for the inconvenience, Sir. I have now run Prettier and addressed the areas I previously overlooked. I hope this resolves any remaining issues and facilitates the merging of my pull request.

@Spiral-Memory
Copy link
Collaborator

No worries @AyushKumar123456789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Missing Team Symbol Beside Avatar for "Room to Team" Conversion in Embedded Chat
2 participants