Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

- Add port to device hostname; return discovery results as they arrive #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jpage4500
Copy link

No description provided.

@jpage4500
Copy link
Author

Hi @RootSoft - not sure if you're maintaining this project anymore but I found it very useful to help identify ONVIF devices.

There was a couple of changes I wanted/needed though so I made them in a branch:

  1. I'm testing with IP Webcam, an Android app on the Play Store which supports ONVIF discovery. However, it uses port 8080 by default and the devices discovered never contained the port for me
  2. I wanted to show the user results as they came in and not all at the end
  3. I also wanted to know when the discovery was finished (needed to do Added Kotlin coroutines wrappers, moved publishing on Jitpack and rew… #2 above)

I'll be doing more testing of this including the other methods but just wanted to see if you were open to the PR while I'm doing more testing

@jpage4500
Copy link
Author

Oh - I also added a test app (Android).. I just realized not everyone using this library is using it with Android so the test app wouldn't be as helpful to them.. but, hopefully everything else would be

@RootSoft
Copy link
Owner

RootSoft commented Feb 5, 2021

Hi @jpage4500, unfortunately I have been quite inactive with this project as I have been very busy with private projects. I've noticed this project have seen a lot of traction lately so I will try to be a bit more active here.

Thanks for the PR, I will review it asap!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants