Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM is breaking RES' expandos in comments and self posts #54

Open
Two-Tone opened this issue Oct 24, 2017 · 6 comments
Open

BPM is breaking RES' expandos in comments and self posts #54

Two-Tone opened this issue Oct 24, 2017 · 6 comments

Comments

@Two-Tone
Copy link

After a recent change to how RES does image expandos, BPM is now shoving the expandos about 70 pixels above where they should be and preventing them from being clickable. This only happens in comments (in submissions or user pages) since BPM only affects comments

@Ajedi32
Copy link
Contributor

Ajedi32 commented Oct 25, 2017

Possibly related to #41?

@Two-Tone
Copy link
Author

Two-Tone commented Oct 25, 2017

I doubt it. That bug is actually rather old (pretty sure well over a year), while this bug only appeared within the last 36 hours.

Also, source that RES has changed how they do expandos.

@DiscoPanda84
Copy link

Just out of curiosity, would an update for the new way that RES does image expandos break anything for people stuck on RES 5.6.5?

(Though I'm actually tempted to force-install a newer RES version to see how badly RES breaks when I do that, some other recently updated extensions that I've force-installed the latest versions of seem to work just fine anyways...)

@Two-Tone
Copy link
Author

Why are you stuck on 5.6.5?

@Shugabuga
Copy link
Contributor

Do you use Safari by any chance @DiscoPanda84?

@DiscoPanda84
Copy link

DiscoPanda84 commented Nov 14, 2017

@Two-Tone Because newer versions of RES apparently aren't a fan of Firefox 52.4.0, so I'll have to either cross my fingers, force the RES update, and hope it (mostly, at least) works anyways, or I'll have to wait until Firefox 52.8.0 rolls over to Firefox 59.2.0 to update RES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants