would you be open to merging with QMK upstream?

[yanfali]

Hi @Rozakiin

I have a friend who is interested in configuring his 268 using https://config.qmk.fm, would you open to having the 268 QMK code merged back into master? I would be happy to do this for you, or we would love to have a Pull Request. Also I work on the configurator and would be happy to help you set up an info.json file for the layout.

Many Thanks

Yan

[Rozakiin]

Hi Yan, Yes that would be great, i would have done so already except that the 268 pcb sources current for the caps lock indicator while the configurator sinks current, if a toggle could be made to the configurator to allow either sink or source then the 268 would be easy to implement. Kind regards, Rozakiin

…

On Tue, 3 Jul 2018, 22:32 Yan-Fa Li, ***@***.***> wrote: Hi @Rozakiin <https://github.com/Rozakiin> I have a friend who is interested in configuring his 268 using https://config.qmk.fm, would you open to having the 268 QMK code merged back into master? I would be happy to do this for you, or we would love to have a Pull Request. Also I work on the configurator and would be happy to help you set up an info.json file for the layout. Many Thanks Yan — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGQ0m8_2T3Dj-NGP7uYYEub7Ha_wTrc2ks5uC-LYgaJpZM4VBp9E> .

[yanfali]

Hi @Rozakiin

so if I understand the issue, the PCB deals with the caps lock indicator in a special way that's not typical for other QMK boards? I think that's only an issue for configurators like kbfirmware, because they use generic code. The QMK configurator uses the actual code for the board in the repo, so if it's handled in software we should do the right thing; I took a look at the default keymap for the 268 and it looks like all the LED code is in there.

We currently are very bare bones when it comes to handling options on configurator for the time being, @skullydazed is still working out how to support those things on the API. The UI pretty much only lets you configure keycodes and layers at this time.

Let me know if I have misunderstood you, as it's quite possible I have. Would you like to open a PR? Or would you prefer me to do it?

Thank you again

Yan

[yanfali]

Also, do you happen to have a KLE for the supported layout? I can whip one up, but it would save time if you had one. We use qmk.fm/converter to turn this into an info.json which is used to tell configurator how the board is physically laid out.

[Rozakiin]

Unfortunately i don't, only an image of the layout https://i.imgur.com/XwQl1PH.png

…

On Thu, 5 Jul 2018, 20:09 Yan-Fa Li, ***@***.***> wrote: Also, do you happen to have a KLE for the supported layout? I can whip one up, but it would save time if you had one. We use qmk.fm/converter to turn this into an info.json which is used to tell configurator how the board is physically laid out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGQ0m1Xqtq_fgapL11MimjJ3on9ynJiHks5uDmRygaJpZM4VBp9E> .

[yanfali]

Hi, I have opened a PR here, let me know if you see anything wrong. If you are happy with this then, maybe we could try importing some of the others.