Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectors/rubicon): correctly ladder nonces for ask/bid sides. #15

Open
daoio opened this issue Oct 28, 2024 · 0 comments
Open

fix(connectors/rubicon): correctly ladder nonces for ask/bid sides. #15

daoio opened this issue Oct 28, 2024 · 0 comments

Comments

@daoio
Copy link

daoio commented Oct 28, 2024

sometimes nonce manager produces the same nonces for both ask and bid sides.
E.g.:

desired nonces:
 ask: [1,2,3]
 bid: [4,5,6]

nonces we get:
 ask: [1,2,3]
 bid: [1,2,3]

Nonce reuse seems to occur during editOrder function call, where connector places orders with nonce, laddered in a way that's unaware of nonces already in use on the other side of the book. Such unawareness appears due to an RPC call via NonceManager, where it takes the last unused nonces of the account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant