NR2 does not error out on public crate item usage

[P-E-P]

Summary

The compiler should error out as MyStruct cannot be accessed.

Reproducer

I tried this code with flag -frust-name-resolution-2.0:

pub struct Str(i32);

mod test {

    pub fn test() -> Str {
        Str(0)
    }
}

Does the code make use of any (1.49) nightly feature ?

• Nightly

Godbolt link

https://godbolt.org/z/fr1Gs3dTc

Actual behavior

The compiler does not emit an error

Expected behavior

I expected to see an error suggesting use MyStruct.

GCC Version

commit hash: 9c6e09e

[CohenArthur]

I think this is more of an issue with the privacy checker in gcc/rust/check/errors/privacy/rust-privacy-check.cc. It only uses the old resolver instead of the new one

[P-E-P]

I think this is more of an issue with the privacy checker in gcc/rust/check/errors/privacy/rust-privacy-check.cc. It only uses the old resolver instead of the new one

I doubt it, the code also miscompile with old resolver.

[CohenArthur]

Well to be honest the privacy checker is something I wrote during my internship so it's probably really broken 😬 but since it's not critical for compiling correct code I think we shouldn't focus on this issue for now