Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of duplicate interface #3396

Open
philberty opened this issue Jan 29, 2025 · 0 comments
Open

Get rid of duplicate interface #3396

philberty opened this issue Jan 29, 2025 · 0 comments
Labels
cleanup good-first-pr

Comments

@philberty
Copy link
Member

philberty commented Jan 29, 2025 •
edited
Loading

We need to remove this helper:

gccrs/gcc/rust/typecheck/rust-typecheck-context.cc

Line 94 in 3c21102

TypeCheckContext::insert_implicit_type (TyTy::BaseType *type)

And instead we should be just calling:

gccrs/gcc/rust/typecheck/rust-typecheck-context.cc

Line 101 in 3c21102

TypeCheckContext::insert_implicit_type (HirId id, TyTy::BaseType *type)

and pass the hir id as part of the caller to make it more explicit that you need to think about what id you are using.
@philberty philberty changed the title Get rid of bad interface Get rid of duplicate interface Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good-first-pr
Projects
Project Pineapple
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philberty