Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why simplifier ticks become exhausted on old GHCs #51

Open
RyanGlScott opened this issue Jan 2, 2022 · 0 comments
Open

Investigate why simplifier ticks become exhausted on old GHCs #51

RyanGlScott opened this issue Jan 2, 2022 · 0 comments

Comments

@RyanGlScott
Copy link
Owner

Compiling text-show on GHC 8.0 and 8.2 has a tendency to exhaust the simplifier ticks. (See 0cba202 and #50 for examples of this.) Rather than blindly increase the simplifier tick limit to work around the issue, we should investigate if there is a more robust fix that can be applied in the code itself. It is likely that text-show's aggressive use of the INLINE pragmas has something to do with it, although it is not yet clear to me which INLINE pragmas would be best to remove.
RyanGlScott added a commit that referenced this issue Jan 2, 2022
@RyanGlScott
Increase the simplifier tick limit on GHC 8.0
ce740bc 
This is a crude but effective workaround for #50. I have opened #51 as a
reminder to investigate this more carefully and come up with a more robust fix.

Resolves #50.
This was referenced Jan 2, 2022
Merged
Closed
RyanGlScott added a commit that referenced this issue Jan 2, 2022
@RyanGlScott
Increase the simplifier tick limit on GHC 8.0
4f0f1b0 
This is a crude but effective workaround for #50. I have opened #51 as a
reminder to investigate this more carefully and come up with a more robust fix.

Resolves #50.
RyanGlScott added a commit to RyanGlScott/text-show-instances that referenced this issue Mar 26, 2022
@RyanGlScott
Set -fsimpl-tick-factor=200 in Data.Binary when using GHC 8.0
ff44cc2 
Alas, the same problems that plagued `text-show` in RyanGlScott/text-show#50
are now showing up in `text-show-instances` as well. For now, I'll apply the
same short-term fix as in RyanGlScott/text-show#50. See
RyanGlScott/text-show#51 for an issue tracking a longer-term solution.
RyanGlScott added a commit that referenced this issue Oct 2, 2022
@RyanGlScott
GHC 8.0 tick factor tweaks
a6fb958 
Sigh. See #51.
RyanGlScott added a commit that referenced this issue Oct 4, 2022
@RyanGlScott
GHC 8.0 tick factor tweaks
6492ee1 
Sigh. See #51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RyanGlScott