Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three points are out of error-bounded while testing OptimalPLR with fb data #2

Open
lcgong opened this issue Feb 5, 2023 · 0 comments

Comments

@lcgong
Copy link

lcgong commented Feb 5, 2023

While testing OptimalPLR with fb data, there are 3 points (166, 167, 168) out of error-bounded, gamma=64.

        let mut plr = OptimalPLR::new(64.0);
        let data = fb_data();

        let mut segments = Vec::new();

        for &(x, y) in data.iter() {
            if let Some(segment) = plr.process(x, y) {
                segments.push(segment);
            }
        }

        if let Some(segment) = plr.finish() {
            segments.push(segment);
        }

        verify_gamma(64.0, &data, &segments);
thread 'regression::optimal::test::test_optimal_fb' panicked at 'Prediction of 101.56824225187302 was not within gamma (64) of true value 166', src/test_util.rs:94:9

The intersection pint of red lines is the 166 data point (2979233417017651200, 166).
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant