From 318498eab05f87546fb10a85bd376bdf8be33d3f Mon Sep 17 00:00:00 2001 From: Evan Husted Date: Mon, 30 Dec 2024 20:57:18 -0600 Subject: [PATCH] misc: prefix ValidationTask with I, it's an interface Mention in PR comment script that you now need to be logged into GitHub to download artifacts. --- .github/workflows/nightly_pr_comment.yml | 2 +- .../{ValidationTask.cs => IValidationTask.cs} | 2 +- src/Ryujinx.BuildValidationTasks/LocalesValidationTask.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename src/Ryujinx.BuildValidationTasks/{ValidationTask.cs => IValidationTask.cs} (76%) diff --git a/.github/workflows/nightly_pr_comment.yml b/.github/workflows/nightly_pr_comment.yml index 6ca4710dce..fb7cdb359d 100644 --- a/.github/workflows/nightly_pr_comment.yml +++ b/.github/workflows/nightly_pr_comment.yml @@ -37,7 +37,7 @@ jobs: if (!artifacts.length) { return core.error(`No artifacts found`); } - let body = `Download the artifacts for this pull request:\n`; + let body = `*You need to be logged into GitHub to download these files.*\n\nDownload the artifacts for this pull request:\n`; let hidden_debug_artifacts = `\n\n
Only for Developers\n`; for (const art of artifacts) { const url = `https://github.com/Ryubing/Ryujinx/actions/runs/${run_id}/artifacts/${art.id}`; diff --git a/src/Ryujinx.BuildValidationTasks/ValidationTask.cs b/src/Ryujinx.BuildValidationTasks/IValidationTask.cs similarity index 76% rename from src/Ryujinx.BuildValidationTasks/ValidationTask.cs rename to src/Ryujinx.BuildValidationTasks/IValidationTask.cs index f11c87f3be..682d79a0a1 100644 --- a/src/Ryujinx.BuildValidationTasks/ValidationTask.cs +++ b/src/Ryujinx.BuildValidationTasks/IValidationTask.cs @@ -1,6 +1,6 @@ namespace Ryujinx.BuildValidationTasks { - public interface ValidationTask + public interface IValidationTask { public bool Execute(string projectPath, bool isGitRunner); } diff --git a/src/Ryujinx.BuildValidationTasks/LocalesValidationTask.cs b/src/Ryujinx.BuildValidationTasks/LocalesValidationTask.cs index 05eaee5396..1f2c39e954 100644 --- a/src/Ryujinx.BuildValidationTasks/LocalesValidationTask.cs +++ b/src/Ryujinx.BuildValidationTasks/LocalesValidationTask.cs @@ -7,7 +7,7 @@ namespace Ryujinx.BuildValidationTasks { - public class LocalesValidationTask : ValidationTask + public class LocalesValidationTask : IValidationTask { public LocalesValidationTask() { }