Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teach users to run inference app locally #236

Merged
merged 4 commits into from
Jun 12, 2024
Merged

teach users to run inference app locally #236

merged 4 commits into from
Jun 12, 2024

Conversation

rccreswell
Copy link
Contributor

We link to the app landing page in the first section of the 2022 paper (and some other places I have recently mentioned this...) so I think we should try and avoid having a flagrant broken link from the heroku.

Obviously it would be ideal to do another deployment, but as a makeshift solution I would suggest just instructing them how to run the app locally using the package, which is what this PR implements, but happy to hear any other suggestions.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f7f43ef) to head (d46e099).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1174      1172    -2     
=========================================
- Hits          1174      1172    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FarmHJ FarmHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the index.html file, it is not clear which link you are referring to in "see Github link below". Also, we could emphasise that this method is used to run the app locally by making a minor change to 'To access the app locally in your browser'.

@rccreswell
Copy link
Contributor Author

rccreswell commented Jun 11, 2024

In the index.html file, it is not clear which link you are referring to in "see Github link below". Also, we could emphasise that this method is used to run the app locally by making a minor change to 'To access the app locally in your browser'.

Thank you for your suggestions, I reordered it to hopefully be slightly clearer

Copy link
Contributor

@FarmHJ FarmHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rccreswell rccreswell merged commit 7d4cd8a into main Jun 12, 2024
11 checks passed
@rccreswell rccreswell deleted the app_server_down branch June 12, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants