-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teach users to run inference app locally #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1174 1172 -2
=========================================
- Hits 1174 1172 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the index.html file, it is not clear which link you are referring to in "see Github link below". Also, we could emphasise that this method is used to run the app locally by making a minor change to 'To access the app locally in your browser'.
Thank you for your suggestions, I reordered it to hopefully be slightly clearer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We link to the app landing page in the first section of the 2022 paper (and some other places I have recently mentioned this...) so I think we should try and avoid having a flagrant broken link from the heroku.
Obviously it would be ideal to do another deployment, but as a makeshift solution I would suggest just instructing them how to run the app locally using the package, which is what this PR implements, but happy to hear any other suggestions.