Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contouring function sometimes errors for False Bay Forecast #25

Open
zachsa opened this issue Nov 28, 2022 · 1 comment
Open

Contouring function sometimes errors for False Bay Forecast #25

zachsa opened this issue Nov 28, 2022 · 1 comment

Comments

@zachsa
Copy link
Collaborator

zachsa commented Nov 28, 2022

Sometimes the False Bay Forecast contours don't generate with correct values

Sometimes the page draws this (broken)
image

But a couple time steps on and things start working again - and looking like this
image

Comparing the data between a page that renders and a page that doesn't, it isn't immediately obvious what the difference is. To debug this the broken data must be compared to the working data

Broken example

dataName = 'data-that-breaks-things.json'
resultName = 'contours-from-data-that-breaks-things.json'

const width = 89
const height = 77
const polys = contours().thresholds(50).size([width, height])(data)

Working example

dataName = 'data-that-works.json'
resultName = 'contours-from-data-that-works.json'

const width = 89
const height = 77
const polys = contours().thresholds(50).size([width, height])(data)

Here are the data files (Google Drive)

There are also usually frames where there are holes in the contours:

image

@zachsa
Copy link
Collaborator Author

zachsa commented Jan 10, 2023

This looks like it may be related (TBC). d3/d3-contour#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant