Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow termination grace period to be defined per job #371

Open
musse opened this issue Jan 13, 2020 · 0 comments
Open

Allow termination grace period to be defined per job #371

musse opened this issue Jan 13, 2020 · 0 comments

Comments

@musse
Copy link
Contributor

musse commented Jan 13, 2020

Is your feature request related to a problem? Please describe.
Infrabox does not let its jobs gracefully terminate, meaning they can not run any needed tear down procedures if the job is terminated prematurely (e.g. job aborted or restarted). The grace period is hard-coded to zero on the coding. The k8s default is 30 seconds. Any clean up must be executed on a separate job, which is error-prone and may require passing data from one job to another.

Describe the solution you'd like
Make the grace period configurable so that an Infrabox job can catch the termination signal when it is being deleted and clean up after itself. Add a field to the job definition to define the grace period and use it when creating the k8s job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant