From ecca3a247380e7930eea2d2090c2821c2549cd2a Mon Sep 17 00:00:00 2001 From: Raghavendran M Date: Tue, 5 Nov 2024 16:13:06 +0530 Subject: [PATCH] Fixed AFF review comments. --- file-formats/intm/README.md | 2 +- ...=> sapq0lic8p8o65ew6afk3aen3gp3.intm.json} | 20 +++++----- file-formats/intm/intm-v1.json | 28 +++++++------- .../intm/type/zif_aff_intm_v1.intf.abap | 38 +++++++++---------- 4 files changed, 44 insertions(+), 44 deletions(-) rename file-formats/intm/examples/{saplvfkd32izflkp5or2uqi1jlc4.intm.json => sapq0lic8p8o65ew6afk3aen3gp3.intm.json} (79%) diff --git a/file-formats/intm/README.md b/file-formats/intm/README.md index e687728f6..57b23f27f 100644 --- a/file-formats/intm/README.md +++ b/file-formats/intm/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`saplvfkd32izflkp5or2uqi1jlc4.intm.json`](./examples/saplvfkd32izflkp5or2uqi1jlc4.intm.json) +`.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`sapq0lic8p8o65ew6afk3aen3gp3.intm.json`](./examples/sapq0lic8p8o65ew6afk3aen3gp3.intm.json) diff --git a/file-formats/intm/examples/saplvfkd32izflkp5or2uqi1jlc4.intm.json b/file-formats/intm/examples/sapq0lic8p8o65ew6afk3aen3gp3.intm.json similarity index 79% rename from file-formats/intm/examples/saplvfkd32izflkp5or2uqi1jlc4.intm.json rename to file-formats/intm/examples/sapq0lic8p8o65ew6afk3aen3gp3.intm.json index ff3624d5a..09d20fb29 100644 --- a/file-formats/intm/examples/saplvfkd32izflkp5or2uqi1jlc4.intm.json +++ b/file-formats/intm/examples/sapq0lic8p8o65ew6afk3aen3gp3.intm.json @@ -4,29 +4,29 @@ "description": "Model creation test via ADT", "originalLanguage": "en" }, - "intelligentModel": { - "name": "RM_TEST_ADT_959_MOD", - "intelligentScenario": "RM_TEST_ADT_959", - "modellingContextId": "0405E348470277F0EBDAEF4E3CEC2C31", + "intelligentScenarioModel": { + "modelName": "RM_TEST_ADT_964_MOD", + "intelligentScenario": "RM_TEST_ADT_964", + "modellingContextId": "CFFE69A6585C4DFB6846A4C003FDCFE2", "modelType": "SAPGENAI", "adapterId": "SAPGENAI.Default", "nativeModelType": "SAPGENAI.Default", "state": "Published", "executableId": "azure-openai", "llmName": "gpt-4", - "llmModelVersion": "0613" + "llmVersion": "0613" }, - "promptTemplates": [ + "modelPromptTemplates": [ { - "name": "SYSTEM_PROMPT", - "description": "System prompt", + "promptTemplateName": "SYSTEM_PROMPT", + "promptTemplateDescription": "System prompt", "prompt": "You are a sales executive who is responsible for reaching out to customers for confirming or declining their orders. Evaluate the size of the delivery vehicle based on the number of items. Calculate the distance between the billing and delivery location in kilometers. \n\nThe subject of email should be of format \nThe body of email should be of format: \"\"\"\"SO contains to be delivered to . And will be delivered via a vehicle. \nIF > 100 kms THEN include a message about potential delivery delays ELSE congratulate on being eligible for one day delivery", "promptParameters": "[]", "isVisible": true }, { - "name": "USER_PROMPT", - "description": "User prompt", + "promptTemplateName": "USER_PROMPT", + "promptTemplateDescription": "User prompt", "prompt": "Build a confirmation mail for a sales order containing {ISLM_Items} where the items are categorized for example pencil and paper will be stationary, printer and mouse will be electronics. The source address contains {ISLM_Source} and the delivery address is in {ISLM_Destination}.", "promptParameters": "[{\"Name\":\"ISLM_Items\",\"Value\":\"\"},{\"Name\":\"ISLM_Source\",\"Value\":\"\"},{\"Name\":\"ISLM_Destination\",\"Value\":\"\"}]", "isVisible": true diff --git a/file-formats/intm/intm-v1.json b/file-formats/intm/intm-v1.json index 9b9ffa70d..bffcbb980 100644 --- a/file-formats/intm/intm-v1.json +++ b/file-formats/intm/intm-v1.json @@ -57,12 +57,12 @@ "originalLanguage" ] }, - "intelligentModel": { + "intelligentScenarioModel": { "title": "Intelligent Scenario Model", "description": "Intelligent scenario model", "type": "object", "properties": { - "name": { + "modelName": { "title": "Model Name", "description": "Model name", "type": "string", @@ -125,7 +125,7 @@ "type": "string" }, "isEnhancement": { - "title": "Model flag", + "title": "Is Enhancement", "description": "If true, the model is an enhancement, if false the model is a new model.", "type": "boolean" }, @@ -140,16 +140,16 @@ "description": "Large language model name", "type": "string" }, - "llmModelVersion": { - "title": "LLM Model Version", - "description": "LLM model version", + "llmVersion": { + "title": "Large Language Model Version", + "description": "Large language model version", "type": "string", "maxLength": 30 } }, "additionalProperties": false }, - "segmentFields": { + "modelSegmentFields": { "title": "Model Segment Fields", "description": "Model segment fields", "type": "array", @@ -158,7 +158,7 @@ "description": "Model segment field", "type": "object", "properties": { - "fieldname": { + "fieldName": { "title": "Field Name", "description": "Table or view field name", "type": "string", @@ -180,7 +180,7 @@ "additionalProperties": false } }, - "promptTemplates": { + "modelPromptTemplates": { "title": "Model Prompt Templates", "description": "Model prompt templates", "type": "array", @@ -189,14 +189,14 @@ "description": "Model prompt template", "type": "object", "properties": { - "name": { + "promptTemplateName": { "title": "Prompt Template Name", "description": "Prompt template name", "type": "string", "maxLength": 30 }, - "description": { - "title": "Description", + "promptTemplateDescription": { + "title": "Prompt Template Description", "description": "Description of prompt template", "type": "string" }, @@ -218,7 +218,7 @@ }, "additionalProperties": false, "required": [ - "name", + "promptTemplateName", "prompt" ] } @@ -228,6 +228,6 @@ "required": [ "formatVersion", "header", - "intelligentModel" + "intelligentScenarioModel" ] } diff --git a/file-formats/intm/type/zif_aff_intm_v1.intf.abap b/file-formats/intm/type/zif_aff_intm_v1.intf.abap index 3ed31ee62..b1a24aeaf 100644 --- a/file-formats/intm/type/zif_aff_intm_v1.intf.abap +++ b/file-formats/intm/type/zif_aff_intm_v1.intf.abap @@ -4,10 +4,10 @@ INTERFACE zif_aff_intm_v1 TYPES: "!

Intelligent Scenario Model

"! Intelligent scenario model - BEGIN OF ty_intelligent_model, + BEGIN OF ty_intelligent_scenario_model, "!

Model Name

"! Model name - name TYPE c LENGTH 30, + model_name TYPE c LENGTH 30, "!

Intelligent Scenario

"! Intelligent scenario of the model intelligent_scenario TYPE c LENGTH 20, @@ -38,7 +38,7 @@ INTERFACE zif_aff_intm_v1 "!

Bindings

"! Model bindings bindings TYPE string, - "!

Model flag

+ "!

Is Enhancement

"! If true, the model is an enhancement, if false the model is a new model. is_enhancement TYPE abap_bool, "!

Executable ID

@@ -47,17 +47,17 @@ INTERFACE zif_aff_intm_v1 "!

Large Language Model Name

"! Large language model name llm_name TYPE string, - "!

LLM Model Version

- "! LLM model version - llm_model_version TYPE c LENGTH 30, - END OF ty_intelligent_model, + "!

Large Language Model Version

+ "! Large language model version + llm_version TYPE c LENGTH 30, + END OF ty_intelligent_scenario_model, "!

Segment Field

"! Model segment field BEGIN OF ty_segment_field, "!

Field Name

"! Table or view field name - fieldname TYPE c LENGTH 30, + field_name TYPE c LENGTH 30, "!

Position

"! Field position field_position TYPE i, @@ -72,40 +72,40 @@ INTERFACE zif_aff_intm_v1 "!

Prompt Template Name

"! Prompt template name "! $required - name TYPE c LENGTH 30, - "!

Description

+ prompt_template_name TYPE c LENGTH 30, + "!

Prompt Template Description

"! Description of prompt template - description TYPE string, + prompt_template_description TYPE string, "!

Prompt

"! Prompt "! $required - prompt TYPE string, + prompt TYPE string, "!

Prompt Parameters

"! Prompt parameters - prompt_parameters TYPE string, + prompt_parameters TYPE string, "!

Prompt Visibility

"! If true, the prompt is visible - is_visible TYPE abap_bool, + is_visible TYPE abap_bool, END OF ty_prompt_template, "!

Intelligent scenario Models

"! Intelligent scenario model BEGIN OF ty_main, "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60, + header TYPE zif_aff_types_v1=>ty_header_60, "!

Intelligent Scenario Model

"! Intelligent scenario model "! $required - intelligent_model TYPE ty_intelligent_model, + intelligent_scenario_model TYPE ty_intelligent_scenario_model, "!

Model Segment Fields

"! Model segment fields - segment_fields TYPE STANDARD TABLE OF ty_segment_field WITH DEFAULT KEY, + model_segment_fields TYPE STANDARD TABLE OF ty_segment_field WITH DEFAULT KEY, "!

Model Prompt Templates

"! Model prompt templates - prompt_templates TYPE STANDARD TABLE OF ty_prompt_template WITH DEFAULT KEY, + model_prompt_templates TYPE STANDARD TABLE OF ty_prompt_template WITH DEFAULT KEY, END OF ty_main. ENDINTERFACE.