From 002ed004884c5376f516bfc3e46d16d87933a475 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Tue, 17 Sep 2024 07:38:07 +0530 Subject: [PATCH 01/21] [EDCC] Add new object type for EDCC --- file-formats/edcc/README.md | 5 + file-formats/edcc/edcc-v1.json | 590 ++++++++++++++++++ .../edcc/type/zif_aff_edcc_v1.intf.abap | 443 +++++++++++++ .../edcc/type/zif_aff_edcc_v1.intf.json | 7 + 4 files changed, 1045 insertions(+) create mode 100644 file-formats/edcc/README.md create mode 100644 file-formats/edcc/edcc-v1.json create mode 100644 file-formats/edcc/type/zif_aff_edcc_v1.intf.abap create mode 100644 file-formats/edcc/type/zif_aff_edcc_v1.intf.json diff --git a/file-formats/edcc/README.md b/file-formats/edcc/README.md new file mode 100644 index 000000000..045148efe --- /dev/null +++ b/file-formats/edcc/README.md @@ -0,0 +1,5 @@ +# EDCC File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.edcc.json` | 1 | [`zif_aff_edcc_v1.intf.abap`](./type/zif_aff_edcc_v1.intf.abap) | [`edcc-v1.json`](./edcc-v1.json) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json new file mode 100644 index 000000000..290807f6d --- /dev/null +++ b/file-formats/edcc/edcc-v1.json @@ -0,0 +1,590 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edcc/edcc-v1.json", + "title": "Consistency Scenario", + "description": "Consistency scenario", + "type": "object", + "properties": { + "formatVersion": { + "title": "ABAP File Format Version", + "description": "The ABAP file format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2 + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "country": { + "title": "Country", + "description": "Country", + "type": "string", + "maxLength": 3 + }, + "taxauthMessages": { + "title": "Tax Authority Message Types", + "description": "Tax authority message types", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Tax Authority Message Type", + "description": "Tax Authority Message type", + "type": "object", + "properties": { + "messageType": { + "title": "Message Type", + "description": "Message type", + "type": "string", + "maxLength": 20 + }, + "messageTypeDescription": { + "title": "Message Type Description", + "description": "Message type description", + "type": "string", + "maxLength": 30 + }, + "taxauthDocumenttype": { + "title": "Tax Authority Document Type", + "description": "Tax authority document type", + "type": "string", + "maxLength": 20 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2 + } + }, + "additionalProperties": false + } + }, + "taxauthTables": { + "title": "Additional Tax Authority Tables", + "description": "Additional tax authority tables", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Additional Tax Authority Table", + "description": "Additional tax authority table", + "type": "object", + "properties": { + "tableName": { + "title": "Table Name", + "description": "Table name", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false + } + }, + "comparisonTypes": { + "title": "Comparison Types", + "description": "Define comparison types", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Comparison Type", + "description": "Comparison type", + "type": "object", + "properties": { + "comparisonType": { + "title": "Comparison Type", + "description": "Comparison type", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Comparison Type Description", + "description": "Description of the comparison type", + "type": "string", + "maxLength": 120 + }, + "positionNumber": { + "title": "Position Number", + "description": "position number", + "type": "string", + "maxLength": 2 + }, + "className": { + "title": "Implementing Class", + "description": "Implementing Class", + "type": "string", + "maxLength": 30 + }, + "dataSource": { + "title": "Data Source", + "description": "Data Source", + "type": "string", + "maxLength": 30 + }, + "existenceCheck": { + "title": "Existence Check", + "description": "Assigned existence check", + "type": "object", + "properties": { + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Check Description", + "description": "Check description", + "type": "string", + "maxLength": 60 + }, + "fieldName": { + "title": "Field Name", + "description": "Field name", + "type": "string", + "maxLength": 30 + }, + "fieldValue": { + "title": "Field Value", + "description": "Field value", + "type": "string", + "maxLength": 40 + }, + "resultProcess": { + "title": "Result Process", + "description": "Result process", + "type": "string", + "maxLength": 10 + } + }, + "additionalProperties": false + }, + "statusCheck": { + "title": "Status Checks", + "description": "Assigned status checks", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Status Check", + "description": "status check", + "type": "object", + "properties": { + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Check Description", + "description": "Check description", + "type": "string", + "maxLength": 60 + }, + "sequenceNumber": { + "title": "Sequence Number", + "description": "Sequence number", + "type": "string", + "maxLength": 3 + }, + "sourceFieldname1": { + "title": "Source Field Name 1", + "description": "Source field name 1", + "type": "string", + "maxLength": 30 + }, + "sourceFieldvalue1": { + "title": "Source Field Value 1", + "description": "Source field value 1", + "type": "string", + "maxLength": 40 + }, + "sourceFieldname2": { + "title": "Source Field Name 2", + "description": "Source field name 2", + "type": "string", + "maxLength": 30 + }, + "sourceFieldvalue2": { + "title": "Source Field Value 2", + "description": "Source field value 2", + "type": "string", + "maxLength": 40 + }, + "resultProcess": { + "title": "Result Process", + "description": "Result process", + "type": "string", + "maxLength": 10 + } + }, + "additionalProperties": false + } + }, + "contentCheck": { + "title": "Content Checks", + "description": "Assigned content checks", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Content Check", + "description": "Content check", + "type": "object", + "properties": { + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Check Description", + "description": "Check description", + "type": "string", + "maxLength": 60 + }, + "checkNumber": { + "title": "Check Number", + "description": "Check number", + "type": "string", + "maxLength": 5 + }, + "dataSource": { + "title": "Additional Data Source", + "description": "Additional data source", + "type": "string", + "maxLength": 30 + }, + "additionalDescription": { + "title": "Additional Description", + "description": "Additional check description", + "type": "string", + "maxLength": 60 + }, + "contentComparisonFieldgroup": { + "title": "Comparison Field Groups", + "description": "Comparison field groups", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Comparison Field Group", + "description": "Comparison field group", + "type": "object", + "properties": { + "fieldGroup": { + "title": "Mismatch Field Group", + "description": "Comparison field group for mismatched fields", + "type": "string", + "maxLength": 20 + }, + "description": { + "title": "Description", + "description": "Mismatch field group description", + "type": "string", + "maxLength": 30 + }, + "fieldGroupLevel": { + "title": "Field Group Level", + "description": "Level of comparison field group", + "type": "string", + "enum": [ + "header", + "item" + ], + "enumTitles": [ + "Header", + "Item" + ], + "enumDescriptions": [ + "Header", + "Item" + ], + "default": "header" + }, + "checkFormula": { + "title": "Check Formula", + "description": "Formula applied to do content check for the field group", + "type": "string", + "enum": [ + "field", + "fieldWithAbstolerance", + "fieldWithNonabstolerance" + ], + "enumTitles": [ + "Field to Field Comparison", + "Amount Comparison with Absolute Tolerance", + "Amount Comparison without Absolute Tolerance" + ], + "enumDescriptions": [ + "Field to field comparison", + "Amount comparison with absolute tolerance", + "Amount comparison without absolute tolerance" + ], + "default": "field" + }, + "resultProcess": { + "title": "Result Process", + "description": "Result process", + "type": "string", + "maxLength": 10 + }, + "comparisonField": { + "title": "Fields Configuration", + "description": "Configuration of fields those would be compared", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Fields Configuration", + "description": "Configuration of field those would be compared", + "type": "object", + "properties": { + "representationType": { + "title": "Representation Type", + "description": "Representation type", + "type": "string", + "maxLength": 30 + }, + "fieldName": { + "title": "Field Name", + "description": "Field name to be compared", + "type": "string", + "maxLength": 30 + }, + "comparisonSequence": { + "title": "Comparison Sequence", + "description": "Comparison sequence", + "type": "string", + "maxLength": 5 + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false + } + }, + "checkAttributes": { + "title": "Check Attributes", + "description": "Check attributes", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Check Attribute", + "description": "Check attribute", + "type": "object", + "properties": { + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + }, + "positionNumber": { + "title": "Position Number", + "description": "Position number", + "type": "string", + "maxLength": 3 + }, + "executionSequence": { + "title": "Check Execution Sequence", + "description": "Check execution sequence", + "type": "string", + "maxLength": 3 + }, + "executionControl": { + "title": "Check Execution Control", + "description": "Check execution control", + "type": "string", + "enum": [ + "proceed", + "noProceed" + ], + "enumTitles": [ + "No Check", + "Proceed If No Inconsistency Identified From Previous Check" + ], + "enumDescriptions": [ + "Proceed with check even when inconsistency is identified", + "Proceed If No Inconsistency Identified From Previous Check" + ], + "default": "proceed" + }, + "checkFilter": { + "title": "Selection Filters on Check", + "description": "Selection filters on check", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Selection Filters on Check", + "description": "Selection filters on check", + "type": "object", + "properties": { + "sequenceNumber": { + "title": "Sequence Number", + "description": "Sequence number", + "type": "string", + "maxLength": 3 + }, + "filterOperation": { + "title": "Filter Operation", + "description": "Operand to build the where condition", + "type": "string", + "enum": [ + "and", + "or" + ], + "enumTitles": [ + "And", + "Or" + ], + "enumDescriptions": [ + "And", + "Or" + ], + "default": "and" + }, + "filterField": { + "title": "Filter Field", + "description": "Field on which where condition would be applied", + "type": "string", + "maxLength": 30 + }, + "comparisonOperator": { + "title": "Comparison Operator", + "description": "Comparison operator", + "type": "string", + "enum": [ + "equal", + "notEqual" + ], + "enumTitles": [ + "Equal", + "Not Equal" + ], + "enumDescriptions": [ + "Equal", + "Not Equal" + ], + "default": "equal" + }, + "filterValue": { + "title": "Filter Field Value", + "description": "Value used to build the where condition", + "type": "string", + "maxLength": 30 + }, + "expressionIndicator": { + "title": "Expression Indicator", + "description": "Expression indicator", + "type": "string", + "enum": [ + "beginof", + "endof" + ], + "enumTitles": [ + "Begin of Expression", + "End of Expression" + ], + "enumDescriptions": [ + "Begin of expression", + "End of Eexpression" + ], + "default": "beginof" + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false + } + }, + "representationTypes": { + "title": "Representation Types", + "description": "Assigned representation types", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Representation Type", + "description": "Assigned representation type", + "type": "object", + "properties": { + "representationType": { + "title": "Assigned Representation Type", + "description": "Assigned representation type", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Description", + "description": "Description", + "type": "string", + "maxLength": 60 + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false, + "required": [ + "comparisonType", + "description", + "positionNumber", + "className", + "dataSource", + "existenceCheck", + "checkAttributes", + "representationTypes" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header" + ] +} diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap new file mode 100644 index 000000000..c10b70a5b --- /dev/null +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -0,0 +1,443 @@ +INTERFACE zif_aff_edcc_v1 + PUBLIC . + "!

Country

+ "! Country + TYPES ty_country TYPE c LENGTH 3. + + TYPES ty_short_description TYPE c LENGTH 30. + + TYPES: + "!

Tax Authority Message Type

+ "! Tax Authority Message type + BEGIN OF ty_messages, + "!

Message Type

+ "! Message type + message_type TYPE c LENGTH 20, + "!

Message Type Description

+ "! Message type description + message_type_description TYPE ty_short_description, + "!

Tax Authority Document Type

+ "! Tax authority document type + taxauth_documenttype TYPE c LENGTH 20, + original_language TYPE zif_aff_types_v1=>ty_original_language, + END OF ty_messages, + "!

Tax Authority Message Types

+ "! Tax Authority Message types + tt_messages TYPE SORTED TABLE OF ty_messages WITH UNIQUE KEY message_type. + + TYPES: + "!

Additional Tax Authority Table

+ "! Additional tax authority table + BEGIN OF ty_taxauth_table, + "!

Table Name

+ "! Table name + table_name TYPE zif_aff_types_v1=>ty_object_name_30, + END OF ty_taxauth_table, + "!

Additional Tax Authority Tables

+ "! Additional tax authority tables + tt_taxauth_table TYPE SORTED TABLE OF ty_taxauth_table WITH UNIQUE KEY table_name. + + TYPES: + "!

Position Number

+ "! position number + ty_position_number TYPE c LENGTH 2, + "!

Result Process

+ "! Result process + ty_result_process TYPE c LENGTH 10, + "!

Field Value

+ "! Field value + ty_field_value TYPE c LENGTH 40, + "!

Sequence Number

+ "! Sequence number + ty_sequence_number TYPE c LENGTH 3, + "!

Check Number

+ "! Check number + ty_check_number TYPE c LENGTH 5, + ty_long_description TYPE c LENGTH 120. + + TYPES: + "!

Existence Check

+ "! Assigned existence check + BEGIN OF ty_existence_check, + "!

Check Id

+ "! Check id + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Check Description

+ "! Check description + description TYPE zif_aff_types_v1=>ty_description_60, + "!

Field Name

+ "! Field name + field_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Field Value

+ "! Field value + field_value TYPE ty_field_value, + "!

Result Process

+ "! Result process + result_process TYPE ty_result_process, + END OF ty_existence_check. + + TYPES: + "!

Status Check

+ "! status check + BEGIN OF ty_status_check, + "!

Check Id

+ "! Check id + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Check Description

+ "! Check description + description TYPE zif_aff_types_v1=>ty_description_60, + "!

Sequence Number

+ "! Sequence number + sequence_number TYPE ty_sequence_number, + "!

Source Field Name 1

+ "! Source field name 1 + source_fieldname1 TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Source Field Value 1

+ "! Source field value 1 + source_fieldvalue1 TYPE ty_field_value, + "!

Source Field Name 2

+ "! Source field name 2 + source_fieldname2 TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Source Field Value 2

+ "! Source field value 2 + source_fieldvalue2 TYPE ty_field_value, + "!

Result Process

+ "! Result process + result_process TYPE ty_result_process, + END OF ty_status_check, + "!

Status Checks

+ "! Assigned status checks + ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number. + + TYPES: + "!

Mismatch Field Group

+ "! Comparison field group for mismatched fields + ty_fieldgroup TYPE c LENGTH 20, + "!

Field Group Level

+ "! Level of comparison field group + "! $values {@link zif_aff_edcc_v1.data:co_fieldgrouplevel} + "! $default {@link zif_aff_edcc_v1.data:co_fieldgrouplevel.header} + ty_fieldgroup_level TYPE c LENGTH 1, + ty_comparison_sequence TYPE c LENGTH 5, + "!

Check Formula

+ "! Formula applied to do content check for the field group + "! $values {@link zif_aff_edcc_v1.data:co_checkformula} + "! $default {@link zif_aff_edcc_v1.data:co_checkformula.field} + ty_checkformula TYPE c LENGTH 1. + CONSTANTS: + "!

Check Formula

+ "! Formula applied to do content check for the field group + BEGIN OF co_checkformula, + "!

Field to Field Comparison

+ "! Field to field comparison + field TYPE ty_checkformula VALUE '1', + "!

Amount Comparison with Absolute Tolerance

+ "! Amount comparison with absolute tolerance + field_with_abstolerance TYPE ty_checkformula VALUE '2', + "!

Amount Comparison without Absolute Tolerance

+ "! Amount comparison without absolute tolerance + field_with_nonabstolerance TYPE ty_checkformula VALUE '3', + END OF co_checkformula, + "!

Field Group Level

+ "! Level of comparison field group + BEGIN OF co_fieldgrouplevel, + "!

Header

+ "! Header + header TYPE ty_fieldgroup_level VALUE 'H', + "!

Item

+ "! Item + item TYPE ty_fieldgroup_level VALUE 'I', + END OF co_fieldgrouplevel. + + TYPES: + "!

Fields Configuration

+ "! Configuration of field those would be compared + BEGIN OF ty_comparison_field, + "!

Representation Type

+ "! Representation type + representation_type TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Field Name

+ "! Field name to be compared + field_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Comparison Sequence

+ "! Comparison sequence + comparison_sequence TYPE ty_comparison_sequence, + END OF ty_comparison_field, + "!

Fields Configuration

+ "! Configuration of fields those would be compared + ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. + + TYPES: + + "!

Comparison Field Group

+ "! Comparison field group + BEGIN OF ty_comparison_fieldgroup, + "!

Mismatch Field Group

+ "! Comparison field group for mismatched fields + field_group TYPE ty_fieldgroup, + "!

Description

+ "! Mismatch field group description + description TYPE ty_short_description, + "!

Field Group Level

+ "! Level of comparison field group + field_group_level TYPE ty_fieldgroup_level, + "!

Check Formula

+ "! Formula applied to do content check for the field group + check_formula TYPE ty_checkformula, + "!

Result Process

+ "! Result process + result_process TYPE ty_result_process, + "!

Fields Configuration

+ "! Configuration of fields those would be compared + comparison_field TYPE ty_comparison_fields, + END OF ty_comparison_fieldgroup, + "!

Comparison Field Groups

+ "! Comparison field groups + ty_comparison_fieldgroups TYPE SORTED TABLE OF ty_comparison_fieldgroup + WITH UNIQUE KEY field_group. + TYPES: + "!

Content Check

+ "! Content check + BEGIN OF ty_content_check, + "!

Check Id

+ "! Check id + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Check Description

+ "! Check description + description TYPE zif_aff_types_v1=>ty_description_60, + "!

Check Number

+ "! Check number + check_number TYPE ty_check_number, + "!

Additional Data Source

+ "! Additional data source + data_source TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Additional Description

+ "! Additional check description + additional_description TYPE zif_aff_types_v1=>ty_description_60, + "!

Comparison Field Groups

+ "! Comparison field groups + content_comparison_fieldgroup TYPE ty_comparison_fieldgroups, + END OF ty_content_check, + + "!

Content Checks

+ "! Assigned content checks + ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number. + + TYPES: + "!

Filter Operation

+ "! Operand to build the where condition + "! $values {@link zif_aff_edcc_v1.data:co_filteroperation} + "! $default {@link zif_aff_edcc_v1.data:co_filteroperation.and} + ty_filter_operation TYPE c LENGTH 3, + "!

Comparison Operator

+ "! Comparison operator + "! $values {@link zif_aff_edcc_v1.data:co_compareoperation} + "! $default {@link zif_aff_edcc_v1.data:co_compareoperation.equal} + ty_comparison_operator TYPE c LENGTH 3, + "!

Filter Field Value

+ "! Value used to build the where condition + ty_filter_value TYPE c LENGTH 30, + "!

Expression Indicator

+ "! Expression indicator + "! $values {@link zif_aff_edcc_v1.data:co_expression} + "! $default {@link zif_aff_edcc_v1.data:co_expression.beginof} + ty_expression_indicator TYPE c LENGTH 3, + "!

Selection Filters on Check

+ "! Selection filters on check + BEGIN OF ty_check_filter, + "!

Sequence Number

+ "! Sequence number + sequence_number TYPE ty_sequence_number, + "!

Filter Operation

+ "! Operand to build the where condition + filter_operation TYPE ty_filter_operation, + "!

Filter Field

+ "! Field on which where condition would be applied + filter_field TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Comparison Operator

+ "! Comparison operator + comparison_operator TYPE ty_comparison_operator, + "!

Filter Field Value

+ "! Value used to build the where condition + filter_value TYPE ty_filter_value, + "!

Expression Indicator

+ "! Expression indicator + expression_indicator TYPE ty_expression_indicator, + END OF ty_check_filter, + "!

Selection Filters on Check

+ "! Selection filters on check + ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number. + + CONSTANTS: + "!

Filter Operation

+ "! Operand to build the where condition + BEGIN OF co_filteroperation, + "!

And

+ "! And + and TYPE ty_filter_operation VALUE 'AND', + "!

Or

+ "! Or + or TYPE ty_filter_operation VALUE 'OR', + END OF co_filteroperation, + + "!

Expression Indicator

+ "! Expression indicator + BEGIN OF co_expression, + "!

Begin of Expression

+ "! Begin of expression + beginof TYPE ty_expression_indicator VALUE '/', + "!

End of Expression

+ "! End of Eexpression + endof TYPE ty_expression_indicator VALUE '\', + END OF co_expression, + + "!

Comparison Operator

+ "! Comparison operator + BEGIN OF co_compareoperation, + "!

Equal

+ "! Equal + equal TYPE ty_comparison_operator VALUE '=', + "!

Not Equal

+ "! Not Equal + not_equal TYPE ty_comparison_operator VALUE '<>', + END OF co_compareoperation. + + TYPES: + "!

Position Number

+ "! Position number + ty_check_position_number TYPE c LENGTH 3, + "!

Check Execution Sequence

+ "! Check execution sequence + ty_execution_sequence TYPE c LENGTH 3, + "!

Check Execution Control

+ "! Check execution control + "! $values {@link zif_aff_edcc_v1.data:co_execution_control} + "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} + ty_execution_control TYPE c LENGTH 2, + "!

Check Attribute

+ "! Check attribute + BEGIN OF ty_check_attribute, + "!

Check Id

+ "! Check id + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Position Number

+ "! Position number + position_number TYPE ty_check_position_number, + "!

Check Execution Sequence

+ "! Check execution sequence + execution_sequence TYPE ty_execution_sequence, + "!

Check Execution Control

+ "! Check execution control + execution_control TYPE ty_execution_control, + "!

Selection Filters on Check

+ "! Selection filters on check + check_filter TYPE ty_check_filters, + END OF ty_check_attribute, + + "!

Check Attributes

+ "! Check attributes + ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id. + + CONSTANTS: + "!

Check Execution Control

+ "! Check execution control + BEGIN OF co_execution_control, + "!

No Check

+ "! Proceed with check even when inconsistency is identified + proceed TYPE ty_execution_control VALUE '00', + "!

Proceed If No Inconsistency Identified From Previous Check

+ "! Proceed If No Inconsistency Identified From Previous Check + no_proceed TYPE ty_execution_control VALUE '01', + END OF co_execution_control. + + TYPES: + "!

Representation Type

+ "! Assigned representation type + BEGIN OF ty_representation_type, + "!

Assigned Representation Type

+ "! Assigned representation type + representation_type TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Description

+ "! Description + description TYPE zif_aff_types_v1=>ty_description_60, + END OF ty_representation_type, + "!

Representation Types

+ "! Assigned representation types + ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY + representation_type. + + TYPES: + "!

Comparison Type

+ "! Comparison type + BEGIN OF ty_comparison_type, + "!

Comparison Type

+ "! Comparison type + "! $required + comparison_type TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Comparison Type Description

+ "! Description of the comparison type + "! $required + description TYPE ty_long_description, + "!

Position Number

+ "! position number + "! $required + position_number TYPE ty_position_number, + "!

Implementing Class

+ "! Implementing Class + "! $required + class_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Data Source

+ "! Data Source + "! $required + data_source TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Existence Check

+ "! Assigned existence check + "! $required + existence_check TYPE ty_existence_check, + "!

Status Checks

+ "! Assigned status checks + status_check TYPE ty_status_checks, + "!

Content Checks

+ "! Assigned content checks + content_check TYPE ty_content_checks, + "!

Check Attributes

+ "! Check attributes + "! $required + check_attributes TYPE ty_check_attributes, + "!

Representation Types

+ "! Assigned representation types + "! $required + representation_types TYPE ty_representation_types, + END OF ty_comparison_type, + "!

Comparison Types

+ "! Define comparison types + ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. + + TYPES: + "!

Consistency Scenario

+ "! Consistency scenario + BEGIN OF ty_main, + "! $required + format_version TYPE zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60_cloud, + "!

Country

+ "! Country + country TYPE ty_country, + "!

Tax Authority Message Types

+ "! Tax authority message types + taxauth_messages TYPE tt_messages, + "!

Additional Tax Authority Tables

+ "! Additional tax authority tables + taxauth_tables TYPE tt_taxauth_table, + "!

Comparison Types

+ "! Define comparison types + comparison_types TYPE ty_comparison_types, + + + END OF ty_main . + + +ENDINTERFACE. diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.json b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json new file mode 100644 index 000000000..59f7f02e7 --- /dev/null +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "AFF type for EDCK", + "originalLanguage": "en" + } +} From 5da854bc814bb363fe2e744a68b7899707c7aa07 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Tue, 17 Sep 2024 08:09:34 +0530 Subject: [PATCH 02/21] adding examples --- .../examples/z_aff_example_edcc.edcc.json | 140 ++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 file-formats/edcc/examples/z_aff_example_edcc.edcc.json diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json new file mode 100644 index 000000000..4026517ec --- /dev/null +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -0,0 +1,140 @@ +{\rtf1\ansi\ansicpg1252\cocoartf2761 +\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\froman\fcharset0 Times-Roman;} +{\colortbl;\red255\green255\blue255;\red0\green0\blue0;} +{\*\expandedcolortbl;;\cssrgb\c0\c0\c0;} +\paperw11900\paperh16840\margl1440\margr1440\vieww11520\viewh8400\viewkind0 +\deftab720 +\pard\pardeftab720\sa240\partightenfactor0 + +\f0\fs24 \cf0 \expnd0\expndtw0\kerning0 +\{\ + "formatVersion": "1",\ + "header": \{\ + "description": "Example Scenario",\ + "originalLanguage": "en",\ + "abapLanguageVersion": "cloudDevelopment"\ + \},\ + "country": "ES",\ + "taxauthMessages": [\ + \{\ + "messageType": "TaxAuthorityInvPull",\ + "messageTypeDescription": "Pull Data from Tax Authority",\ + "taxauthDocumenttype": "ES_IN_V_DOC1",\ + "originalLanguage": "en"\ + \}\ + ],\ + "taxauthTables": [\ + \{\ + "tableName": "ES_TAXAUTH_TABLE"\ + \}\ + ],\ + "comparisonTypes": [\ + \{\ + "comparisonType": "TaxAuthVeDoc",\ + "description": "Compare Tax Authority Invoice with eDocument",\ + "positionNumber": "1",\ + "className": "CL_EDC_EXAMPLE_CLASS",\ + "dataSource": "I_EDC_EXAMPLE",\ + "existenceCheck": \{\ + "checkId": "Existence",\ + "description": "Example existence check",\ + "fieldName": "EDCEXIST",\ + "fieldValue": "X",\ + "resultProcess": "ZMISSING1"\ + \},\ + "statusCheck": [\ + \{\ + "checkId": "Example 1",\ + "description": "Example Status check",\ + "sequenceNumber": "1",\ + "sourceFieldname1": "InvoiceReportingStatus",\ + "sourceFieldvalue1": "ACCEPT",\ + "sourceFieldname2": "ACRStatus",\ + "sourceFieldvalue2": "REJECT",\ + "resultProcess": "ZPROCESS1"\ + \},\ + \{\ + "checkId": "Example 2",\ + "description": "Example Status check",\ + "sequenceNumber": "2",\ + "sourceFieldname1": "InvoiceSubmissionStatus",\ + "sourceFieldvalue1": "ACCEPT",\ + "sourceFieldname2": "eDocumentStatus",\ + "sourceFieldvalue2": "REJECT",\ + "resultProcess": "ZPROCESS2"\ + \}\ + ],\ + "contentCheck": [\ + \{\ + "checkId": "ExampleContentCheck1",\ + "description": "Content check of Invoices",\ + "checkNumber": "1",\ + "contentComparisonFieldgroup": [\ + \{\ + "fieldGroup": "InvoiceHeaderFields",\ + "description": "Example",\ + "fieldGroupLevel": "header",\ + "checkFormula": "field",\ + "resultProcess": "ZCONTENT1",\ + "comparisonField": [\ + \{\ + "representationType": "EDOCUMENT",\ + "fieldName": "TotalAmount",\ + "comparisonSequence": "1"\ + \},\ + \{\ + "representationType": "TAXAUTHDOC",\ + "fieldName": "TotalAmount",\ + "comparisonSequence": "2"\ + \}\ + ]\ + \}\ + ]\ + \}\ + ],\ + "checkAttributes": [\ + \{\ + "checkId": "Existence",\ + "positionNumber": "1",\ + "executionSequence": "1",\ + "executionControl": "proceed",\ + "checkFilter": [\ + \{\ + "filterOperation": "and",\ + "comparisonOperator": "equal",\ + "expressionIndicator": "beginof"\ + \}\ + ]\ + \},\ + \{\ + "checkId": "Example 1",\ + "positionNumber": "2",\ + "executionSequence": "2",\ + "executionControl": "proceed"\ + \},\ + \{\ + "checkId": "Example 2",\ + "positionNumber": "3",\ + "executionSequence": "3",\ + "executionControl": "proceed"\ + \},\ + \{\ + "checkId": "ExampleContentCheck1",\ + "positionNumber": "4",\ + "executionSequence": "4",\ + "executionControl": "noProceed"\ + \}\ + ],\ + "representationTypes": [\ + \{\ + "representationType": "EDOCUMENT",\ + "description": "example eDocument"\ + \},\ + \{\ + "representationType": "TAXAUTHDOC",\ + "description": "Tax Authority Document"\ + \}\ + ]\ + \}\ + ]\ +\}} \ No newline at end of file From 81ac874f5f586794a6a54e6b27bd39a37ad66677 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 26 Sep 2024 13:06:28 +0530 Subject: [PATCH 03/21] commit abap lint fixes --- file-formats/edcc/edcc-v1.json | 183 ++++++++++++ .../examples/z_aff_example_edcc.edcc.json | 271 +++++++++--------- .../edcc/type/zif_aff_edcc_v1.intf.abap | 160 ++++++++++- 3 files changed, 465 insertions(+), 149 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index 290807f6d..1d4ad55d5 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -580,6 +580,189 @@ "representationTypes" ] } + }, + "events": { + "title": "Events Assignment", + "description": "Assign events to consistency scenario", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Assign Event", + "description": "Assign event to consistency scenario", + "type": "object", + "properties": { + "event": { + "title": "Event Name", + "description": "Event name", + "type": "string", + "maxLength": 25 + }, + "description": { + "title": "Description", + "description": "Description", + "type": "string", + "maxLength": 100 + }, + "assignedComparison": { + "title": "Assign Checks and Comparison Type", + "description": "Assign Checks and Comparison Type", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Assigned Comparison", + "description": "Assigned comparison", + "type": "object", + "properties": { + "comparisonType": { + "title": "Comparison Type", + "description": "Comparison type", + "type": "string", + "maxLength": 30 + }, + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false + } + }, + "checkRelevance": { + "title": "Check Relevance", + "description": "Define relevance of checks", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Check Relevance", + "description": "Define relevance of check", + "type": "object", + "properties": { + "comparisonType": { + "title": "Comparison Type", + "description": "Comparison type", + "type": "string", + "maxLength": 30 + }, + "checkId": { + "title": "Check Id", + "description": "Check id", + "type": "string", + "maxLength": 30 + }, + "relevance": { + "title": "Relevance", + "description": "Relevance", + "type": "string", + "enum": [ + "relevant", + "notRelevant", + "unchanged" + ], + "enumTitles": [ + "Relevant", + "Not Relevant", + "Unchanged" + ], + "enumDescriptions": [ + "Relevant", + "Not relevant", + "Unchanged" + ], + "default": "unchanged" + } + }, + "additionalProperties": false, + "required": [ + "comparisonType", + "checkId" + ] + } + } + }, + "additionalProperties": false + } + }, + "relationshipAttribute": { + "title": "Representation Types", + "description": "Assign representation types associated with comsistency scenario", + "type": "object", + "properties": { + "representationType": { + "title": "Representation Type", + "description": "Representation type", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false + }, + "edocumentType": { + "title": "eDocument Type Assignment", + "description": "Assign eDocument types associated with comsistency scenario", + "type": "array", + "uniqueItems": true, + "items": { + "title": "eDocument Type Assignment", + "description": "Assign eDocument types associated with comsistency scenario", + "type": "object", + "properties": { + "edocType": { + "title": "eDocument Type", + "description": "eDocument Type", + "type": "string", + "maxLength": 10 + } + }, + "additionalProperties": false + } + }, + "inconsistencyCategories": { + "title": "Inconsistency Categories", + "description": "Inconsistency categories", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Inconsistency Category", + "description": "Inconsistency category", + "type": "object", + "properties": { + "resultUiGroup": { + "title": "Inconsistency Category", + "description": "Inconsistency category", + "type": "string", + "maxLength": 20 + }, + "countryXtension": { + "title": "Country View Extension", + "description": "Country view extension", + "type": "string", + "maxLength": 30 + }, + "resultProcess": { + "title": "Result Processes", + "description": "Assign result process to the UI group", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Result Process", + "description": "Assign result process to the UI group", + "type": "object", + "properties": { + "resultProcess": { + "title": "Result Process", + "description": "Result process", + "type": "string", + "maxLength": 10 + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false + } } }, "additionalProperties": false, diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json index 4026517ec..2b6455ef6 100644 --- a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -1,140 +1,131 @@ -{\rtf1\ansi\ansicpg1252\cocoartf2761 -\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\froman\fcharset0 Times-Roman;} -{\colortbl;\red255\green255\blue255;\red0\green0\blue0;} -{\*\expandedcolortbl;;\cssrgb\c0\c0\c0;} -\paperw11900\paperh16840\margl1440\margr1440\vieww11520\viewh8400\viewkind0 -\deftab720 -\pard\pardeftab720\sa240\partightenfactor0 - -\f0\fs24 \cf0 \expnd0\expndtw0\kerning0 -\{\ - "formatVersion": "1",\ - "header": \{\ - "description": "Example Scenario",\ - "originalLanguage": "en",\ - "abapLanguageVersion": "cloudDevelopment"\ - \},\ - "country": "ES",\ - "taxauthMessages": [\ - \{\ - "messageType": "TaxAuthorityInvPull",\ - "messageTypeDescription": "Pull Data from Tax Authority",\ - "taxauthDocumenttype": "ES_IN_V_DOC1",\ - "originalLanguage": "en"\ - \}\ - ],\ - "taxauthTables": [\ - \{\ - "tableName": "ES_TAXAUTH_TABLE"\ - \}\ - ],\ - "comparisonTypes": [\ - \{\ - "comparisonType": "TaxAuthVeDoc",\ - "description": "Compare Tax Authority Invoice with eDocument",\ - "positionNumber": "1",\ - "className": "CL_EDC_EXAMPLE_CLASS",\ - "dataSource": "I_EDC_EXAMPLE",\ - "existenceCheck": \{\ - "checkId": "Existence",\ - "description": "Example existence check",\ - "fieldName": "EDCEXIST",\ - "fieldValue": "X",\ - "resultProcess": "ZMISSING1"\ - \},\ - "statusCheck": [\ - \{\ - "checkId": "Example 1",\ - "description": "Example Status check",\ - "sequenceNumber": "1",\ - "sourceFieldname1": "InvoiceReportingStatus",\ - "sourceFieldvalue1": "ACCEPT",\ - "sourceFieldname2": "ACRStatus",\ - "sourceFieldvalue2": "REJECT",\ - "resultProcess": "ZPROCESS1"\ - \},\ - \{\ - "checkId": "Example 2",\ - "description": "Example Status check",\ - "sequenceNumber": "2",\ - "sourceFieldname1": "InvoiceSubmissionStatus",\ - "sourceFieldvalue1": "ACCEPT",\ - "sourceFieldname2": "eDocumentStatus",\ - "sourceFieldvalue2": "REJECT",\ - "resultProcess": "ZPROCESS2"\ - \}\ - ],\ - "contentCheck": [\ - \{\ - "checkId": "ExampleContentCheck1",\ - "description": "Content check of Invoices",\ - "checkNumber": "1",\ - "contentComparisonFieldgroup": [\ - \{\ - "fieldGroup": "InvoiceHeaderFields",\ - "description": "Example",\ - "fieldGroupLevel": "header",\ - "checkFormula": "field",\ - "resultProcess": "ZCONTENT1",\ - "comparisonField": [\ - \{\ - "representationType": "EDOCUMENT",\ - "fieldName": "TotalAmount",\ - "comparisonSequence": "1"\ - \},\ - \{\ - "representationType": "TAXAUTHDOC",\ - "fieldName": "TotalAmount",\ - "comparisonSequence": "2"\ - \}\ - ]\ - \}\ - ]\ - \}\ - ],\ - "checkAttributes": [\ - \{\ - "checkId": "Existence",\ - "positionNumber": "1",\ - "executionSequence": "1",\ - "executionControl": "proceed",\ - "checkFilter": [\ - \{\ - "filterOperation": "and",\ - "comparisonOperator": "equal",\ - "expressionIndicator": "beginof"\ - \}\ - ]\ - \},\ - \{\ - "checkId": "Example 1",\ - "positionNumber": "2",\ - "executionSequence": "2",\ - "executionControl": "proceed"\ - \},\ - \{\ - "checkId": "Example 2",\ - "positionNumber": "3",\ - "executionSequence": "3",\ - "executionControl": "proceed"\ - \},\ - \{\ - "checkId": "ExampleContentCheck1",\ - "positionNumber": "4",\ - "executionSequence": "4",\ - "executionControl": "noProceed"\ - \}\ - ],\ - "representationTypes": [\ - \{\ - "representationType": "EDOCUMENT",\ - "description": "example eDocument"\ - \},\ - \{\ - "representationType": "TAXAUTHDOC",\ - "description": "Tax Authority Document"\ - \}\ - ]\ - \}\ - ]\ -\}} \ No newline at end of file +{ + "formatVersion": "1", + "header": { + "description": "Example Scenario", + "originalLanguage": "en", + "abapLanguageVersion": "cloudDevelopment" + }, + "country": "ES", + "taxauthMessages": [ + { + "messageType": "TaxAuthorityInvPull", + "messageTypeDescription": "Pull Data from Tax Authority", + "taxauthDocumenttype": "ES_IN_V_DOC1", + "originalLanguage": "en" + } + ], + "taxauthTables": [ + { + "tableName": "ES_TAXAUTH_TABLE" + } + ], + "comparisonTypes": [ + { + "comparisonType": "TaxAuthVeDoc", + "description": "Compare Tax Authority Invoice with eDocument", + "positionNumber": "1", + "className": "CL_EDC_EXAMPLE_CLASS", + "dataSource": "I_EDC_EXAMPLE", + "existenceCheck": { + "checkId": "Existence", + "description": "Example existence check", + "fieldName": "EDCEXIST", + "fieldValue": "X", + "resultProcess": "ZMISSING1" + }, + "statusCheck": [ + { + "checkId": "Example 1", + "description": "Example Status check", + "sequenceNumber": "1", + "sourceFieldname1": "InvoiceReportingStatus", + "sourceFieldvalue1": "ACCEPT", + "sourceFieldname2": "ACRStatus", + "sourceFieldvalue2": "REJECT", + "resultProcess": "ZPROCESS1" + }, + { + "checkId": "Example 2", + "description": "Example Status check", + "sequenceNumber": "2", + "sourceFieldname1": "InvoiceSubmissionStatus", + "sourceFieldvalue1": "ACCEPT", + "sourceFieldname2": "eDocumentStatus", + "sourceFieldvalue2": "REJECT", + "resultProcess": "ZPROCESS2" + } + ], + "contentCheck": [ + { + "checkId": "ExampleContentCheck1", + "description": "Content check of Invoices", + "checkNumber": "1", + "contentComparisonFieldgroup": [ + { + "fieldGroup": "InvoiceHeaderFields", + "description": "Example", + "fieldGroupLevel": "header", + "checkFormula": "field", + "resultProcess": "ZCONTENT1", + "comparisonField": [ + { + "representationType": "EDOCUMENT", + "fieldName": "TotalAmount", + "comparisonSequence": "1" + }, + { + "representationType": "TAXAUTHDOC", + "fieldName": "TotalAmount", + "comparisonSequence": "2" + } + ] + } + ] + } + ], + "checkAttributes": [ + { + "checkId": "Existence", + "positionNumber": "1", + "executionSequence": "1", + "executionControl": "proceed", + "checkFilter": [ + { + "filterOperation": "and", + "comparisonOperator": "equal", + "expressionIndicator": "beginof" + } + ] + }, + { + "checkId": "Example 1", + "positionNumber": "2", + "executionSequence": "2", + "executionControl": "proceed" + }, + { + "checkId": "Example 2", + "positionNumber": "3", + "executionSequence": "3", + "executionControl": "proceed" + }, + { + "checkId": "ExampleContentCheck1", + "positionNumber": "4", + "executionSequence": "4", + "executionControl": "noProceed" + } + ], + "representationTypes": [ + { + "representationType": "EDOCUMENT", + "description": "example eDocument" + }, + { + "representationType": "TAXAUTHDOC", + "description": "Tax Authority Document" + } + ] + } + ] +} \ No newline at end of file diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index c10b70a5b..f71bc3925 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -9,7 +9,7 @@ INTERFACE zif_aff_edcc_v1 TYPES: "!

Tax Authority Message Type

"! Tax Authority Message type - BEGIN OF ty_messages, + BEGIN OF ty_message, "!

Message Type

"! Message type message_type TYPE c LENGTH 20, @@ -20,10 +20,10 @@ INTERFACE zif_aff_edcc_v1 "! Tax authority document type taxauth_documenttype TYPE c LENGTH 20, original_language TYPE zif_aff_types_v1=>ty_original_language, - END OF ty_messages, + END OF ty_message, "!

Tax Authority Message Types

"! Tax Authority Message types - tt_messages TYPE SORTED TABLE OF ty_messages WITH UNIQUE KEY message_type. + ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type. TYPES: "!

Additional Tax Authority Table

@@ -35,7 +35,7 @@ INTERFACE zif_aff_edcc_v1 END OF ty_taxauth_table, "!

Additional Tax Authority Tables

"! Additional tax authority tables - tt_taxauth_table TYPE SORTED TABLE OF ty_taxauth_table WITH UNIQUE KEY table_name. + ty_taxauth_tables TYPE SORTED TABLE OF ty_taxauth_table WITH UNIQUE KEY table_name. TYPES: "!

Position Number

@@ -413,6 +413,138 @@ INTERFACE zif_aff_edcc_v1 "! Define comparison types ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. + TYPES: + "!

Relevance

+ "! Relevance + "! $values {@link zif_aff_edcc_v1.data:co_relevance} + "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} + ty_relevance TYPE c LENGTH 1, + "!

Event Name

+ "! Event name + ty_event_name TYPE c LENGTH 25, + "!

Assigned Comparison

+ "! Assigned comparison + BEGIN OF ty_assigned_comparison, + "!

Comparison Type

+ "! Comparison type + comparison_type TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Check Id

+ "! Check id + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + END OF ty_assigned_comparison, + "!

Assign Checks and Comparison Type

+ "! Assign Checks and Comparison Type + ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY + comparison_type check_id, + "!

Check Relevance

+ "! Define relevance of check + BEGIN OF ty_check_relevance, + "!

Comparison Type

+ "! Comparison type + "! $required + comparison_type TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Check Id

+ "! Check id + "! $required + check_id TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Relevance

+ "! Relevance + relevance TYPE ty_relevance, + END OF ty_check_relevance, + "!

Check Relevance

+ "! Define relevance of checks + ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY + comparison_type check_id. + + CONSTANTS: + "!

Relevance

+ "! Relevance + BEGIN OF co_relevance, + "!

Relevant

+ "! Relevant + relevant TYPE ty_relevance VALUE 'R', + "!

Not Relevant

+ "! Not relevant + not_relevant TYPE ty_relevance VALUE 'N', + "!

Unchanged

+ "! Unchanged + unchanged TYPE ty_relevance VALUE 'U', + END OF co_relevance. + + TYPES: + "!

Assign Event

+ "! Assign event to consistency scenario + BEGIN OF ty_event, + "!

Event Name

+ "! Event name + event TYPE ty_event_name, + "!

Description

+ "! Description + description TYPE zif_aff_types_v1=>ty_description_100, + "!

Assign Checks and Comparison Type

+ "! Assign Checks and Comparison Type + assigned_comparison TYPE ty_assigned_comparisons, + "!

Check Relevance

+ "! Define relevance of checks + check_relevance TYPE ty_check_relevances, + END OF ty_event, + "!

Assign Events

+ "! Assign events to consistency scenario + ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event. + + TYPES: + "!

Representation Type

+ "! Assign representation type associated with comsistency scenario + BEGIN OF ty_relationship_attribute, + "!

Representation Type

+ "! Representation type + representation_type TYPE zif_aff_types_v1=>ty_object_name_30, + END OF ty_relationship_attribute, + "!

Representation Types

+ "! Assign representation types associated with comsistency scenario + ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY + representation_type, + "!

eDocument Type Assignment

+ "! Assign eDocument types associated with comsistency scenario + BEGIN OF ty_edoc_type, + "!

eDocument Type

+ "! eDocument Type + edoc_type TYPE c LENGTH 10, + END OF ty_edoc_type, + "!

eDocument Type Assignment

+ "! Assign eDocument types associated with comsistency scenario + ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. + + TYPES: + "!

Inconsistency Category

+ "! Inconsistency category + ty_resultgroup TYPE c LENGTH 20, + + "!

Result Process

+ "! Assign result process to the UI group + BEGIN OF ty_results_process, + result_process TYPE ty_result_process, + END OF ty_results_process, + "!

Result Processes

+ "! Assign result process to the UI group + ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process, + "!

Inconsistency Category

+ "! Inconsistency category + BEGIN OF ty_inconsistency_category, + "!

Inconsistency Category

+ "! Inconsistency category + result_ui_group TYPE ty_resultgroup, + "!

Country View Extension

+ "! Country view extension + country_xtension TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Result Processes

+ "! Assign result process to the UI group + result_process TYPE ty_result_processes, + END OF ty_inconsistency_category, + "!

Inconsistency Categories

+ "! Inconsistency categories + ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY + result_ui_group. TYPES: "!

Consistency Scenario

"! Consistency scenario @@ -428,16 +560,26 @@ INTERFACE zif_aff_edcc_v1 country TYPE ty_country, "!

Tax Authority Message Types

"! Tax authority message types - taxauth_messages TYPE tt_messages, + taxauth_messages TYPE ty_messages, "!

Additional Tax Authority Tables

"! Additional tax authority tables - taxauth_tables TYPE tt_taxauth_table, + taxauth_tables TYPE ty_taxauth_tables, "!

Comparison Types

"! Define comparison types comparison_types TYPE ty_comparison_types, - - - END OF ty_main . + "!

Events Assignment

+ "! Assign events to consistency scenario + events TYPE ty_events, + "!

Representation Types

+ "! Assign representation types associated with comsistency scenario + relationship_attribute TYPE ty_relationship_attribute, + "!

eDocument Type Assignment

+ "! Assign eDocument types associated with comsistency scenario + edocument_type TYPE ty_edoc_types, + "!

Inconsistency Categories

+ "! Inconsistency categories + inconsistency_categories TYPE ty_inconsistency_categories, + END OF ty_main. ENDINTERFACE. From cc32868ea9036335d67eed651ea462bdb19d127a Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 26 Sep 2024 13:10:00 +0530 Subject: [PATCH 04/21] abap lint fixes --- file-formats/edcc/edcc-v1.json | 26 ++++++++++++------- .../edcc/type/zif_aff_edcc_v1.intf.abap | 6 ++--- 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index 1d4ad55d5..c38f46156 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -687,16 +687,22 @@ "relationshipAttribute": { "title": "Representation Types", "description": "Assign representation types associated with comsistency scenario", - "type": "object", - "properties": { - "representationType": { - "title": "Representation Type", - "description": "Representation type", - "type": "string", - "maxLength": 30 - } - }, - "additionalProperties": false + "type": "array", + "uniqueItems": true, + "items": { + "title": "Representation Type", + "description": "Assign representation type associated with comsistency scenario", + "type": "object", + "properties": { + "representationType": { + "title": "Representation Type", + "description": "Representation type", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false + } }, "edocumentType": { "title": "eDocument Type Assignment", diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index f71bc3925..2455732c0 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,10 +1,10 @@ INTERFACE zif_aff_edcc_v1 - PUBLIC . + PUBLIC. "!

Country

"! Country TYPES ty_country TYPE c LENGTH 3. - TYPES ty_short_description TYPE c LENGTH 30. + TYPES ty_short_description TYPE c LENGTH 30. TYPES: "!

Tax Authority Message Type

@@ -572,7 +572,7 @@ INTERFACE zif_aff_edcc_v1 events TYPE ty_events, "!

Representation Types

"! Assign representation types associated with comsistency scenario - relationship_attribute TYPE ty_relationship_attribute, + relationship_attribute TYPE ty_relationship_attributes, "!

eDocument Type Assignment

"! Assign eDocument types associated with comsistency scenario edocument_type TYPE ty_edoc_types, From bf14d4c52a78dd78cb9b7c63eb8627a24775396d Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 26 Sep 2024 13:11:19 +0530 Subject: [PATCH 05/21] EOL fix --- file-formats/edcc/examples/z_aff_example_edcc.edcc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json index 2b6455ef6..58dac9f8b 100644 --- a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -128,4 +128,4 @@ ] } ] -} \ No newline at end of file +} From 96f8345ba42a84a72f46ec934e10c47a26a48aa9 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 26 Sep 2024 13:13:42 +0530 Subject: [PATCH 06/21] Read me fix --- file-formats/edcc/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/file-formats/edcc/README.md b/file-formats/edcc/README.md index 045148efe..9f744599f 100644 --- a/file-formats/edcc/README.md +++ b/file-formats/edcc/README.md @@ -2,4 +2,5 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.edcc.json` | 1 | [`zif_aff_edcc_v1.intf.abap`](./type/zif_aff_edcc_v1.intf.abap) | [`edcc-v1.json`](./edcc-v1.json) +`.edcc.json` | 1 | [`zif_aff_edcc_v1.intf.abap`](./type/zif_aff_edcc_v1.intf.abap) | [`edcc-v1.json`](./edcc-v1.json) | [`z_aff_example_edcc.edcc.json`](./examples/z_aff_example_edcc.edcc.json) + From 525d0d473e8993f3db0ab30ca404048bcb3b2b07 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 3 Oct 2024 11:23:39 +0530 Subject: [PATCH 07/21] Fixes for Guilherme's comment --- file-formats/edcc/edcc-v1.json | 36 +- .../edcc/type/zif_aff_edcc_v1.intf.abap | 437 +++++++++--------- .../edcc/type/zif_aff_edcc_v1.intf.json | 2 +- 3 files changed, 243 insertions(+), 232 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index c38f46156..01fafdd36 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -60,7 +60,7 @@ "type": "string", "maxLength": 3 }, - "taxauthMessages": { + "taxAuthorityMessages": { "title": "Tax Authority Message Types", "description": "Tax authority message types", "type": "array", @@ -82,23 +82,17 @@ "type": "string", "maxLength": 30 }, - "taxauthDocumenttype": { + "taxAuthorityDocumentType": { "title": "Tax Authority Document Type", "description": "Tax authority document type", "type": "string", "maxLength": 20 - }, - "originalLanguage": { - "title": "Original Language", - "description": "Original language of the ABAP object", - "type": "string", - "minLength": 2 } }, "additionalProperties": false } }, - "taxauthTables": { + "taxAuthorityTables": { "title": "Additional Tax Authority Tables", "description": "Additional tax authority tables", "type": "array", @@ -142,7 +136,7 @@ }, "positionNumber": { "title": "Position Number", - "description": "position number", + "description": "Position number", "type": "string", "maxLength": 2 }, @@ -203,7 +197,7 @@ "uniqueItems": true, "items": { "title": "Status Check", - "description": "status check", + "description": "Status check", "type": "object", "properties": { "checkId": { @@ -298,7 +292,7 @@ "type": "string", "maxLength": 60 }, - "contentComparisonFieldgroup": { + "contentComparisonFieldGroup": { "title": "Comparison Field Groups", "description": "Comparison field groups", "type": "array", @@ -340,7 +334,7 @@ }, "checkFormula": { "title": "Check Formula", - "description": "Formula applied to do content check for the field group", + "description": "Formula applied to perform the content check on field group", "type": "string", "enum": [ "field", @@ -366,13 +360,13 @@ "maxLength": 10 }, "comparisonField": { - "title": "Fields Configuration", - "description": "Configuration of fields those would be compared", + "title": "Comparison Field Name", + "description": "Field Names those values will be compared", "type": "array", "uniqueItems": true, "items": { - "title": "Fields Configuration", - "description": "Configuration of field those would be compared", + "title": "Comparison Field Name", + "description": "Field Names those values will be compared", "type": "object", "properties": { "representationType": { @@ -686,12 +680,12 @@ }, "relationshipAttribute": { "title": "Representation Types", - "description": "Assign representation types associated with comsistency scenario", + "description": "Assign representation types associated with consistency scenario", "type": "array", "uniqueItems": true, "items": { "title": "Representation Type", - "description": "Assign representation type associated with comsistency scenario", + "description": "Assign representation type associated with consistency scenario", "type": "object", "properties": { "representationType": { @@ -704,9 +698,9 @@ "additionalProperties": false } }, - "edocumentType": { + "edocumentTypes": { "title": "eDocument Type Assignment", - "description": "Assign eDocument types associated with comsistency scenario", + "description": "Assign eDocument types associated with consistency scenario", "type": "array", "uniqueItems": true, "items": { diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 2455732c0..2259b3617 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,60 +1,65 @@ INTERFACE zif_aff_edcc_v1 - PUBLIC. - "!

Country

- "! Country - TYPES ty_country TYPE c LENGTH 3. + PUBLIC . - TYPES ty_short_description TYPE c LENGTH 30. + TYPES: + "!

Description

+ "! Description + ty_short_description TYPE c LENGTH 30 . TYPES: "!

Tax Authority Message Type

"! Tax Authority Message type BEGIN OF ty_message, "!

Message Type

"! Message type - message_type TYPE c LENGTH 20, + message_type TYPE c LENGTH 20, "!

Message Type Description

"! Message type description - message_type_description TYPE ty_short_description, + message_type_description TYPE ty_short_description, "!

Tax Authority Document Type

"! Tax authority document type - taxauth_documenttype TYPE c LENGTH 20, - original_language TYPE zif_aff_types_v1=>ty_original_language, - END OF ty_message, + tax_authority_document_type TYPE c LENGTH 20, + END OF ty_message . + TYPES: "!

Tax Authority Message Types

- "! Tax Authority Message types - ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type. - + "! Tax authority message types + ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type . TYPES: "!

Additional Tax Authority Table

"! Additional tax authority table - BEGIN OF ty_taxauth_table, + BEGIN OF ty_tax_authority_table, "!

Table Name

"! Table name table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_taxauth_table, + END OF ty_tax_authority_table . + TYPES: "!

Additional Tax Authority Tables

"! Additional tax authority tables - ty_taxauth_tables TYPE SORTED TABLE OF ty_taxauth_table WITH UNIQUE KEY table_name. - + ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name . TYPES: "!

Position Number

- "! position number - ty_position_number TYPE c LENGTH 2, + "! Position number + ty_position_number TYPE c LENGTH 2 . + TYPES: "!

Result Process

"! Result process - ty_result_process TYPE c LENGTH 10, + ty_result_process TYPE c LENGTH 10 . + TYPES: "!

Field Value

"! Field value - ty_field_value TYPE c LENGTH 40, + ty_field_value TYPE c LENGTH 40 . + TYPES: "!

Sequence Number

"! Sequence number - ty_sequence_number TYPE c LENGTH 3, + ty_sequence_number TYPE c LENGTH 3 . + TYPES: "!

Check Number

"! Check number - ty_check_number TYPE c LENGTH 5, - ty_long_description TYPE c LENGTH 120. - + ty_check_number TYPE c LENGTH 5 . + TYPES: + "!

Description

+ "! Description + ty_long_description TYPE c LENGTH 120 . TYPES: "!

Existence Check

"! Assigned existence check @@ -74,11 +79,10 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_existence_check. - + END OF ty_existence_check . TYPES: "!

Status Check

- "! status check + "! Status check BEGIN OF ty_status_check, "!

Check Id

"! Check id @@ -104,54 +108,32 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_status_check, + END OF ty_status_check . + TYPES: "!

Status Checks

"! Assigned status checks - ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number. - + ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number . TYPES: "!

Mismatch Field Group

"! Comparison field group for mismatched fields - ty_fieldgroup TYPE c LENGTH 20, + ty_field_group TYPE c LENGTH 20 . + TYPES: "!

Field Group Level

"! Level of comparison field group - "! $values {@link zif_aff_edcc_v1.data:co_fieldgrouplevel} - "! $default {@link zif_aff_edcc_v1.data:co_fieldgrouplevel.header} - ty_fieldgroup_level TYPE c LENGTH 1, - ty_comparison_sequence TYPE c LENGTH 5, - "!

Check Formula

- "! Formula applied to do content check for the field group - "! $values {@link zif_aff_edcc_v1.data:co_checkformula} - "! $default {@link zif_aff_edcc_v1.data:co_checkformula.field} - ty_checkformula TYPE c LENGTH 1. - CONSTANTS: + "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} + "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} + ty_field_group_level TYPE c LENGTH 1 . + TYPES: + ty_comparison_sequence TYPE c LENGTH 5 . + TYPES: "!

Check Formula

- "! Formula applied to do content check for the field group - BEGIN OF co_checkformula, - "!

Field to Field Comparison

- "! Field to field comparison - field TYPE ty_checkformula VALUE '1', - "!

Amount Comparison with Absolute Tolerance

- "! Amount comparison with absolute tolerance - field_with_abstolerance TYPE ty_checkformula VALUE '2', - "!

Amount Comparison without Absolute Tolerance

- "! Amount comparison without absolute tolerance - field_with_nonabstolerance TYPE ty_checkformula VALUE '3', - END OF co_checkformula, - "!

Field Group Level

- "! Level of comparison field group - BEGIN OF co_fieldgrouplevel, - "!

Header

- "! Header - header TYPE ty_fieldgroup_level VALUE 'H', - "!

Item

- "! Item - item TYPE ty_fieldgroup_level VALUE 'I', - END OF co_fieldgrouplevel. - + "! Formula applied to perform the content check on field group + "! $values {@link zif_aff_edcc_v1.data:co_check_formula} + "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} + ty_check_formula TYPE c LENGTH 1 . TYPES: - "!

Fields Configuration

- "! Configuration of field those would be compared + "!

Comparison Field Name

+ "! Field Names those values will be compared BEGIN OF ty_comparison_field, "!

Representation Type

"! Representation type @@ -162,86 +144,89 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Sequence

"! Comparison sequence comparison_sequence TYPE ty_comparison_sequence, - END OF ty_comparison_field, - "!

Fields Configuration

- "! Configuration of fields those would be compared - ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. - + END OF ty_comparison_field . + TYPES: + "!

Comparison Field Name

+ "! Field Names those values will be compared + ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type . TYPES: - "!

Comparison Field Group

"! Comparison field group - BEGIN OF ty_comparison_fieldgroup, + BEGIN OF ty_comparison_field_group, "!

Mismatch Field Group

"! Comparison field group for mismatched fields - field_group TYPE ty_fieldgroup, + field_group TYPE ty_field_group, "!

Description

"! Mismatch field group description description TYPE ty_short_description, "!

Field Group Level

"! Level of comparison field group - field_group_level TYPE ty_fieldgroup_level, + field_group_level TYPE ty_field_group_level, "!

Check Formula

- "! Formula applied to do content check for the field group - check_formula TYPE ty_checkformula, + "! Formula applied to perform the content check on field group + check_formula TYPE ty_check_formula, "!

Result Process

"! Result process result_process TYPE ty_result_process, - "!

Fields Configuration

- "! Configuration of fields those would be compared + "!

Comparison Field Name

+ "! Field Names those values will be compared comparison_field TYPE ty_comparison_fields, - END OF ty_comparison_fieldgroup, + END OF ty_comparison_field_group . + TYPES: "!

Comparison Field Groups

"! Comparison field groups - ty_comparison_fieldgroups TYPE SORTED TABLE OF ty_comparison_fieldgroup - WITH UNIQUE KEY field_group. + ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group + WITH UNIQUE KEY field_group . TYPES: "!

Content Check

"! Content check BEGIN OF ty_content_check, "!

Check Id

"! Check id - check_id TYPE zif_aff_types_v1=>ty_object_name_30, + check_id TYPE zif_aff_types_v1=>ty_object_name_30, "!

Check Description

"! Check description - description TYPE zif_aff_types_v1=>ty_description_60, + description TYPE zif_aff_types_v1=>ty_description_60, "!

Check Number

"! Check number - check_number TYPE ty_check_number, + check_number TYPE ty_check_number, "!

Additional Data Source

"! Additional data source - data_source TYPE zif_aff_types_v1=>ty_object_name_30, + data_source TYPE zif_aff_types_v1=>ty_object_name_30, "!

Additional Description

"! Additional check description - additional_description TYPE zif_aff_types_v1=>ty_description_60, + additional_description TYPE zif_aff_types_v1=>ty_description_60, "!

Comparison Field Groups

"! Comparison field groups - content_comparison_fieldgroup TYPE ty_comparison_fieldgroups, - END OF ty_content_check, - + content_comparison_field_group TYPE ty_comparison_field_groups, + END OF ty_content_check . + TYPES: "!

Content Checks

"! Assigned content checks - ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number. - + ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number . TYPES: "!

Filter Operation

"! Operand to build the where condition - "! $values {@link zif_aff_edcc_v1.data:co_filteroperation} - "! $default {@link zif_aff_edcc_v1.data:co_filteroperation.and} - ty_filter_operation TYPE c LENGTH 3, + "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} + "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} + ty_filter_operation TYPE c LENGTH 3 . + TYPES: "!

Comparison Operator

"! Comparison operator - "! $values {@link zif_aff_edcc_v1.data:co_compareoperation} - "! $default {@link zif_aff_edcc_v1.data:co_compareoperation.equal} - ty_comparison_operator TYPE c LENGTH 3, + "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} + "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} + ty_comparison_operator TYPE c LENGTH 3 . + TYPES: "!

Filter Field Value

"! Value used to build the where condition - ty_filter_value TYPE c LENGTH 30, + ty_filter_value TYPE c LENGTH 30 . + TYPES: "!

Expression Indicator

"! Expression indicator "! $values {@link zif_aff_edcc_v1.data:co_expression} "! $default {@link zif_aff_edcc_v1.data:co_expression.beginof} - ty_expression_indicator TYPE c LENGTH 3, + ty_expression_indicator TYPE c LENGTH 3 . + TYPES: "!

Selection Filters on Check

"! Selection filters on check BEGIN OF ty_check_filter, @@ -263,57 +248,26 @@ INTERFACE zif_aff_edcc_v1 "!

Expression Indicator

"! Expression indicator expression_indicator TYPE ty_expression_indicator, - END OF ty_check_filter, + END OF ty_check_filter . + TYPES: "!

Selection Filters on Check

"! Selection filters on check - ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number. - - CONSTANTS: - "!

Filter Operation

- "! Operand to build the where condition - BEGIN OF co_filteroperation, - "!

And

- "! And - and TYPE ty_filter_operation VALUE 'AND', - "!

Or

- "! Or - or TYPE ty_filter_operation VALUE 'OR', - END OF co_filteroperation, - - "!

Expression Indicator

- "! Expression indicator - BEGIN OF co_expression, - "!

Begin of Expression

- "! Begin of expression - beginof TYPE ty_expression_indicator VALUE '/', - "!

End of Expression

- "! End of Eexpression - endof TYPE ty_expression_indicator VALUE '\', - END OF co_expression, - - "!

Comparison Operator

- "! Comparison operator - BEGIN OF co_compareoperation, - "!

Equal

- "! Equal - equal TYPE ty_comparison_operator VALUE '=', - "!

Not Equal

- "! Not Equal - not_equal TYPE ty_comparison_operator VALUE '<>', - END OF co_compareoperation. - + ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number . TYPES: "!

Position Number

"! Position number - ty_check_position_number TYPE c LENGTH 3, + ty_check_position_number TYPE c LENGTH 3 . + TYPES: "!

Check Execution Sequence

"! Check execution sequence - ty_execution_sequence TYPE c LENGTH 3, + ty_execution_sequence TYPE c LENGTH 3 . + TYPES: "!

Check Execution Control

"! Check execution control "! $values {@link zif_aff_edcc_v1.data:co_execution_control} "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} - ty_execution_control TYPE c LENGTH 2, + ty_execution_control TYPE c LENGTH 2 . + TYPES: "!

Check Attribute

"! Check attribute BEGIN OF ty_check_attribute, @@ -332,24 +286,11 @@ INTERFACE zif_aff_edcc_v1 "!

Selection Filters on Check

"! Selection filters on check check_filter TYPE ty_check_filters, - END OF ty_check_attribute, - + END OF ty_check_attribute . + TYPES: "!

Check Attributes

"! Check attributes - ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id. - - CONSTANTS: - "!

Check Execution Control

- "! Check execution control - BEGIN OF co_execution_control, - "!

No Check

- "! Proceed with check even when inconsistency is identified - proceed TYPE ty_execution_control VALUE '00', - "!

Proceed If No Inconsistency Identified From Previous Check

- "! Proceed If No Inconsistency Identified From Previous Check - no_proceed TYPE ty_execution_control VALUE '01', - END OF co_execution_control. - + ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id . TYPES: "!

Representation Type

"! Assigned representation type @@ -360,12 +301,12 @@ INTERFACE zif_aff_edcc_v1 "!

Description

"! Description description TYPE zif_aff_types_v1=>ty_description_60, - END OF ty_representation_type, + END OF ty_representation_type . + TYPES: "!

Representation Types

"! Assigned representation types ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY - representation_type. - + representation_type . TYPES: "!

Comparison Type

"! Comparison type @@ -379,7 +320,7 @@ INTERFACE zif_aff_edcc_v1 "! $required description TYPE ty_long_description, "!

Position Number

- "! position number + "! Position number "! $required position_number TYPE ty_position_number, "!

Implementing Class

@@ -408,20 +349,22 @@ INTERFACE zif_aff_edcc_v1 "! Assigned representation types "! $required representation_types TYPE ty_representation_types, - END OF ty_comparison_type, + END OF ty_comparison_type . + TYPES: "!

Comparison Types

"! Define comparison types - ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. - + ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type . TYPES: "!

Relevance

"! Relevance "! $values {@link zif_aff_edcc_v1.data:co_relevance} "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} - ty_relevance TYPE c LENGTH 1, + ty_relevance TYPE c LENGTH 1 . + TYPES: "!

Event Name

"! Event name - ty_event_name TYPE c LENGTH 25, + ty_event_name TYPE c LENGTH 25 . + TYPES: "!

Assigned Comparison

"! Assigned comparison BEGIN OF ty_assigned_comparison, @@ -431,11 +374,13 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_assigned_comparison, + END OF ty_assigned_comparison . + TYPES: "!

Assign Checks and Comparison Type

"! Assign Checks and Comparison Type ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY - comparison_type check_id, + comparison_type check_id . + TYPES: "!

Check Relevance

"! Define relevance of check BEGIN OF ty_check_relevance, @@ -450,27 +395,12 @@ INTERFACE zif_aff_edcc_v1 "!

Relevance

"! Relevance relevance TYPE ty_relevance, - END OF ty_check_relevance, + END OF ty_check_relevance . + TYPES: "!

Check Relevance

"! Define relevance of checks ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY - comparison_type check_id. - - CONSTANTS: - "!

Relevance

- "! Relevance - BEGIN OF co_relevance, - "!

Relevant

- "! Relevant - relevant TYPE ty_relevance VALUE 'R', - "!

Not Relevant

- "! Not relevant - not_relevant TYPE ty_relevance VALUE 'N', - "!

Unchanged

- "! Unchanged - unchanged TYPE ty_relevance VALUE 'U', - END OF co_relevance. - + comparison_type check_id . TYPES: "!

Assign Event

"! Assign event to consistency scenario @@ -487,47 +417,51 @@ INTERFACE zif_aff_edcc_v1 "!

Check Relevance

"! Define relevance of checks check_relevance TYPE ty_check_relevances, - END OF ty_event, + END OF ty_event . + TYPES: "!

Assign Events

"! Assign events to consistency scenario - ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event. - + ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event . TYPES: "!

Representation Type

- "! Assign representation type associated with comsistency scenario + "! Assign representation type associated with consistency scenario BEGIN OF ty_relationship_attribute, "!

Representation Type

"! Representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_relationship_attribute, + END OF ty_relationship_attribute . + TYPES: "!

Representation Types

- "! Assign representation types associated with comsistency scenario + "! Assign representation types associated with consistency scenario ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY - representation_type, + representation_type . + TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with comsistency scenario BEGIN OF ty_edoc_type, "!

eDocument Type

"! eDocument Type edoc_type TYPE c LENGTH 10, - END OF ty_edoc_type, + END OF ty_edoc_type . + TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with comsistency scenario - ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. - + ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type . TYPES: "!

Inconsistency Category

"! Inconsistency category - ty_resultgroup TYPE c LENGTH 20, - + ty_resultgroup TYPE c LENGTH 20 . + TYPES: "!

Result Process

"! Assign result process to the UI group BEGIN OF ty_results_process, result_process TYPE ty_result_process, - END OF ty_results_process, + END OF ty_results_process . + TYPES: "!

Result Processes

"! Assign result process to the UI group - ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process, + ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process . + TYPES: "!

Inconsistency Category

"! Inconsistency category BEGIN OF ty_inconsistency_category, @@ -540,11 +474,12 @@ INTERFACE zif_aff_edcc_v1 "!

Result Processes

"! Assign result process to the UI group result_process TYPE ty_result_processes, - END OF ty_inconsistency_category, + END OF ty_inconsistency_category . + TYPES: "!

Inconsistency Categories

"! Inconsistency categories ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY - result_ui_group. + result_ui_group . TYPES: "!

Consistency Scenario

"! Consistency scenario @@ -557,13 +492,13 @@ INTERFACE zif_aff_edcc_v1 header TYPE zif_aff_types_v1=>ty_header_60_cloud, "!

Country

"! Country - country TYPE ty_country, + country TYPE c LENGTH 3, "!

Tax Authority Message Types

"! Tax authority message types - taxauth_messages TYPE ty_messages, + tax_authority_messages TYPE ty_messages, "!

Additional Tax Authority Tables

"! Additional tax authority tables - taxauth_tables TYPE ty_taxauth_tables, + tax_authority_tables TYPE ty_tax_authority_tables, "!

Comparison Types

"! Define comparison types comparison_types TYPE ty_comparison_types, @@ -571,15 +506,97 @@ INTERFACE zif_aff_edcc_v1 "! Assign events to consistency scenario events TYPE ty_events, "!

Representation Types

- "! Assign representation types associated with comsistency scenario + "! Assign representation types associated with consistency scenario relationship_attribute TYPE ty_relationship_attributes, "!

eDocument Type Assignment

- "! Assign eDocument types associated with comsistency scenario - edocument_type TYPE ty_edoc_types, + "! Assign eDocument types associated with consistency scenario + edocument_types TYPE ty_edoc_types, "!

Inconsistency Categories

"! Inconsistency categories inconsistency_categories TYPE ty_inconsistency_categories, - END OF ty_main. - + END OF ty_main . + CONSTANTS: + "!

Check Formula

+ "! Formula applied to do content check for the field group + BEGIN OF co_check_formula, + "!

Field to Field Comparison

+ "! Field to field comparison + field TYPE ty_check_formula VALUE '1', + "!

Amount Comparison with Absolute Tolerance

+ "! Amount comparison with absolute tolerance + field_with_abstolerance TYPE ty_check_formula VALUE '2', + "!

Amount Comparison without Absolute Tolerance

+ "! Amount comparison without absolute tolerance + field_with_nonabstolerance TYPE ty_check_formula VALUE '3', + END OF co_check_formula . + CONSTANTS: + "!

Field Group Level

+ "! Level of comparison field group + BEGIN OF co_field_group_level, + "!

Header

+ "! Header + header TYPE ty_field_group_level VALUE 'H', + "!

Item

+ "! Item + item TYPE ty_field_group_level VALUE 'I', + END OF co_field_group_level . + CONSTANTS: + "!

Filter Operation

+ "! Operand to build the where condition + BEGIN OF co_filter_operation, + "!

And

+ "! And + and TYPE ty_filter_operation VALUE 'AND', + "!

Or

+ "! Or + or TYPE ty_filter_operation VALUE 'OR', + END OF co_filter_operation . + CONSTANTS: + "!

Expression Indicator

+ "! Expression indicator + BEGIN OF co_expression, + "!

Begin of Expression

+ "! Begin of expression + beginof TYPE ty_expression_indicator VALUE '/', + "!

End of Expression

+ "! End of Eexpression + endof TYPE ty_expression_indicator VALUE '\', + END OF co_expression . + CONSTANTS: + "!

Comparison Operator

+ "! Comparison operator + BEGIN OF co_compare_operation, + "!

Equal

+ "! Equal + equal TYPE ty_comparison_operator VALUE '=', + "!

Not Equal

+ "! Not Equal + not_equal TYPE ty_comparison_operator VALUE '<>', + END OF co_compare_operation . + CONSTANTS: + "!

Check Execution Control

+ "! Check execution control + BEGIN OF co_execution_control, + "!

No Check

+ "! Proceed with check even when inconsistency is identified + proceed TYPE ty_execution_control VALUE '00', + "!

Proceed If No Inconsistency Identified From Previous Check

+ "! Proceed If No Inconsistency Identified From Previous Check + no_proceed TYPE ty_execution_control VALUE '01', + END OF co_execution_control . + CONSTANTS: + "!

Relevance

+ "! Relevance + BEGIN OF co_relevance, + "!

Relevant

+ "! Relevant + relevant TYPE ty_relevance VALUE 'R', + "!

Not Relevant

+ "! Not relevant + not_relevant TYPE ty_relevance VALUE 'N', + "!

Unchanged

+ "! Unchanged + unchanged TYPE ty_relevance VALUE 'U', + END OF co_relevance . ENDINTERFACE. diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.json b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json index 59f7f02e7..e432bd2a2 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.json +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json @@ -1,7 +1,7 @@ { "formatVersion": "1", "header": { - "description": "AFF type for EDCK", + "description": "AFF type for EDCC", "originalLanguage": "en" } } From 14c7d6e9946dc3b028a01796bf2efa47c26b72e8 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 3 Oct 2024 11:39:36 +0530 Subject: [PATCH 08/21] apalint fixes --- .../edcc/type/zif_aff_edcc_v1.intf.abap | 128 +++++++++--------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 2259b3617..03df9c40b 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -5,7 +5,7 @@ INTERFACE zif_aff_edcc_v1 TYPES: "!

Description

"! Description - ty_short_description TYPE c LENGTH 30 . + ty_short_description TYPE c LENGTH 30. TYPES: "!

Tax Authority Message Type

"! Tax Authority Message type @@ -19,11 +19,11 @@ INTERFACE zif_aff_edcc_v1 "!

Tax Authority Document Type

"! Tax authority document type tax_authority_document_type TYPE c LENGTH 20, - END OF ty_message . + END OF ty_message. TYPES: "!

Tax Authority Message Types

"! Tax authority message types - ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type . + ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type. TYPES: "!

Additional Tax Authority Table

"! Additional tax authority table @@ -31,35 +31,35 @@ INTERFACE zif_aff_edcc_v1 "!

Table Name

"! Table name table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_tax_authority_table . + END OF ty_tax_authority_table. TYPES: "!

Additional Tax Authority Tables

"! Additional tax authority tables - ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name . + ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name. TYPES: "!

Position Number

"! Position number - ty_position_number TYPE c LENGTH 2 . + ty_position_number TYPE c LENGTH 2. TYPES: "!

Result Process

"! Result process - ty_result_process TYPE c LENGTH 10 . + ty_result_process TYPE c LENGTH 10. TYPES: "!

Field Value

"! Field value - ty_field_value TYPE c LENGTH 40 . + ty_field_value TYPE c LENGTH 40. TYPES: "!

Sequence Number

"! Sequence number - ty_sequence_number TYPE c LENGTH 3 . + ty_sequence_number TYPE c LENGTH 3. TYPES: "!

Check Number

"! Check number - ty_check_number TYPE c LENGTH 5 . + ty_check_number TYPE c LENGTH 5. TYPES: "!

Description

"! Description - ty_long_description TYPE c LENGTH 120 . + ty_long_description TYPE c LENGTH 120. TYPES: "!

Existence Check

"! Assigned existence check @@ -79,7 +79,7 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_existence_check . + END OF ty_existence_check. TYPES: "!

Status Check

"! Status check @@ -108,29 +108,29 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_status_check . + END OF ty_status_check. TYPES: "!

Status Checks

"! Assigned status checks - ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number . + ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number. TYPES: "!

Mismatch Field Group

"! Comparison field group for mismatched fields - ty_field_group TYPE c LENGTH 20 . + ty_field_group TYPE c LENGTH 20. TYPES: "!

Field Group Level

"! Level of comparison field group "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} - ty_field_group_level TYPE c LENGTH 1 . + ty_field_group_level TYPE c LENGTH 1. TYPES: - ty_comparison_sequence TYPE c LENGTH 5 . + ty_comparison_sequence TYPE c LENGTH 5. TYPES: "!

Check Formula

"! Formula applied to perform the content check on field group "! $values {@link zif_aff_edcc_v1.data:co_check_formula} "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} - ty_check_formula TYPE c LENGTH 1 . + ty_check_formula TYPE c LENGTH 1. TYPES: "!

Comparison Field Name

"! Field Names those values will be compared @@ -144,11 +144,11 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Sequence

"! Comparison sequence comparison_sequence TYPE ty_comparison_sequence, - END OF ty_comparison_field . + END OF ty_comparison_field. TYPES: "!

Comparison Field Name

"! Field Names those values will be compared - ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type . + ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. TYPES: "!

Comparison Field Group

"! Comparison field group @@ -171,12 +171,12 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Name

"! Field Names those values will be compared comparison_field TYPE ty_comparison_fields, - END OF ty_comparison_field_group . + END OF ty_comparison_field_group. TYPES: "!

Comparison Field Groups

"! Comparison field groups ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group - WITH UNIQUE KEY field_group . + WITH UNIQUE KEY field_group. TYPES: "!

Content Check

"! Content check @@ -199,33 +199,33 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Groups

"! Comparison field groups content_comparison_field_group TYPE ty_comparison_field_groups, - END OF ty_content_check . + END OF ty_content_check. TYPES: "!

Content Checks

"! Assigned content checks - ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number . + ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number. TYPES: "!

Filter Operation

"! Operand to build the where condition "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} - ty_filter_operation TYPE c LENGTH 3 . + ty_filter_operation TYPE c LENGTH 3. TYPES: "!

Comparison Operator

"! Comparison operator "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} - ty_comparison_operator TYPE c LENGTH 3 . + ty_comparison_operator TYPE c LENGTH 3. TYPES: "!

Filter Field Value

"! Value used to build the where condition - ty_filter_value TYPE c LENGTH 30 . + ty_filter_value TYPE c LENGTH 30. TYPES: "!

Expression Indicator

"! Expression indicator "! $values {@link zif_aff_edcc_v1.data:co_expression} "! $default {@link zif_aff_edcc_v1.data:co_expression.beginof} - ty_expression_indicator TYPE c LENGTH 3 . + ty_expression_indicator TYPE c LENGTH 3. TYPES: "!

Selection Filters on Check

"! Selection filters on check @@ -248,25 +248,25 @@ INTERFACE zif_aff_edcc_v1 "!

Expression Indicator

"! Expression indicator expression_indicator TYPE ty_expression_indicator, - END OF ty_check_filter . + END OF ty_check_filter. TYPES: "!

Selection Filters on Check

"! Selection filters on check - ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number . + ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number. TYPES: "!

Position Number

"! Position number - ty_check_position_number TYPE c LENGTH 3 . + ty_check_position_number TYPE c LENGTH 3. TYPES: "!

Check Execution Sequence

"! Check execution sequence - ty_execution_sequence TYPE c LENGTH 3 . + ty_execution_sequence TYPE c LENGTH 3. TYPES: "!

Check Execution Control

"! Check execution control "! $values {@link zif_aff_edcc_v1.data:co_execution_control} "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} - ty_execution_control TYPE c LENGTH 2 . + ty_execution_control TYPE c LENGTH 2. TYPES: "!

Check Attribute

"! Check attribute @@ -286,11 +286,11 @@ INTERFACE zif_aff_edcc_v1 "!

Selection Filters on Check

"! Selection filters on check check_filter TYPE ty_check_filters, - END OF ty_check_attribute . + END OF ty_check_attribute. TYPES: "!

Check Attributes

"! Check attributes - ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id . + ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id. TYPES: "!

Representation Type

"! Assigned representation type @@ -301,12 +301,12 @@ INTERFACE zif_aff_edcc_v1 "!

Description

"! Description description TYPE zif_aff_types_v1=>ty_description_60, - END OF ty_representation_type . + END OF ty_representation_type. TYPES: "!

Representation Types

"! Assigned representation types ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY - representation_type . + representation_type. TYPES: "!

Comparison Type

"! Comparison type @@ -349,21 +349,21 @@ INTERFACE zif_aff_edcc_v1 "! Assigned representation types "! $required representation_types TYPE ty_representation_types, - END OF ty_comparison_type . + END OF ty_comparison_type. TYPES: "!

Comparison Types

"! Define comparison types - ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type . + ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. TYPES: "!

Relevance

"! Relevance "! $values {@link zif_aff_edcc_v1.data:co_relevance} "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} - ty_relevance TYPE c LENGTH 1 . + ty_relevance TYPE c LENGTH 1. TYPES: "!

Event Name

"! Event name - ty_event_name TYPE c LENGTH 25 . + ty_event_name TYPE c LENGTH 25. TYPES: "!

Assigned Comparison

"! Assigned comparison @@ -374,12 +374,12 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_assigned_comparison . + END OF ty_assigned_comparison. TYPES: "!

Assign Checks and Comparison Type

"! Assign Checks and Comparison Type ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY - comparison_type check_id . + comparison_type check_id. TYPES: "!

Check Relevance

"! Define relevance of check @@ -395,12 +395,12 @@ INTERFACE zif_aff_edcc_v1 "!

Relevance

"! Relevance relevance TYPE ty_relevance, - END OF ty_check_relevance . + END OF ty_check_relevance. TYPES: "!

Check Relevance

"! Define relevance of checks ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY - comparison_type check_id . + comparison_type check_id. TYPES: "!

Assign Event

"! Assign event to consistency scenario @@ -417,11 +417,11 @@ INTERFACE zif_aff_edcc_v1 "!

Check Relevance

"! Define relevance of checks check_relevance TYPE ty_check_relevances, - END OF ty_event . + END OF ty_event. TYPES: "!

Assign Events

"! Assign events to consistency scenario - ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event . + ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event. TYPES: "!

Representation Type

"! Assign representation type associated with consistency scenario @@ -429,12 +429,12 @@ INTERFACE zif_aff_edcc_v1 "!

Representation Type

"! Representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_relationship_attribute . + END OF ty_relationship_attribute. TYPES: "!

Representation Types

"! Assign representation types associated with consistency scenario ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY - representation_type . + representation_type. TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with comsistency scenario @@ -442,25 +442,25 @@ INTERFACE zif_aff_edcc_v1 "!

eDocument Type

"! eDocument Type edoc_type TYPE c LENGTH 10, - END OF ty_edoc_type . + END OF ty_edoc_type. TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with comsistency scenario - ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type . + ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. TYPES: "!

Inconsistency Category

"! Inconsistency category - ty_resultgroup TYPE c LENGTH 20 . + ty_resultgroup TYPE c LENGTH 20. TYPES: "!

Result Process

"! Assign result process to the UI group BEGIN OF ty_results_process, result_process TYPE ty_result_process, - END OF ty_results_process . + END OF ty_results_process. TYPES: "!

Result Processes

"! Assign result process to the UI group - ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process . + ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process. TYPES: "!

Inconsistency Category

"! Inconsistency category @@ -474,12 +474,12 @@ INTERFACE zif_aff_edcc_v1 "!

Result Processes

"! Assign result process to the UI group result_process TYPE ty_result_processes, - END OF ty_inconsistency_category . + END OF ty_inconsistency_category. TYPES: "!

Inconsistency Categories

"! Inconsistency categories ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY - result_ui_group . + result_ui_group. TYPES: "!

Consistency Scenario

"! Consistency scenario @@ -514,7 +514,7 @@ INTERFACE zif_aff_edcc_v1 "!

Inconsistency Categories

"! Inconsistency categories inconsistency_categories TYPE ty_inconsistency_categories, - END OF ty_main . + END OF ty_main. CONSTANTS: "!

Check Formula

@@ -529,7 +529,7 @@ INTERFACE zif_aff_edcc_v1 "!

Amount Comparison without Absolute Tolerance

"! Amount comparison without absolute tolerance field_with_nonabstolerance TYPE ty_check_formula VALUE '3', - END OF co_check_formula . + END OF co_check_formula. CONSTANTS: "!

Field Group Level

"! Level of comparison field group @@ -540,7 +540,7 @@ INTERFACE zif_aff_edcc_v1 "!

Item

"! Item item TYPE ty_field_group_level VALUE 'I', - END OF co_field_group_level . + END OF co_field_group_level. CONSTANTS: "!

Filter Operation

"! Operand to build the where condition @@ -551,7 +551,7 @@ INTERFACE zif_aff_edcc_v1 "!

Or

"! Or or TYPE ty_filter_operation VALUE 'OR', - END OF co_filter_operation . + END OF co_filter_operation. CONSTANTS: "!

Expression Indicator

"! Expression indicator @@ -562,7 +562,7 @@ INTERFACE zif_aff_edcc_v1 "!

End of Expression

"! End of Eexpression endof TYPE ty_expression_indicator VALUE '\', - END OF co_expression . + END OF co_expression. CONSTANTS: "!

Comparison Operator

"! Comparison operator @@ -573,7 +573,7 @@ INTERFACE zif_aff_edcc_v1 "!

Not Equal

"! Not Equal not_equal TYPE ty_comparison_operator VALUE '<>', - END OF co_compare_operation . + END OF co_compare_operation. CONSTANTS: "!

Check Execution Control

"! Check execution control @@ -584,7 +584,7 @@ INTERFACE zif_aff_edcc_v1 "!

Proceed If No Inconsistency Identified From Previous Check

"! Proceed If No Inconsistency Identified From Previous Check no_proceed TYPE ty_execution_control VALUE '01', - END OF co_execution_control . + END OF co_execution_control. CONSTANTS: "!

Relevance

"! Relevance @@ -598,5 +598,5 @@ INTERFACE zif_aff_edcc_v1 "!

Unchanged

"! Unchanged unchanged TYPE ty_relevance VALUE 'U', - END OF co_relevance . + END OF co_relevance. ENDINTERFACE. From 6ed4cdb0f85c934c733cccd07fd9f9cfc5f74732 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 3 Oct 2024 11:41:18 +0530 Subject: [PATCH 09/21] abap lint fixes --- file-formats/edcc/type/zif_aff_edcc_v1.intf.abap | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 03df9c40b..beaf34cac 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,7 +1,5 @@ INTERFACE zif_aff_edcc_v1 - PUBLIC . - - + PUBLIC. TYPES: "!

Description

"! Description From 283eda5af3ef9a172017b93eaa416343d2ddee0c Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 3 Oct 2024 13:07:13 +0530 Subject: [PATCH 10/21] Fixes in example file --- .../examples/z_aff_example_edcc.edcc.json | 123 +++++++++--------- 1 file changed, 64 insertions(+), 59 deletions(-) diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json index 58dac9f8b..6614d919b 100644 --- a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -1,22 +1,21 @@ { "formatVersion": "1", "header": { - "description": "Example Scenario", + "description": "example consistency scenario", "originalLanguage": "en", "abapLanguageVersion": "cloudDevelopment" }, - "country": "ES", - "taxauthMessages": [ + "country": "es", + "taxAuthorityMessages": [ { - "messageType": "TaxAuthorityInvPull", - "messageTypeDescription": "Pull Data from Tax Authority", - "taxauthDocumenttype": "ES_IN_V_DOC1", - "originalLanguage": "en" + "messageType": "ES_INV_SUPPLIER_PULL", + "messageTypeDescription": "Example Spain Invoice pull", + "taxAuthorityDocumentType": "ES_INV_DOC" } ], - "taxauthTables": [ + "taxAuthorityTables": [ { - "tableName": "ES_TAXAUTH_TABLE" + "tableName": "EDCEXAMPINV" } ], "comparisonTypes": [ @@ -28,54 +27,44 @@ "dataSource": "I_EDC_EXAMPLE", "existenceCheck": { "checkId": "Existence", - "description": "Example existence check", + "description": "Example", "fieldName": "EDCEXIST", "fieldValue": "X", "resultProcess": "ZMISSING1" }, "statusCheck": [ { - "checkId": "Example 1", - "description": "Example Status check", + "checkId": "EDCSTAT", + "description": "Example Status Check", "sequenceNumber": "1", "sourceFieldname1": "InvoiceReportingStatus", "sourceFieldvalue1": "ACCEPT", - "sourceFieldname2": "ACRStatus", + "sourceFieldname2": "ACRstatus", "sourceFieldvalue2": "REJECT", "resultProcess": "ZPROCESS1" - }, - { - "checkId": "Example 2", - "description": "Example Status check", - "sequenceNumber": "2", - "sourceFieldname1": "InvoiceSubmissionStatus", - "sourceFieldvalue1": "ACCEPT", - "sourceFieldname2": "eDocumentStatus", - "sourceFieldvalue2": "REJECT", - "resultProcess": "ZPROCESS2" } ], "contentCheck": [ { "checkId": "ExampleContentCheck1", - "description": "Content check of Invoices", + "description": "Sample content check", "checkNumber": "1", - "contentComparisonFieldgroup": [ + "contentComparisonFieldGroup": [ { - "fieldGroup": "InvoiceHeaderFields", - "description": "Example", + "fieldGroup": "INV_HEADER", + "description": "Invoice header fields", "fieldGroupLevel": "header", "checkFormula": "field", - "resultProcess": "ZCONTENT1", + "resultProcess": "ZHEADPROC1", "comparisonField": [ { "representationType": "EDOCUMENT", - "fieldName": "TotalAmount", + "fieldName": "supplier_Invoice_tax_amount", "comparisonSequence": "1" }, { "representationType": "TAXAUTHDOC", - "fieldName": "TotalAmount", + "fieldName": "purchase_Invoice_tax_amount", "comparisonSequence": "2" } ] @@ -85,41 +74,14 @@ ], "checkAttributes": [ { - "checkId": "Existence", - "positionNumber": "1", - "executionSequence": "1", - "executionControl": "proceed", - "checkFilter": [ - { - "filterOperation": "and", - "comparisonOperator": "equal", - "expressionIndicator": "beginof" - } - ] - }, - { - "checkId": "Example 1", - "positionNumber": "2", - "executionSequence": "2", + "checkId": "", "executionControl": "proceed" - }, - { - "checkId": "Example 2", - "positionNumber": "3", - "executionSequence": "3", - "executionControl": "proceed" - }, - { - "checkId": "ExampleContentCheck1", - "positionNumber": "4", - "executionSequence": "4", - "executionControl": "noProceed" } ], "representationTypes": [ { "representationType": "EDOCUMENT", - "description": "example eDocument" + "description": "eDocument" }, { "representationType": "TAXAUTHDOC", @@ -127,5 +89,48 @@ } ] } + ], + "events": [ + { + "event": "EDOCSUB", + "description": "Example eDocument submission event", + "assignedComparison": [ + { + "comparisonType": "TaxAuthVeDoc", + "checkId": "EDCSTAT" + } + ], + "checkRelevance": [ + { + "comparisonType": "TaxAuthVeDoc", + "checkId": "EDCSTAT", + "relevance": "relevant" + } + ] + } + ], + "relationshipAttribute": [ + { + "representationType": "EDOCUMENT" + }, + { + "representationType": "TAXAUTHDOC" + } + ], + "edocumentTypes": [ + { + "edocType": "ZEXAMPLE" + } + ], + "inconsistencyCategories": [ + { + "resultUiGroup": "ZCONTENTMISMATCH", + "countryXtension": "ZX_SOMEEXTENSION", + "resultProcess": [ + { + "resultProcess": "ZPROCESS1" + } + ] + } ] } From 783e85e0c4bcb504e0b26308f0b3e8518a915ed6 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Wed, 9 Oct 2024 13:26:16 +0530 Subject: [PATCH 11/21] Last Comment fixes for AFF --- .../edcc/type/zif_aff_edcc_v1.intf.abap | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index beaf34cac..3174d5533 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -93,16 +93,16 @@ INTERFACE zif_aff_edcc_v1 sequence_number TYPE ty_sequence_number, "!

Source Field Name 1

"! Source field name 1 - source_fieldname1 TYPE zif_aff_types_v1=>ty_object_name_30, + source_field_name1 TYPE zif_aff_types_v1=>ty_object_name_30, "!

Source Field Value 1

"! Source field value 1 - source_fieldvalue1 TYPE ty_field_value, + source_field_value1 TYPE ty_field_value, "!

Source Field Name 2

"! Source field name 2 - source_fieldname2 TYPE zif_aff_types_v1=>ty_object_name_30, + source_field_name2 TYPE zif_aff_types_v1=>ty_object_name_30, "!

Source Field Value 2

"! Source field value 2 - source_fieldvalue2 TYPE ty_field_value, + source_field_value2 TYPE ty_field_value, "!

Result Process

"! Result process result_process TYPE ty_result_process, @@ -125,13 +125,13 @@ INTERFACE zif_aff_edcc_v1 ty_comparison_sequence TYPE c LENGTH 5. TYPES: "!

Check Formula

- "! Formula applied to perform the content check on field group + "! Formula applied to perform the content check on the field group "! $values {@link zif_aff_edcc_v1.data:co_check_formula} "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} ty_check_formula TYPE c LENGTH 1. TYPES: "!

Comparison Field Name

- "! Field Names those values will be compared + "! Field Names whose values will be compared BEGIN OF ty_comparison_field, "!

Representation Type

"! Representation type @@ -145,7 +145,7 @@ INTERFACE zif_aff_edcc_v1 END OF ty_comparison_field. TYPES: "!

Comparison Field Name

- "! Field Names those values will be compared + "! Field Names whose values will be compared ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. TYPES: "!

Comparison Field Group

@@ -161,13 +161,13 @@ INTERFACE zif_aff_edcc_v1 "! Level of comparison field group field_group_level TYPE ty_field_group_level, "!

Check Formula

- "! Formula applied to perform the content check on field group + "! Formula applied to perform the content check on the field group check_formula TYPE ty_check_formula, "!

Result Process

"! Result process result_process TYPE ty_result_process, "!

Comparison Field Name

- "! Field Names those values will be compared + "! Field Names whose values will be compared comparison_field TYPE ty_comparison_fields, END OF ty_comparison_field_group. TYPES: @@ -222,7 +222,7 @@ INTERFACE zif_aff_edcc_v1 "!

Expression Indicator

"! Expression indicator "! $values {@link zif_aff_edcc_v1.data:co_expression} - "! $default {@link zif_aff_edcc_v1.data:co_expression.beginof} + "! $default {@link zif_aff_edcc_v1.data:co_expression.begin_of} ty_expression_indicator TYPE c LENGTH 3. TYPES: "!

Selection Filters on Check

@@ -435,7 +435,7 @@ INTERFACE zif_aff_edcc_v1 representation_type. TYPES: "!

eDocument Type Assignment

- "! Assign eDocument types associated with comsistency scenario + "! Assign eDocument types associated with consistency scenario BEGIN OF ty_edoc_type, "!

eDocument Type

"! eDocument Type @@ -443,7 +443,7 @@ INTERFACE zif_aff_edcc_v1 END OF ty_edoc_type. TYPES: "!

eDocument Type Assignment

- "! Assign eDocument types associated with comsistency scenario + "! Assign eDocument types associated with consistency scenario ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. TYPES: "!

Inconsistency Category

@@ -516,17 +516,17 @@ INTERFACE zif_aff_edcc_v1 CONSTANTS: "!

Check Formula

- "! Formula applied to do content check for the field group + "! Formula applied to perform the content check on the field group BEGIN OF co_check_formula, "!

Field to Field Comparison

"! Field to field comparison field TYPE ty_check_formula VALUE '1', "!

Amount Comparison with Absolute Tolerance

"! Amount comparison with absolute tolerance - field_with_abstolerance TYPE ty_check_formula VALUE '2', + field_with_abs_tolerance TYPE ty_check_formula VALUE '2', "!

Amount Comparison without Absolute Tolerance

"! Amount comparison without absolute tolerance - field_with_nonabstolerance TYPE ty_check_formula VALUE '3', + field_without_abs_tolerance TYPE ty_check_formula VALUE '3', END OF co_check_formula. CONSTANTS: "!

Field Group Level

@@ -556,10 +556,10 @@ INTERFACE zif_aff_edcc_v1 BEGIN OF co_expression, "!

Begin of Expression

"! Begin of expression - beginof TYPE ty_expression_indicator VALUE '/', + begin_of TYPE ty_expression_indicator VALUE '/', "!

End of Expression

"! End of Eexpression - endof TYPE ty_expression_indicator VALUE '\', + end_of TYPE ty_expression_indicator VALUE '\', END OF co_expression. CONSTANTS: "!

Comparison Operator

From 510ed62265fa58386d42f7c40a981c15b67c277b Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Wed, 9 Oct 2024 13:27:31 +0530 Subject: [PATCH 12/21] Generated Schema error --- file-formats/edcc/edcc-v1.json | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index 01fafdd36..1933b20d6 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -218,25 +218,25 @@ "type": "string", "maxLength": 3 }, - "sourceFieldname1": { + "sourceFieldName1": { "title": "Source Field Name 1", "description": "Source field name 1", "type": "string", "maxLength": 30 }, - "sourceFieldvalue1": { + "sourceFieldValue1": { "title": "Source Field Value 1", "description": "Source field value 1", "type": "string", "maxLength": 40 }, - "sourceFieldname2": { + "sourceFieldName2": { "title": "Source Field Name 2", "description": "Source field name 2", "type": "string", "maxLength": 30 }, - "sourceFieldvalue2": { + "sourceFieldValue2": { "title": "Source Field Value 2", "description": "Source field value 2", "type": "string", @@ -334,12 +334,12 @@ }, "checkFormula": { "title": "Check Formula", - "description": "Formula applied to perform the content check on field group", + "description": "Formula applied to perform the content check on the field group", "type": "string", "enum": [ "field", - "fieldWithAbstolerance", - "fieldWithNonabstolerance" + "fieldWithAbsTolerance", + "fieldWithoutAbsTolerance" ], "enumTitles": [ "Field to Field Comparison", @@ -361,12 +361,12 @@ }, "comparisonField": { "title": "Comparison Field Name", - "description": "Field Names those values will be compared", + "description": "Field Names whose values will be compared", "type": "array", "uniqueItems": true, "items": { "title": "Comparison Field Name", - "description": "Field Names those values will be compared", + "description": "Field Names whose values will be compared", "type": "object", "properties": { "representationType": { @@ -514,8 +514,8 @@ "description": "Expression indicator", "type": "string", "enum": [ - "beginof", - "endof" + "beginOf", + "endOf" ], "enumTitles": [ "Begin of Expression", @@ -525,7 +525,7 @@ "Begin of expression", "End of Eexpression" ], - "default": "beginof" + "default": "beginOf" } }, "additionalProperties": false @@ -705,7 +705,7 @@ "uniqueItems": true, "items": { "title": "eDocument Type Assignment", - "description": "Assign eDocument types associated with comsistency scenario", + "description": "Assign eDocument types associated with consistency scenario", "type": "object", "properties": { "edocType": { From 1c58269aa9f47527f98aec7b00edd5a684c11bcd Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Wed, 9 Oct 2024 13:32:03 +0530 Subject: [PATCH 13/21] abap lint fixes --- file-formats/edcc/type/zif_aff_edcc_v1.intf.abap | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 3174d5533..8d88f1d5a 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -84,13 +84,13 @@ INTERFACE zif_aff_edcc_v1 BEGIN OF ty_status_check, "!

Check Id

"! Check id - check_id TYPE zif_aff_types_v1=>ty_object_name_30, + check_id TYPE zif_aff_types_v1=>ty_object_name_30, "!

Check Description

"! Check description - description TYPE zif_aff_types_v1=>ty_description_60, + description TYPE zif_aff_types_v1=>ty_description_60, "!

Sequence Number

"! Sequence number - sequence_number TYPE ty_sequence_number, + sequence_number TYPE ty_sequence_number, "!

Source Field Name 1

"! Source field name 1 source_field_name1 TYPE zif_aff_types_v1=>ty_object_name_30, @@ -105,7 +105,7 @@ INTERFACE zif_aff_edcc_v1 source_field_value2 TYPE ty_field_value, "!

Result Process

"! Result process - result_process TYPE ty_result_process, + result_process TYPE ty_result_process, END OF ty_status_check. TYPES: "!

Status Checks

@@ -520,7 +520,7 @@ INTERFACE zif_aff_edcc_v1 BEGIN OF co_check_formula, "!

Field to Field Comparison

"! Field to field comparison - field TYPE ty_check_formula VALUE '1', + field TYPE ty_check_formula VALUE '1', "!

Amount Comparison with Absolute Tolerance

"! Amount comparison with absolute tolerance field_with_abs_tolerance TYPE ty_check_formula VALUE '2', From a5109568e8ab303f6702aa0f44bc62be01152c83 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 17 Oct 2024 11:54:34 +0530 Subject: [PATCH 14/21] Changes after online review --- file-formats/edcc/edcc-v1.json | 95 +++++++++++-------- .../examples/z_aff_example_edcc.edcc.json | 95 ++++++++++--------- .../edcc/type/zif_aff_edcc_v1.intf.abap | 85 +++++++++++------ 3 files changed, 166 insertions(+), 109 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index 1933b20d6..5243e8e1e 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -60,6 +60,53 @@ "type": "string", "maxLength": 3 }, + "additionalSelectionFields": { + "title": "Additional Selection Fields", + "description": "Additional selection fields of validation report", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Additional Selection Field", + "description": "Additional selection fields of validation report", + "type": "object", + "properties": { + "tableName": { + "title": "Table Name", + "description": "Table name", + "type": "string", + "maxLength": 30 + }, + "fieldName": { + "title": "Field Name", + "description": "Field name", + "type": "string", + "maxLength": 30 + }, + "fieldType": { + "title": "Field Type", + "description": "Field type", + "type": "string", + "enum": [ + "selectOptions", + "parameterSingleValue", + "parameterMultipleValues" + ], + "enumTitles": [ + "Selection Option", + "Parameter Single Value", + "Parameter Multiple Values" + ], + "enumDescriptions": [ + "Selection option", + "Parameter single value", + "Parameter multiple values" + ], + "default": "selectOptions" + } + }, + "additionalProperties": false + } + }, "taxAuthorityMessages": { "title": "Tax Authority Message Types", "description": "Tax authority message types", @@ -76,12 +123,6 @@ "type": "string", "maxLength": 20 }, - "messageTypeDescription": { - "title": "Message Type Description", - "description": "Message type description", - "type": "string", - "maxLength": 30 - }, "taxAuthorityDocumentType": { "title": "Tax Authority Document Type", "description": "Tax authority document type", @@ -89,7 +130,11 @@ "maxLength": 20 } }, - "additionalProperties": false + "additionalProperties": false, + "required": [ + "messageType", + "taxAuthorityDocumentType" + ] } }, "taxAuthorityTables": { @@ -163,12 +208,6 @@ "type": "string", "maxLength": 30 }, - "description": { - "title": "Check Description", - "description": "Check description", - "type": "string", - "maxLength": 60 - }, "fieldName": { "title": "Field Name", "description": "Field name", @@ -206,12 +245,6 @@ "type": "string", "maxLength": 30 }, - "description": { - "title": "Check Description", - "description": "Check description", - "type": "string", - "maxLength": 60 - }, "sequenceNumber": { "title": "Sequence Number", "description": "Sequence number", @@ -268,12 +301,6 @@ "type": "string", "maxLength": 30 }, - "description": { - "title": "Check Description", - "description": "Check description", - "type": "string", - "maxLength": 60 - }, "checkNumber": { "title": "Check Number", "description": "Check number", @@ -550,12 +577,6 @@ "description": "Assigned representation type", "type": "string", "maxLength": 30 - }, - "description": { - "title": "Description", - "description": "Description", - "type": "string", - "maxLength": 60 } }, "additionalProperties": false @@ -591,12 +612,6 @@ "type": "string", "maxLength": 25 }, - "description": { - "title": "Description", - "description": "Description", - "type": "string", - "maxLength": 100 - }, "assignedComparison": { "title": "Assign Checks and Comparison Type", "description": "Assign Checks and Comparison Type", @@ -768,6 +783,10 @@ "additionalProperties": false, "required": [ "formatVersion", - "header" + "header", + "country", + "comparisonTypes", + "relationshipAttribute", + "inconsistencyCategories" ] } diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json index 6614d919b..eebb77489 100644 --- a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -1,70 +1,69 @@ { "formatVersion": "1", "header": { - "description": "example consistency scenario", + "description": "Sample Consistency Scenario", "originalLanguage": "en", "abapLanguageVersion": "cloudDevelopment" }, - "country": "es", + "country": "en", "taxAuthorityMessages": [ { - "messageType": "ES_INV_SUPPLIER_PULL", - "messageTypeDescription": "Example Spain Invoice pull", - "taxAuthorityDocumentType": "ES_INV_DOC" + "messageType": "EXAMPLE_MESSAGE_TYPE", + "messageTypeDescription": "example message type", + "taxAuthorityDocumentType": "EXAMPLE_INVOICE" } ], "taxAuthorityTables": [ { - "tableName": "EDCEXAMPINV" + "tableName": "EXAMPLE_TAXAUTHORITY_TABLES" } ], "comparisonTypes": [ { - "comparisonType": "TaxAuthVeDoc", - "description": "Compare Tax Authority Invoice with eDocument", + "comparisonType": "TaxAuthV/sEdoc", + "description": "Tax Authority V/s Edocument", "positionNumber": "1", - "className": "CL_EDC_EXAMPLE_CLASS", - "dataSource": "I_EDC_EXAMPLE", + "className": "CL_EDC_EXAMPLE_VALTYPE", + "dataSource": "CDS_COMPARISON_EXAMPLE", "existenceCheck": { - "checkId": "Existence", - "description": "Example", - "fieldName": "EDCEXIST", + "checkId": "EXISTENCE_CHECK", + "fieldName": "CDS_COMPARISON_EXAMPLE-FIELD1", "fieldValue": "X", - "resultProcess": "ZMISSING1" + "resultProcess": "EXMISMATCH" }, "statusCheck": [ { - "checkId": "EDCSTAT", - "description": "Example Status Check", + "checkId": "STATUS_MISMATCH", "sequenceNumber": "1", - "sourceFieldname1": "InvoiceReportingStatus", - "sourceFieldvalue1": "ACCEPT", - "sourceFieldname2": "ACRstatus", - "sourceFieldvalue2": "REJECT", - "resultProcess": "ZPROCESS1" + "sourceFieldName1": "CDS_EXAMPLE_FIELD1", + "sourceFieldValue1": "ACCEPTED", + "sourceFieldName2": "CDS_EXAMPLE_FIELD2", + "sourceFieldValue2": "REJECTED", + "resultProcess": "REJRESULT" } ], "contentCheck": [ { - "checkId": "ExampleContentCheck1", - "description": "Sample content check", + "checkId": "CONTENT_CHECK", "checkNumber": "1", + "dataSource": "CDS_CONTENT_CHECK", + "additionalDescription": "Description for UI", "contentComparisonFieldGroup": [ { - "fieldGroup": "INV_HEADER", - "description": "Invoice header fields", + "fieldGroup": "EXMPL_FIELDGRP1", + "description": "Description of Field Group", "fieldGroupLevel": "header", "checkFormula": "field", - "resultProcess": "ZHEADPROC1", + "resultProcess": "EXCONTENT", "comparisonField": [ { "representationType": "EDOCUMENT", - "fieldName": "supplier_Invoice_tax_amount", + "fieldName": "CDS_TAX_FIELD1", "comparisonSequence": "1" }, { "representationType": "TAXAUTHDOC", - "fieldName": "purchase_Invoice_tax_amount", + "fieldName": "CDS_TAXAUTH_TAXFIELD1", "comparisonSequence": "2" } ] @@ -74,36 +73,46 @@ ], "checkAttributes": [ { - "checkId": "", + "checkId": "EXISTENCE_CHECK", + "positionNumber": "1", + "executionSequence": "1", "executionControl": "proceed" + }, + { + "checkId": "STATUS_MISMATCH", + "positionNumber": "2", + "executionSequence": "2", + "executionControl": "noProceed" + }, + { + "checkId": "CONTENT_CHECK", + "positionNumber": "3", + "executionSequence": "3", + "executionControl": "noProceed" } ], "representationTypes": [ { - "representationType": "EDOCUMENT", - "description": "eDocument" + "representationType": "EDOCUMENT" }, { - "representationType": "TAXAUTHDOC", - "description": "Tax Authority Document" + "representationType": "TAXAUTHDOC" } ] } ], "events": [ { - "event": "EDOCSUB", - "description": "Example eDocument submission event", + "event": "EDOC_SUBMIT", "assignedComparison": [ { - "comparisonType": "TaxAuthVeDoc", - "checkId": "EDCSTAT" + "comparisonType": "TaxAuthV/sEdoc" } ], "checkRelevance": [ { - "comparisonType": "TaxAuthVeDoc", - "checkId": "EDCSTAT", + "comparisonType": "TaxAuthV/sEdoc", + "checkId": "EXISTENCE_CHECK", "relevance": "relevant" } ] @@ -119,16 +128,16 @@ ], "edocumentTypes": [ { - "edocType": "ZEXAMPLE" + "edocType": "EXEDOCTYPE" } ], "inconsistencyCategories": [ { - "resultUiGroup": "ZCONTENTMISMATCH", - "countryXtension": "ZX_SOMEEXTENSION", + "resultUiGroup": "EDOC_MISSING", + "countryXtension": "X_CDS_EXAMPLE_EXTENSION", "resultProcess": [ { - "resultProcess": "ZPROCESS1" + "resultProcess": "EXMISMATCH" } ] } diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 8d88f1d5a..23a2bda6f 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -10,12 +10,11 @@ INTERFACE zif_aff_edcc_v1 BEGIN OF ty_message, "!

Message Type

"! Message type + "! $required message_type TYPE c LENGTH 20, - "!

Message Type Description

- "! Message type description - message_type_description TYPE ty_short_description, "!

Tax Authority Document Type

"! Tax authority document type + "! $required tax_authority_document_type TYPE c LENGTH 20, END OF ty_message. TYPES: @@ -65,9 +64,6 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - "!

Check Description

- "! Check description - description TYPE zif_aff_types_v1=>ty_description_60, "!

Field Name

"! Field name field_name TYPE zif_aff_types_v1=>ty_object_name_30, @@ -85,9 +81,6 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - "!

Check Description

- "! Check description - description TYPE zif_aff_types_v1=>ty_description_60, "!

Sequence Number

"! Sequence number sequence_number TYPE ty_sequence_number, @@ -182,9 +175,6 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - "!

Check Description

- "! Check description - description TYPE zif_aff_types_v1=>ty_description_60, "!

Check Number

"! Check number check_number TYPE ty_check_number, @@ -296,9 +286,6 @@ INTERFACE zif_aff_edcc_v1 "!

Assigned Representation Type

"! Assigned representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - "!

Description

- "! Description - description TYPE zif_aff_types_v1=>ty_description_60, END OF ty_representation_type. TYPES: "!

Representation Types

@@ -406,9 +393,6 @@ INTERFACE zif_aff_edcc_v1 "!

Event Name

"! Event name event TYPE ty_event_name, - "!

Description

- "! Description - description TYPE zif_aff_types_v1=>ty_description_100, "!

Assign Checks and Comparison Type

"! Assign Checks and Comparison Type assigned_comparison TYPE ty_assigned_comparisons, @@ -478,40 +462,85 @@ INTERFACE zif_aff_edcc_v1 "! Inconsistency categories ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY result_ui_group. + TYPES: + "!

Field Type

+ "! Field type + "! $values {@link zif_aff_edcc_v1.data:co_field_type} + "! $default {@link zif_aff_edcc_v1.data:co_field_type.select_options} + ty_field_type TYPE c LENGTH 1. + CONSTANTS: + "!

Field Type

+ "! Field type + BEGIN OF co_field_type, + "!

Selection Option

+ "! Selection option + select_options TYPE ty_field_type VALUE 'S', + "!

Parameter Single Value

+ "! Parameter single value + parameter_single_value TYPE ty_field_type VALUE 'N', + "!

Parameter Multiple Values

+ "! Parameter multiple values + parameter_multiple_values TYPE ty_field_type VALUE 'P', + END OF co_field_type. + TYPES: + "!

Additional Selection Field

+ "! Additional selection fields of validation report + BEGIN OF ty_additional_selection_field, + "!

Table Name

+ "! Table name + table_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Field Name

+ "! Field name + field_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Field Type

+ "! Field type + field_type TYPE ty_field_type, + END OF ty_additional_selection_field. + TYPES: + "!

Additional Selection Fields

+ "! Additional selection fields of validation report + ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY table_name field_name. TYPES: "!

Consistency Scenario

"! Consistency scenario BEGIN OF ty_main, "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60_cloud, + header TYPE zif_aff_types_v1=>ty_header_60_cloud, "!

Country

"! Country - country TYPE c LENGTH 3, + "! $required + country TYPE c LENGTH 3, + "!

Additional Selection Fields

+ "! Additional selection fields of validation report + additional_selection_fields TYPE ty_additional_selection_fields, "!

Tax Authority Message Types

"! Tax authority message types - tax_authority_messages TYPE ty_messages, + tax_authority_messages TYPE ty_messages, "!

Additional Tax Authority Tables

"! Additional tax authority tables - tax_authority_tables TYPE ty_tax_authority_tables, + tax_authority_tables TYPE ty_tax_authority_tables, "!

Comparison Types

"! Define comparison types - comparison_types TYPE ty_comparison_types, + "! $required + comparison_types TYPE ty_comparison_types, "!

Events Assignment

"! Assign events to consistency scenario - events TYPE ty_events, + events TYPE ty_events, "!

Representation Types

"! Assign representation types associated with consistency scenario - relationship_attribute TYPE ty_relationship_attributes, + "! $required + relationship_attribute TYPE ty_relationship_attributes, "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario - edocument_types TYPE ty_edoc_types, + edocument_types TYPE ty_edoc_types, "!

Inconsistency Categories

"! Inconsistency categories - inconsistency_categories TYPE ty_inconsistency_categories, + "! $required + inconsistency_categories TYPE ty_inconsistency_categories, END OF ty_main. CONSTANTS: From 4d568638ec6ef02975039d5ef3e3c8ff5746a950 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 17 Oct 2024 11:59:07 +0530 Subject: [PATCH 15/21] ABAP Lint fix --- file-formats/edcc/examples/z_aff_example_edcc.edcc.json | 1 - file-formats/edcc/type/zif_aff_edcc_v1.intf.abap | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json index eebb77489..8f41fb7a0 100644 --- a/file-formats/edcc/examples/z_aff_example_edcc.edcc.json +++ b/file-formats/edcc/examples/z_aff_example_edcc.edcc.json @@ -9,7 +9,6 @@ "taxAuthorityMessages": [ { "messageType": "EXAMPLE_MESSAGE_TYPE", - "messageTypeDescription": "example message type", "taxAuthorityDocumentType": "EXAMPLE_INVOICE" } ], diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 23a2bda6f..5cea5f6f5 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -499,7 +499,8 @@ INTERFACE zif_aff_edcc_v1 TYPES: "!

Additional Selection Fields

"! Additional selection fields of validation report - ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY table_name field_name. + ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY + table_name field_name. TYPES: "!

Consistency Scenario

"! Consistency scenario From f5856ed0ccc34bf9d67d8e8ecfd4faaeb44d7d47 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 13:54:37 +0530 Subject: [PATCH 16/21] Fix of latest comments --- file-formats/edcc/edcc-v1.json | 2 +- .../edcc/type/zif_aff_edcc_v1.intf.abap | 306 +++++++++--------- .../edcc/type/zif_aff_edcc_v1.intf.json | 2 +- 3 files changed, 156 insertions(+), 154 deletions(-) diff --git a/file-formats/edcc/edcc-v1.json b/file-formats/edcc/edcc-v1.json index 5243e8e1e..0be9f2136 100644 --- a/file-formats/edcc/edcc-v1.json +++ b/file-formats/edcc/edcc-v1.json @@ -114,7 +114,7 @@ "uniqueItems": true, "items": { "title": "Tax Authority Message Type", - "description": "Tax Authority Message type", + "description": "Tax authority message type", "type": "object", "properties": { "messageType": { diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 5cea5f6f5..d85e27467 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,12 +1,14 @@ -INTERFACE zif_aff_edcc_v1 - PUBLIC. - TYPES: +interface ZIF_AFF_EDCC_V1 + public . + + + types: "!

Description

"! Description - ty_short_description TYPE c LENGTH 30. - TYPES: + ty_short_description TYPE c LENGTH 30 . + types: "!

Tax Authority Message Type

- "! Tax Authority Message type + "! Tax authority message type BEGIN OF ty_message, "!

Message Type

"! Message type @@ -16,48 +18,48 @@ INTERFACE zif_aff_edcc_v1 "! Tax authority document type "! $required tax_authority_document_type TYPE c LENGTH 20, - END OF ty_message. - TYPES: + END OF ty_message . + types: "!

Tax Authority Message Types

"! Tax authority message types - ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type. - TYPES: + ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type . + types: "!

Additional Tax Authority Table

"! Additional tax authority table BEGIN OF ty_tax_authority_table, "!

Table Name

"! Table name table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_tax_authority_table. - TYPES: + END OF ty_tax_authority_table . + types: "!

Additional Tax Authority Tables

"! Additional tax authority tables - ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name. - TYPES: + ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name . + types: "!

Position Number

"! Position number - ty_position_number TYPE c LENGTH 2. - TYPES: + ty_position_number TYPE c LENGTH 2 . + types: "!

Result Process

"! Result process - ty_result_process TYPE c LENGTH 10. - TYPES: + ty_result_process TYPE c LENGTH 10 . + types: "!

Field Value

"! Field value - ty_field_value TYPE c LENGTH 40. - TYPES: + ty_field_value TYPE c LENGTH 40 . + types: "!

Sequence Number

"! Sequence number - ty_sequence_number TYPE c LENGTH 3. - TYPES: + ty_sequence_number TYPE c LENGTH 3 . + types: "!

Check Number

"! Check number - ty_check_number TYPE c LENGTH 5. - TYPES: + ty_check_number TYPE c LENGTH 5 . + types: "!

Description

"! Description - ty_long_description TYPE c LENGTH 120. - TYPES: + ty_long_description TYPE c LENGTH 120 . + types: "!

Existence Check

"! Assigned existence check BEGIN OF ty_existence_check, @@ -73,8 +75,8 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_existence_check. - TYPES: + END OF ty_existence_check . + types: "!

Status Check

"! Status check BEGIN OF ty_status_check, @@ -99,30 +101,30 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_status_check. - TYPES: + END OF ty_status_check . + types: "!

Status Checks

"! Assigned status checks - ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number. - TYPES: + ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number . + types: "!

Mismatch Field Group

"! Comparison field group for mismatched fields - ty_field_group TYPE c LENGTH 20. - TYPES: + ty_field_group TYPE c LENGTH 20 . + types: "!

Field Group Level

"! Level of comparison field group "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} - ty_field_group_level TYPE c LENGTH 1. - TYPES: - ty_comparison_sequence TYPE c LENGTH 5. - TYPES: + ty_field_group_level TYPE c LENGTH 1 . + types: + ty_comparison_sequence TYPE c LENGTH 5 . + types: "!

Check Formula

"! Formula applied to perform the content check on the field group "! $values {@link zif_aff_edcc_v1.data:co_check_formula} "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} - ty_check_formula TYPE c LENGTH 1. - TYPES: + ty_check_formula TYPE c LENGTH 1 . + types: "!

Comparison Field Name

"! Field Names whose values will be compared BEGIN OF ty_comparison_field, @@ -135,12 +137,12 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Sequence

"! Comparison sequence comparison_sequence TYPE ty_comparison_sequence, - END OF ty_comparison_field. - TYPES: + END OF ty_comparison_field . + types: "!

Comparison Field Name

"! Field Names whose values will be compared - ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. - TYPES: + ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type . + types: "!

Comparison Field Group

"! Comparison field group BEGIN OF ty_comparison_field_group, @@ -162,13 +164,13 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Name

"! Field Names whose values will be compared comparison_field TYPE ty_comparison_fields, - END OF ty_comparison_field_group. - TYPES: + END OF ty_comparison_field_group . + types: "!

Comparison Field Groups

"! Comparison field groups ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group - WITH UNIQUE KEY field_group. - TYPES: + WITH UNIQUE KEY field_group . + types: "!

Content Check

"! Content check BEGIN OF ty_content_check, @@ -187,34 +189,34 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Groups

"! Comparison field groups content_comparison_field_group TYPE ty_comparison_field_groups, - END OF ty_content_check. - TYPES: + END OF ty_content_check . + types: "!

Content Checks

"! Assigned content checks - ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number. - TYPES: + ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number . + types: "!

Filter Operation

"! Operand to build the where condition "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} - ty_filter_operation TYPE c LENGTH 3. - TYPES: + ty_filter_operation TYPE c LENGTH 3 . + types: "!

Comparison Operator

"! Comparison operator "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} - ty_comparison_operator TYPE c LENGTH 3. - TYPES: + ty_comparison_operator TYPE c LENGTH 3 . + types: "!

Filter Field Value

"! Value used to build the where condition - ty_filter_value TYPE c LENGTH 30. - TYPES: + ty_filter_value TYPE c LENGTH 30 . + types: "!

Expression Indicator

"! Expression indicator "! $values {@link zif_aff_edcc_v1.data:co_expression} "! $default {@link zif_aff_edcc_v1.data:co_expression.begin_of} - ty_expression_indicator TYPE c LENGTH 3. - TYPES: + ty_expression_indicator TYPE c LENGTH 3 . + types: "!

Selection Filters on Check

"! Selection filters on check BEGIN OF ty_check_filter, @@ -236,26 +238,26 @@ INTERFACE zif_aff_edcc_v1 "!

Expression Indicator

"! Expression indicator expression_indicator TYPE ty_expression_indicator, - END OF ty_check_filter. - TYPES: + END OF ty_check_filter . + types: "!

Selection Filters on Check

"! Selection filters on check - ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number. - TYPES: + ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number . + types: "!

Position Number

"! Position number - ty_check_position_number TYPE c LENGTH 3. - TYPES: + ty_check_position_number TYPE c LENGTH 3 . + types: "!

Check Execution Sequence

"! Check execution sequence - ty_execution_sequence TYPE c LENGTH 3. - TYPES: + ty_execution_sequence TYPE c LENGTH 3 . + types: "!

Check Execution Control

"! Check execution control "! $values {@link zif_aff_edcc_v1.data:co_execution_control} "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} - ty_execution_control TYPE c LENGTH 2. - TYPES: + ty_execution_control TYPE c LENGTH 2 . + types: "!

Check Attribute

"! Check attribute BEGIN OF ty_check_attribute, @@ -274,25 +276,25 @@ INTERFACE zif_aff_edcc_v1 "!

Selection Filters on Check

"! Selection filters on check check_filter TYPE ty_check_filters, - END OF ty_check_attribute. - TYPES: + END OF ty_check_attribute . + types: "!

Check Attributes

"! Check attributes - ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id. - TYPES: + ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id . + types: "!

Representation Type

"! Assigned representation type BEGIN OF ty_representation_type, "!

Assigned Representation Type

"! Assigned representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_representation_type. - TYPES: + END OF ty_representation_type . + types: "!

Representation Types

"! Assigned representation types ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY - representation_type. - TYPES: + representation_type . + types: "!

Comparison Type

"! Comparison type BEGIN OF ty_comparison_type, @@ -334,22 +336,22 @@ INTERFACE zif_aff_edcc_v1 "! Assigned representation types "! $required representation_types TYPE ty_representation_types, - END OF ty_comparison_type. - TYPES: + END OF ty_comparison_type . + types: "!

Comparison Types

"! Define comparison types - ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. - TYPES: + ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type . + types: "!

Relevance

"! Relevance "! $values {@link zif_aff_edcc_v1.data:co_relevance} "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} - ty_relevance TYPE c LENGTH 1. - TYPES: + ty_relevance TYPE c LENGTH 1 . + types: "!

Event Name

"! Event name - ty_event_name TYPE c LENGTH 25. - TYPES: + ty_event_name TYPE c LENGTH 25 . + types: "!

Assigned Comparison

"! Assigned comparison BEGIN OF ty_assigned_comparison, @@ -359,13 +361,13 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_assigned_comparison. - TYPES: + END OF ty_assigned_comparison . + types: "!

Assign Checks and Comparison Type

"! Assign Checks and Comparison Type ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY - comparison_type check_id. - TYPES: + comparison_type check_id . + types: "!

Check Relevance

"! Define relevance of check BEGIN OF ty_check_relevance, @@ -380,13 +382,13 @@ INTERFACE zif_aff_edcc_v1 "!

Relevance

"! Relevance relevance TYPE ty_relevance, - END OF ty_check_relevance. - TYPES: + END OF ty_check_relevance . + types: "!

Check Relevance

"! Define relevance of checks ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY - comparison_type check_id. - TYPES: + comparison_type check_id . + types: "!

Assign Event

"! Assign event to consistency scenario BEGIN OF ty_event, @@ -399,51 +401,51 @@ INTERFACE zif_aff_edcc_v1 "!

Check Relevance

"! Define relevance of checks check_relevance TYPE ty_check_relevances, - END OF ty_event. - TYPES: + END OF ty_event . + types: "!

Assign Events

"! Assign events to consistency scenario - ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event. - TYPES: + ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event . + types: "!

Representation Type

"! Assign representation type associated with consistency scenario BEGIN OF ty_relationship_attribute, "!

Representation Type

"! Representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_relationship_attribute. - TYPES: + END OF ty_relationship_attribute . + types: "!

Representation Types

"! Assign representation types associated with consistency scenario ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY - representation_type. - TYPES: + representation_type . + types: "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario BEGIN OF ty_edoc_type, "!

eDocument Type

"! eDocument Type edoc_type TYPE c LENGTH 10, - END OF ty_edoc_type. - TYPES: + END OF ty_edoc_type . + types: "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario - ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. - TYPES: + ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type . + types: "!

Inconsistency Category

"! Inconsistency category - ty_resultgroup TYPE c LENGTH 20. - TYPES: + ty_resultgroup TYPE c LENGTH 20 . + types: "!

Result Process

"! Assign result process to the UI group BEGIN OF ty_results_process, result_process TYPE ty_result_process, - END OF ty_results_process. - TYPES: + END OF ty_results_process . + types: "!

Result Processes

"! Assign result process to the UI group - ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process. - TYPES: + ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process . + types: "!

Inconsistency Category

"! Inconsistency category BEGIN OF ty_inconsistency_category, @@ -456,33 +458,19 @@ INTERFACE zif_aff_edcc_v1 "!

Result Processes

"! Assign result process to the UI group result_process TYPE ty_result_processes, - END OF ty_inconsistency_category. - TYPES: + END OF ty_inconsistency_category . + types: "!

Inconsistency Categories

"! Inconsistency categories ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY - result_ui_group. - TYPES: + result_ui_group . + types: "!

Field Type

"! Field type "! $values {@link zif_aff_edcc_v1.data:co_field_type} "! $default {@link zif_aff_edcc_v1.data:co_field_type.select_options} - ty_field_type TYPE c LENGTH 1. - CONSTANTS: - "!

Field Type

- "! Field type - BEGIN OF co_field_type, - "!

Selection Option

- "! Selection option - select_options TYPE ty_field_type VALUE 'S', - "!

Parameter Single Value

- "! Parameter single value - parameter_single_value TYPE ty_field_type VALUE 'N', - "!

Parameter Multiple Values

- "! Parameter multiple values - parameter_multiple_values TYPE ty_field_type VALUE 'P', - END OF co_field_type. - TYPES: + ty_field_type TYPE c LENGTH 1 . + types: "!

Additional Selection Field

"! Additional selection fields of validation report BEGIN OF ty_additional_selection_field, @@ -495,13 +483,13 @@ INTERFACE zif_aff_edcc_v1 "!

Field Type

"! Field type field_type TYPE ty_field_type, - END OF ty_additional_selection_field. - TYPES: + END OF ty_additional_selection_field . + types: "!

Additional Selection Fields

"! Additional selection fields of validation report ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY - table_name field_name. - TYPES: + table_name field_name . + types: "!

Consistency Scenario

"! Consistency scenario BEGIN OF ty_main, @@ -542,9 +530,23 @@ INTERFACE zif_aff_edcc_v1 "! Inconsistency categories "! $required inconsistency_categories TYPE ty_inconsistency_categories, - END OF ty_main. + END OF ty_main . - CONSTANTS: + constants: + "!

Field Type

+ "! Field type + BEGIN OF co_field_type, + "!

Selection Option

+ "! Selection option + select_options TYPE ty_field_type VALUE 'S', + "!

Parameter Single Value

+ "! Parameter single value + parameter_single_value TYPE ty_field_type VALUE 'N', + "!

Parameter Multiple Values

+ "! Parameter multiple values + parameter_multiple_values TYPE ty_field_type VALUE 'P', + END OF co_field_type . + constants: "!

Check Formula

"! Formula applied to perform the content check on the field group BEGIN OF co_check_formula, @@ -557,8 +559,8 @@ INTERFACE zif_aff_edcc_v1 "!

Amount Comparison without Absolute Tolerance

"! Amount comparison without absolute tolerance field_without_abs_tolerance TYPE ty_check_formula VALUE '3', - END OF co_check_formula. - CONSTANTS: + END OF co_check_formula . + constants: "!

Field Group Level

"! Level of comparison field group BEGIN OF co_field_group_level, @@ -568,8 +570,8 @@ INTERFACE zif_aff_edcc_v1 "!

Item

"! Item item TYPE ty_field_group_level VALUE 'I', - END OF co_field_group_level. - CONSTANTS: + END OF co_field_group_level . + constants: "!

Filter Operation

"! Operand to build the where condition BEGIN OF co_filter_operation, @@ -579,8 +581,8 @@ INTERFACE zif_aff_edcc_v1 "!

Or

"! Or or TYPE ty_filter_operation VALUE 'OR', - END OF co_filter_operation. - CONSTANTS: + END OF co_filter_operation . + constants: "!

Expression Indicator

"! Expression indicator BEGIN OF co_expression, @@ -590,8 +592,8 @@ INTERFACE zif_aff_edcc_v1 "!

End of Expression

"! End of Eexpression end_of TYPE ty_expression_indicator VALUE '\', - END OF co_expression. - CONSTANTS: + END OF co_expression . + constants: "!

Comparison Operator

"! Comparison operator BEGIN OF co_compare_operation, @@ -601,8 +603,8 @@ INTERFACE zif_aff_edcc_v1 "!

Not Equal

"! Not Equal not_equal TYPE ty_comparison_operator VALUE '<>', - END OF co_compare_operation. - CONSTANTS: + END OF co_compare_operation . + constants: "!

Check Execution Control

"! Check execution control BEGIN OF co_execution_control, @@ -612,8 +614,8 @@ INTERFACE zif_aff_edcc_v1 "!

Proceed If No Inconsistency Identified From Previous Check

"! Proceed If No Inconsistency Identified From Previous Check no_proceed TYPE ty_execution_control VALUE '01', - END OF co_execution_control. - CONSTANTS: + END OF co_execution_control . + constants: "!

Relevance

"! Relevance BEGIN OF co_relevance, @@ -626,5 +628,5 @@ INTERFACE zif_aff_edcc_v1 "!

Unchanged

"! Unchanged unchanged TYPE ty_relevance VALUE 'U', - END OF co_relevance. -ENDINTERFACE. + END OF co_relevance . +endinterface. diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.json b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json index e432bd2a2..c5d786815 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.json +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.json @@ -1,7 +1,7 @@ { "formatVersion": "1", "header": { - "description": "AFF type for EDCC", + "description": "AFF type for EDCC (Consistency Scenario)", "originalLanguage": "en" } } From 6b72ee2db9d36b477f5771c731255e989f09d4c8 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 13:56:29 +0530 Subject: [PATCH 17/21] abap lint fix --- .../edcc/type/zif_aff_edcc_v1.intf.abap | 142 +++++++++--------- 1 file changed, 71 insertions(+), 71 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index d85e27467..946708300 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,12 +1,12 @@ -interface ZIF_AFF_EDCC_V1 - public . +INTERFACE zif_aff_edcc_v1 + PUBLIC . - types: + TYPES: "!

Description

"! Description ty_short_description TYPE c LENGTH 30 . - types: + TYPES: "!

Tax Authority Message Type

"! Tax authority message type BEGIN OF ty_message, @@ -19,11 +19,11 @@ interface ZIF_AFF_EDCC_V1 "! $required tax_authority_document_type TYPE c LENGTH 20, END OF ty_message . - types: + TYPES: "!

Tax Authority Message Types

"! Tax authority message types ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type . - types: + TYPES: "!

Additional Tax Authority Table

"! Additional tax authority table BEGIN OF ty_tax_authority_table, @@ -31,35 +31,35 @@ interface ZIF_AFF_EDCC_V1 "! Table name table_name TYPE zif_aff_types_v1=>ty_object_name_30, END OF ty_tax_authority_table . - types: + TYPES: "!

Additional Tax Authority Tables

"! Additional tax authority tables ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name . - types: + TYPES: "!

Position Number

"! Position number ty_position_number TYPE c LENGTH 2 . - types: + TYPES: "!

Result Process

"! Result process ty_result_process TYPE c LENGTH 10 . - types: + TYPES: "!

Field Value

"! Field value ty_field_value TYPE c LENGTH 40 . - types: + TYPES: "!

Sequence Number

"! Sequence number ty_sequence_number TYPE c LENGTH 3 . - types: + TYPES: "!

Check Number

"! Check number ty_check_number TYPE c LENGTH 5 . - types: + TYPES: "!

Description

"! Description ty_long_description TYPE c LENGTH 120 . - types: + TYPES: "!

Existence Check

"! Assigned existence check BEGIN OF ty_existence_check, @@ -76,7 +76,7 @@ interface ZIF_AFF_EDCC_V1 "! Result process result_process TYPE ty_result_process, END OF ty_existence_check . - types: + TYPES: "!

Status Check

"! Status check BEGIN OF ty_status_check, @@ -102,29 +102,29 @@ interface ZIF_AFF_EDCC_V1 "! Result process result_process TYPE ty_result_process, END OF ty_status_check . - types: + TYPES: "!

Status Checks

"! Assigned status checks ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number . - types: + TYPES: "!

Mismatch Field Group

"! Comparison field group for mismatched fields ty_field_group TYPE c LENGTH 20 . - types: + TYPES: "!

Field Group Level

"! Level of comparison field group "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} ty_field_group_level TYPE c LENGTH 1 . - types: + TYPES: ty_comparison_sequence TYPE c LENGTH 5 . - types: + TYPES: "!

Check Formula

"! Formula applied to perform the content check on the field group "! $values {@link zif_aff_edcc_v1.data:co_check_formula} "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} ty_check_formula TYPE c LENGTH 1 . - types: + TYPES: "!

Comparison Field Name

"! Field Names whose values will be compared BEGIN OF ty_comparison_field, @@ -138,11 +138,11 @@ interface ZIF_AFF_EDCC_V1 "! Comparison sequence comparison_sequence TYPE ty_comparison_sequence, END OF ty_comparison_field . - types: + TYPES: "!

Comparison Field Name

"! Field Names whose values will be compared ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type . - types: + TYPES: "!

Comparison Field Group

"! Comparison field group BEGIN OF ty_comparison_field_group, @@ -165,12 +165,12 @@ interface ZIF_AFF_EDCC_V1 "! Field Names whose values will be compared comparison_field TYPE ty_comparison_fields, END OF ty_comparison_field_group . - types: + TYPES: "!

Comparison Field Groups

"! Comparison field groups ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group WITH UNIQUE KEY field_group . - types: + TYPES: "!

Content Check

"! Content check BEGIN OF ty_content_check, @@ -190,33 +190,33 @@ interface ZIF_AFF_EDCC_V1 "! Comparison field groups content_comparison_field_group TYPE ty_comparison_field_groups, END OF ty_content_check . - types: + TYPES: "!

Content Checks

"! Assigned content checks ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number . - types: + TYPES: "!

Filter Operation

"! Operand to build the where condition "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} ty_filter_operation TYPE c LENGTH 3 . - types: + TYPES: "!

Comparison Operator

"! Comparison operator "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} ty_comparison_operator TYPE c LENGTH 3 . - types: + TYPES: "!

Filter Field Value

"! Value used to build the where condition ty_filter_value TYPE c LENGTH 30 . - types: + TYPES: "!

Expression Indicator

"! Expression indicator "! $values {@link zif_aff_edcc_v1.data:co_expression} "! $default {@link zif_aff_edcc_v1.data:co_expression.begin_of} ty_expression_indicator TYPE c LENGTH 3 . - types: + TYPES: "!

Selection Filters on Check

"! Selection filters on check BEGIN OF ty_check_filter, @@ -239,25 +239,25 @@ interface ZIF_AFF_EDCC_V1 "! Expression indicator expression_indicator TYPE ty_expression_indicator, END OF ty_check_filter . - types: + TYPES: "!

Selection Filters on Check

"! Selection filters on check ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number . - types: + TYPES: "!

Position Number

"! Position number ty_check_position_number TYPE c LENGTH 3 . - types: + TYPES: "!

Check Execution Sequence

"! Check execution sequence ty_execution_sequence TYPE c LENGTH 3 . - types: + TYPES: "!

Check Execution Control

"! Check execution control "! $values {@link zif_aff_edcc_v1.data:co_execution_control} "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} ty_execution_control TYPE c LENGTH 2 . - types: + TYPES: "!

Check Attribute

"! Check attribute BEGIN OF ty_check_attribute, @@ -277,11 +277,11 @@ interface ZIF_AFF_EDCC_V1 "! Selection filters on check check_filter TYPE ty_check_filters, END OF ty_check_attribute . - types: + TYPES: "!

Check Attributes

"! Check attributes ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id . - types: + TYPES: "!

Representation Type

"! Assigned representation type BEGIN OF ty_representation_type, @@ -289,12 +289,12 @@ interface ZIF_AFF_EDCC_V1 "! Assigned representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, END OF ty_representation_type . - types: + TYPES: "!

Representation Types

"! Assigned representation types ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY representation_type . - types: + TYPES: "!

Comparison Type

"! Comparison type BEGIN OF ty_comparison_type, @@ -337,21 +337,21 @@ interface ZIF_AFF_EDCC_V1 "! $required representation_types TYPE ty_representation_types, END OF ty_comparison_type . - types: + TYPES: "!

Comparison Types

"! Define comparison types ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type . - types: + TYPES: "!

Relevance

"! Relevance "! $values {@link zif_aff_edcc_v1.data:co_relevance} "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} ty_relevance TYPE c LENGTH 1 . - types: + TYPES: "!

Event Name

"! Event name ty_event_name TYPE c LENGTH 25 . - types: + TYPES: "!

Assigned Comparison

"! Assigned comparison BEGIN OF ty_assigned_comparison, @@ -362,12 +362,12 @@ interface ZIF_AFF_EDCC_V1 "! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, END OF ty_assigned_comparison . - types: + TYPES: "!

Assign Checks and Comparison Type

"! Assign Checks and Comparison Type ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY comparison_type check_id . - types: + TYPES: "!

Check Relevance

"! Define relevance of check BEGIN OF ty_check_relevance, @@ -383,12 +383,12 @@ interface ZIF_AFF_EDCC_V1 "! Relevance relevance TYPE ty_relevance, END OF ty_check_relevance . - types: + TYPES: "!

Check Relevance

"! Define relevance of checks ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY comparison_type check_id . - types: + TYPES: "!

Assign Event

"! Assign event to consistency scenario BEGIN OF ty_event, @@ -402,11 +402,11 @@ interface ZIF_AFF_EDCC_V1 "! Define relevance of checks check_relevance TYPE ty_check_relevances, END OF ty_event . - types: + TYPES: "!

Assign Events

"! Assign events to consistency scenario ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event . - types: + TYPES: "!

Representation Type

"! Assign representation type associated with consistency scenario BEGIN OF ty_relationship_attribute, @@ -414,12 +414,12 @@ interface ZIF_AFF_EDCC_V1 "! Representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, END OF ty_relationship_attribute . - types: + TYPES: "!

Representation Types

"! Assign representation types associated with consistency scenario ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY representation_type . - types: + TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario BEGIN OF ty_edoc_type, @@ -427,25 +427,25 @@ interface ZIF_AFF_EDCC_V1 "! eDocument Type edoc_type TYPE c LENGTH 10, END OF ty_edoc_type . - types: + TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type . - types: + TYPES: "!

Inconsistency Category

"! Inconsistency category ty_resultgroup TYPE c LENGTH 20 . - types: + TYPES: "!

Result Process

"! Assign result process to the UI group BEGIN OF ty_results_process, result_process TYPE ty_result_process, END OF ty_results_process . - types: + TYPES: "!

Result Processes

"! Assign result process to the UI group ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process . - types: + TYPES: "!

Inconsistency Category

"! Inconsistency category BEGIN OF ty_inconsistency_category, @@ -459,18 +459,18 @@ interface ZIF_AFF_EDCC_V1 "! Assign result process to the UI group result_process TYPE ty_result_processes, END OF ty_inconsistency_category . - types: + TYPES: "!

Inconsistency Categories

"! Inconsistency categories ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY result_ui_group . - types: + TYPES: "!

Field Type

"! Field type "! $values {@link zif_aff_edcc_v1.data:co_field_type} "! $default {@link zif_aff_edcc_v1.data:co_field_type.select_options} ty_field_type TYPE c LENGTH 1 . - types: + TYPES: "!

Additional Selection Field

"! Additional selection fields of validation report BEGIN OF ty_additional_selection_field, @@ -484,12 +484,12 @@ interface ZIF_AFF_EDCC_V1 "! Field type field_type TYPE ty_field_type, END OF ty_additional_selection_field . - types: + TYPES: "!

Additional Selection Fields

"! Additional selection fields of validation report ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY table_name field_name . - types: + TYPES: "!

Consistency Scenario

"! Consistency scenario BEGIN OF ty_main, @@ -532,7 +532,7 @@ interface ZIF_AFF_EDCC_V1 inconsistency_categories TYPE ty_inconsistency_categories, END OF ty_main . - constants: + CONSTANTS: "!

Field Type

"! Field type BEGIN OF co_field_type, @@ -546,7 +546,7 @@ interface ZIF_AFF_EDCC_V1 "! Parameter multiple values parameter_multiple_values TYPE ty_field_type VALUE 'P', END OF co_field_type . - constants: + CONSTANTS: "!

Check Formula

"! Formula applied to perform the content check on the field group BEGIN OF co_check_formula, @@ -560,7 +560,7 @@ interface ZIF_AFF_EDCC_V1 "! Amount comparison without absolute tolerance field_without_abs_tolerance TYPE ty_check_formula VALUE '3', END OF co_check_formula . - constants: + CONSTANTS: "!

Field Group Level

"! Level of comparison field group BEGIN OF co_field_group_level, @@ -571,7 +571,7 @@ interface ZIF_AFF_EDCC_V1 "! Item item TYPE ty_field_group_level VALUE 'I', END OF co_field_group_level . - constants: + CONSTANTS: "!

Filter Operation

"! Operand to build the where condition BEGIN OF co_filter_operation, @@ -582,7 +582,7 @@ interface ZIF_AFF_EDCC_V1 "! Or or TYPE ty_filter_operation VALUE 'OR', END OF co_filter_operation . - constants: + CONSTANTS: "!

Expression Indicator

"! Expression indicator BEGIN OF co_expression, @@ -593,7 +593,7 @@ interface ZIF_AFF_EDCC_V1 "! End of Eexpression end_of TYPE ty_expression_indicator VALUE '\', END OF co_expression . - constants: + CONSTANTS: "!

Comparison Operator

"! Comparison operator BEGIN OF co_compare_operation, @@ -604,7 +604,7 @@ interface ZIF_AFF_EDCC_V1 "! Not Equal not_equal TYPE ty_comparison_operator VALUE '<>', END OF co_compare_operation . - constants: + CONSTANTS: "!

Check Execution Control

"! Check execution control BEGIN OF co_execution_control, @@ -615,7 +615,7 @@ interface ZIF_AFF_EDCC_V1 "! Proceed If No Inconsistency Identified From Previous Check no_proceed TYPE ty_execution_control VALUE '01', END OF co_execution_control . - constants: + CONSTANTS: "!

Relevance

"! Relevance BEGIN OF co_relevance, @@ -629,4 +629,4 @@ interface ZIF_AFF_EDCC_V1 "! Unchanged unchanged TYPE ty_relevance VALUE 'U', END OF co_relevance . -endinterface. +ENDINTERFACE. From a438a336d2681c23f8da53f2852d2e17c1cebf00 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 14:14:51 +0530 Subject: [PATCH 18/21] corrections to abap_lint --- .../edcc/type/zif_aff_edcc_v1.intf.abap | 380 ++++++++---------- 1 file changed, 168 insertions(+), 212 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 946708300..3b1251e8a 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -1,11 +1,10 @@ INTERFACE zif_aff_edcc_v1 - PUBLIC . + PUBLIC. - TYPES: - "!

Description

- "! Description - ty_short_description TYPE c LENGTH 30 . + "!

Description

+ "! Description + TYPES ty_short_description TYPE c LENGTH 30. TYPES: "!

Tax Authority Message Type

"! Tax authority message type @@ -18,11 +17,10 @@ INTERFACE zif_aff_edcc_v1 "! Tax authority document type "! $required tax_authority_document_type TYPE c LENGTH 20, - END OF ty_message . - TYPES: - "!

Tax Authority Message Types

- "! Tax authority message types - ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type . + END OF ty_message. + "!

Tax Authority Message Types

+ "! Tax authority message types + TYPES ty_messages TYPE SORTED TABLE OF ty_message WITH UNIQUE KEY message_type. TYPES: "!

Additional Tax Authority Table

"! Additional tax authority table @@ -30,35 +28,28 @@ INTERFACE zif_aff_edcc_v1 "!

Table Name

"! Table name table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_tax_authority_table . - TYPES: - "!

Additional Tax Authority Tables

- "! Additional tax authority tables - ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name . - TYPES: - "!

Position Number

- "! Position number - ty_position_number TYPE c LENGTH 2 . - TYPES: - "!

Result Process

- "! Result process - ty_result_process TYPE c LENGTH 10 . - TYPES: - "!

Field Value

- "! Field value - ty_field_value TYPE c LENGTH 40 . - TYPES: - "!

Sequence Number

- "! Sequence number - ty_sequence_number TYPE c LENGTH 3 . - TYPES: - "!

Check Number

- "! Check number - ty_check_number TYPE c LENGTH 5 . - TYPES: - "!

Description

- "! Description - ty_long_description TYPE c LENGTH 120 . + END OF ty_tax_authority_table. + "!

Additional Tax Authority Tables

+ "! Additional tax authority tables + TYPES ty_tax_authority_tables TYPE SORTED TABLE OF ty_tax_authority_table WITH UNIQUE KEY table_name. + "!

Position Number

+ "! Position number + TYPES ty_position_number TYPE c LENGTH 2. + "!

Result Process

+ "! Result process + TYPES ty_result_process TYPE c LENGTH 10. + "!

Field Value

+ "! Field value + TYPES ty_field_value TYPE c LENGTH 40. + "!

Sequence Number

+ "! Sequence number + TYPES ty_sequence_number TYPE c LENGTH 3. + "!

Check Number

+ "! Check number + TYPES ty_check_number TYPE c LENGTH 5. + "!

Description

+ "! Description + TYPES ty_long_description TYPE c LENGTH 120. TYPES: "!

Existence Check

"! Assigned existence check @@ -75,7 +66,7 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_existence_check . + END OF ty_existence_check. TYPES: "!

Status Check

"! Status check @@ -101,29 +92,24 @@ INTERFACE zif_aff_edcc_v1 "!

Result Process

"! Result process result_process TYPE ty_result_process, - END OF ty_status_check . - TYPES: - "!

Status Checks

- "! Assigned status checks - ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number . - TYPES: - "!

Mismatch Field Group

- "! Comparison field group for mismatched fields - ty_field_group TYPE c LENGTH 20 . - TYPES: - "!

Field Group Level

- "! Level of comparison field group - "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} - "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} - ty_field_group_level TYPE c LENGTH 1 . - TYPES: - ty_comparison_sequence TYPE c LENGTH 5 . - TYPES: - "!

Check Formula

- "! Formula applied to perform the content check on the field group - "! $values {@link zif_aff_edcc_v1.data:co_check_formula} - "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} - ty_check_formula TYPE c LENGTH 1 . + END OF ty_status_check. + "!

Status Checks

+ "! Assigned status checks + TYPES ty_status_checks TYPE SORTED TABLE OF ty_status_check WITH UNIQUE KEY check_id sequence_number. + "!

Mismatch Field Group

+ "! Comparison field group for mismatched fields + TYPES ty_field_group TYPE c LENGTH 20. + "!

Field Group Level

+ "! Level of comparison field group + "! $values {@link zif_aff_edcc_v1.data:co_field_group_level} + "! $default {@link zif_aff_edcc_v1.data:co_field_group_level.header} + TYPES ty_field_group_level TYPE c LENGTH 1. + TYPES ty_comparison_sequence TYPE c LENGTH 5. + "!

Check Formula

+ "! Formula applied to perform the content check on the field group + "! $values {@link zif_aff_edcc_v1.data:co_check_formula} + "! $default {@link zif_aff_edcc_v1.data:co_check_formula.field} + TYPES ty_check_formula TYPE c LENGTH 1. TYPES: "!

Comparison Field Name

"! Field Names whose values will be compared @@ -137,11 +123,10 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Sequence

"! Comparison sequence comparison_sequence TYPE ty_comparison_sequence, - END OF ty_comparison_field . - TYPES: - "!

Comparison Field Name

- "! Field Names whose values will be compared - ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type . + END OF ty_comparison_field. + "!

Comparison Field Name

+ "! Field Names whose values will be compared + TYPES ty_comparison_fields TYPE SORTED TABLE OF ty_comparison_field WITH UNIQUE KEY representation_type. TYPES: "!

Comparison Field Group

"! Comparison field group @@ -164,12 +149,10 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Name

"! Field Names whose values will be compared comparison_field TYPE ty_comparison_fields, - END OF ty_comparison_field_group . - TYPES: - "!

Comparison Field Groups

- "! Comparison field groups - ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group - WITH UNIQUE KEY field_group . + END OF ty_comparison_field_group. + "!

Comparison Field Groups

+ "! Comparison field groups + TYPES ty_comparison_field_groups TYPE SORTED TABLE OF ty_comparison_field_group WITH UNIQUE KEY field_group. TYPES: "!

Content Check

"! Content check @@ -189,33 +172,28 @@ INTERFACE zif_aff_edcc_v1 "!

Comparison Field Groups

"! Comparison field groups content_comparison_field_group TYPE ty_comparison_field_groups, - END OF ty_content_check . - TYPES: - "!

Content Checks

- "! Assigned content checks - ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number . - TYPES: - "!

Filter Operation

- "! Operand to build the where condition - "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} - "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} - ty_filter_operation TYPE c LENGTH 3 . - TYPES: - "!

Comparison Operator

- "! Comparison operator - "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} - "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} - ty_comparison_operator TYPE c LENGTH 3 . - TYPES: - "!

Filter Field Value

- "! Value used to build the where condition - ty_filter_value TYPE c LENGTH 30 . - TYPES: - "!

Expression Indicator

- "! Expression indicator - "! $values {@link zif_aff_edcc_v1.data:co_expression} - "! $default {@link zif_aff_edcc_v1.data:co_expression.begin_of} - ty_expression_indicator TYPE c LENGTH 3 . + END OF ty_content_check. + "!

Content Checks

+ "! Assigned content checks + TYPES ty_content_checks TYPE SORTED TABLE OF ty_content_check WITH UNIQUE KEY check_id check_number. + "!

Filter Operation

+ "! Operand to build the where condition + "! $values {@link zif_aff_edcc_v1.data:co_filter_operation} + "! $default {@link zif_aff_edcc_v1.data:co_filter_operation.and} + TYPES ty_filter_operation TYPE c LENGTH 3. + "!

Comparison Operator

+ "! Comparison operator + "! $values {@link zif_aff_edcc_v1.data:co_compare_operation} + "! $default {@link zif_aff_edcc_v1.data:co_compare_operation.equal} + TYPES ty_comparison_operator TYPE c LENGTH 3. + "!

Filter Field Value

+ "! Value used to build the where condition + TYPES ty_filter_value TYPE c LENGTH 30. + "!

Expression Indicator

+ "! Expression indicator + "! $values {@link zif_aff_edcc_v1.data:co_expression} + "! $default {@link zif_aff_edcc_v1.data:co_expression.begin_of} + TYPES ty_expression_indicator TYPE c LENGTH 3. TYPES: "!

Selection Filters on Check

"! Selection filters on check @@ -238,25 +216,21 @@ INTERFACE zif_aff_edcc_v1 "!

Expression Indicator

"! Expression indicator expression_indicator TYPE ty_expression_indicator, - END OF ty_check_filter . - TYPES: - "!

Selection Filters on Check

- "! Selection filters on check - ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number . - TYPES: - "!

Position Number

- "! Position number - ty_check_position_number TYPE c LENGTH 3 . - TYPES: - "!

Check Execution Sequence

- "! Check execution sequence - ty_execution_sequence TYPE c LENGTH 3 . - TYPES: - "!

Check Execution Control

- "! Check execution control - "! $values {@link zif_aff_edcc_v1.data:co_execution_control} - "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} - ty_execution_control TYPE c LENGTH 2 . + END OF ty_check_filter. + "!

Selection Filters on Check

+ "! Selection filters on check + TYPES ty_check_filters TYPE SORTED TABLE OF ty_check_filter WITH UNIQUE KEY sequence_number. + "!

Position Number

+ "! Position number + TYPES ty_check_position_number TYPE c LENGTH 3. + "!

Check Execution Sequence

+ "! Check execution sequence + TYPES ty_execution_sequence TYPE c LENGTH 3. + "!

Check Execution Control

+ "! Check execution control + "! $values {@link zif_aff_edcc_v1.data:co_execution_control} + "! $default {@link zif_aff_edcc_v1.data:co_execution_control.proceed} + TYPES ty_execution_control TYPE c LENGTH 2. TYPES: "!

Check Attribute

"! Check attribute @@ -276,11 +250,10 @@ INTERFACE zif_aff_edcc_v1 "!

Selection Filters on Check

"! Selection filters on check check_filter TYPE ty_check_filters, - END OF ty_check_attribute . - TYPES: - "!

Check Attributes

- "! Check attributes - ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id . + END OF ty_check_attribute. + "!

Check Attributes

+ "! Check attributes + TYPES ty_check_attributes TYPE SORTED TABLE OF ty_check_attribute WITH UNIQUE KEY check_id. TYPES: "!

Representation Type

"! Assigned representation type @@ -288,12 +261,10 @@ INTERFACE zif_aff_edcc_v1 "!

Assigned Representation Type

"! Assigned representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_representation_type . - TYPES: - "!

Representation Types

- "! Assigned representation types - ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY - representation_type . + END OF ty_representation_type. + "!

Representation Types

+ "! Assigned representation types + TYPES ty_representation_types TYPE SORTED TABLE OF ty_representation_type WITH UNIQUE KEY representation_type. TYPES: "!

Comparison Type

"! Comparison type @@ -336,21 +307,18 @@ INTERFACE zif_aff_edcc_v1 "! Assigned representation types "! $required representation_types TYPE ty_representation_types, - END OF ty_comparison_type . - TYPES: - "!

Comparison Types

- "! Define comparison types - ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type . - TYPES: - "!

Relevance

- "! Relevance - "! $values {@link zif_aff_edcc_v1.data:co_relevance} - "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} - ty_relevance TYPE c LENGTH 1 . - TYPES: - "!

Event Name

- "! Event name - ty_event_name TYPE c LENGTH 25 . + END OF ty_comparison_type. + "!

Comparison Types

+ "! Define comparison types + TYPES ty_comparison_types TYPE SORTED TABLE OF ty_comparison_type WITH UNIQUE KEY comparison_type. + "!

Relevance

+ "! Relevance + "! $values {@link zif_aff_edcc_v1.data:co_relevance} + "! $default {@link zif_aff_edcc_v1.data:co_relevance.unchanged} + TYPES ty_relevance TYPE c LENGTH 1. + "!

Event Name

+ "! Event name + TYPES ty_event_name TYPE c LENGTH 25. TYPES: "!

Assigned Comparison

"! Assigned comparison @@ -361,12 +329,11 @@ INTERFACE zif_aff_edcc_v1 "!

Check Id

"! Check id check_id TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_assigned_comparison . - TYPES: - "!

Assign Checks and Comparison Type

- "! Assign Checks and Comparison Type - ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY - comparison_type check_id . + END OF ty_assigned_comparison. + "!

Assign Checks and Comparison Type

+ "! Assign Checks and Comparison Type + TYPES ty_assigned_comparisons TYPE SORTED TABLE OF ty_assigned_comparison WITH UNIQUE KEY + comparison_type check_id. TYPES: "!

Check Relevance

"! Define relevance of check @@ -382,12 +349,11 @@ INTERFACE zif_aff_edcc_v1 "!

Relevance

"! Relevance relevance TYPE ty_relevance, - END OF ty_check_relevance . - TYPES: - "!

Check Relevance

- "! Define relevance of checks - ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY - comparison_type check_id . + END OF ty_check_relevance. + "!

Check Relevance

+ "! Define relevance of checks + TYPES ty_check_relevances TYPE SORTED TABLE OF ty_check_relevance WITH UNIQUE KEY + comparison_type check_id. TYPES: "!

Assign Event

"! Assign event to consistency scenario @@ -401,11 +367,10 @@ INTERFACE zif_aff_edcc_v1 "!

Check Relevance

"! Define relevance of checks check_relevance TYPE ty_check_relevances, - END OF ty_event . - TYPES: - "!

Assign Events

- "! Assign events to consistency scenario - ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event . + END OF ty_event. + "!

Assign Events

+ "! Assign events to consistency scenario + TYPES ty_events TYPE SORTED TABLE OF ty_event WITH UNIQUE KEY event. TYPES: "!

Representation Type

"! Assign representation type associated with consistency scenario @@ -413,12 +378,10 @@ INTERFACE zif_aff_edcc_v1 "!

Representation Type

"! Representation type representation_type TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_relationship_attribute . - TYPES: - "!

Representation Types

- "! Assign representation types associated with consistency scenario - ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY - representation_type . + END OF ty_relationship_attribute. + "!

Representation Types

+ "! Assign representation types associated with consistency scenario + TYPES ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY representation_type. TYPES: "!

eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario @@ -426,25 +389,22 @@ INTERFACE zif_aff_edcc_v1 "!

eDocument Type

"! eDocument Type edoc_type TYPE c LENGTH 10, - END OF ty_edoc_type . - TYPES: - "!

eDocument Type Assignment

- "! Assign eDocument types associated with consistency scenario - ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type . - TYPES: - "!

Inconsistency Category

- "! Inconsistency category - ty_resultgroup TYPE c LENGTH 20 . + END OF ty_edoc_type. + "!

eDocument Type Assignment

+ "! Assign eDocument types associated with consistency scenario + TYPES ty_edoc_types TYPE SORTED TABLE OF ty_edoc_type WITH UNIQUE KEY edoc_type. + "!

Inconsistency Category

+ "! Inconsistency category + TYPES ty_resultgroup TYPE c LENGTH 20. TYPES: "!

Result Process

"! Assign result process to the UI group BEGIN OF ty_results_process, result_process TYPE ty_result_process, - END OF ty_results_process . - TYPES: - "!

Result Processes

- "! Assign result process to the UI group - ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process . + END OF ty_results_process. + "!

Result Processes

+ "! Assign result process to the UI group + TYPES ty_result_processes TYPE SORTED TABLE OF ty_results_process WITH UNIQUE KEY result_process. TYPES: "!

Inconsistency Category

"! Inconsistency category @@ -458,18 +418,15 @@ INTERFACE zif_aff_edcc_v1 "!

Result Processes

"! Assign result process to the UI group result_process TYPE ty_result_processes, - END OF ty_inconsistency_category . - TYPES: - "!

Inconsistency Categories

- "! Inconsistency categories - ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY - result_ui_group . - TYPES: - "!

Field Type

- "! Field type - "! $values {@link zif_aff_edcc_v1.data:co_field_type} - "! $default {@link zif_aff_edcc_v1.data:co_field_type.select_options} - ty_field_type TYPE c LENGTH 1 . + END OF ty_inconsistency_category. + "!

Inconsistency Categories

+ "! Inconsistency categories + TYPES ty_inconsistency_categories TYPE SORTED TABLE OF ty_inconsistency_category WITH UNIQUE KEY result_ui_group. + "!

Field Type

+ "! Field type + "! $values {@link zif_aff_edcc_v1.data:co_field_type} + "! $default {@link zif_aff_edcc_v1.data:co_field_type.select_options} + TYPES ty_field_type TYPE c LENGTH 1. TYPES: "!

Additional Selection Field

"! Additional selection fields of validation report @@ -483,12 +440,11 @@ INTERFACE zif_aff_edcc_v1 "!

Field Type

"! Field type field_type TYPE ty_field_type, - END OF ty_additional_selection_field . - TYPES: - "!

Additional Selection Fields

- "! Additional selection fields of validation report - ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY - table_name field_name . + END OF ty_additional_selection_field. + "!

Additional Selection Fields

+ "! Additional selection fields of validation report + TYPES ty_additional_selection_fields TYPE SORTED TABLE OF ty_additional_selection_field WITH UNIQUE KEY + table_name field_name. TYPES: "!

Consistency Scenario

"! Consistency scenario @@ -530,7 +486,7 @@ INTERFACE zif_aff_edcc_v1 "! Inconsistency categories "! $required inconsistency_categories TYPE ty_inconsistency_categories, - END OF ty_main . + END OF ty_main. CONSTANTS: "!

Field Type

@@ -545,7 +501,7 @@ INTERFACE zif_aff_edcc_v1 "!

Parameter Multiple Values

"! Parameter multiple values parameter_multiple_values TYPE ty_field_type VALUE 'P', - END OF co_field_type . + END OF co_field_type. CONSTANTS: "!

Check Formula

"! Formula applied to perform the content check on the field group @@ -559,7 +515,7 @@ INTERFACE zif_aff_edcc_v1 "!

Amount Comparison without Absolute Tolerance

"! Amount comparison without absolute tolerance field_without_abs_tolerance TYPE ty_check_formula VALUE '3', - END OF co_check_formula . + END OF co_check_formula. CONSTANTS: "!

Field Group Level

"! Level of comparison field group @@ -570,7 +526,7 @@ INTERFACE zif_aff_edcc_v1 "!

Item

"! Item item TYPE ty_field_group_level VALUE 'I', - END OF co_field_group_level . + END OF co_field_group_level. CONSTANTS: "!

Filter Operation

"! Operand to build the where condition @@ -581,7 +537,7 @@ INTERFACE zif_aff_edcc_v1 "!

Or

"! Or or TYPE ty_filter_operation VALUE 'OR', - END OF co_filter_operation . + END OF co_filter_operation. CONSTANTS: "!

Expression Indicator

"! Expression indicator @@ -592,7 +548,7 @@ INTERFACE zif_aff_edcc_v1 "!

End of Expression

"! End of Eexpression end_of TYPE ty_expression_indicator VALUE '\', - END OF co_expression . + END OF co_expression. CONSTANTS: "!

Comparison Operator

"! Comparison operator @@ -603,18 +559,18 @@ INTERFACE zif_aff_edcc_v1 "!

Not Equal

"! Not Equal not_equal TYPE ty_comparison_operator VALUE '<>', - END OF co_compare_operation . + END OF co_compare_operation. CONSTANTS: "!

Check Execution Control

"! Check execution control BEGIN OF co_execution_control, "!

No Check

"! Proceed with check even when inconsistency is identified - proceed TYPE ty_execution_control VALUE '00', + proceed TYPE ty_execution_control VALUE '00', "!

Proceed If No Inconsistency Identified From Previous Check

"! Proceed If No Inconsistency Identified From Previous Check - no_proceed TYPE ty_execution_control VALUE '01', - END OF co_execution_control . + no_proceed TYPE ty_execution_control VALUE '01', + END OF co_execution_control. CONSTANTS: "!

Relevance

"! Relevance @@ -628,5 +584,5 @@ INTERFACE zif_aff_edcc_v1 "!

Unchanged

"! Unchanged unchanged TYPE ty_relevance VALUE 'U', - END OF co_relevance . + END OF co_relevance. ENDINTERFACE. From 026ebceb6efccabc742835f681c5b5f3ceaf4e6a Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 16:53:11 +0530 Subject: [PATCH 19/21] Commit to older comments --- file-formats/edcc/type/zif_aff_edcc_v1.intf.abap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 3b1251e8a..92c9aa20a 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -79,16 +79,16 @@ INTERFACE zif_aff_edcc_v1 sequence_number TYPE ty_sequence_number, "!

Source Field Name 1

"! Source field name 1 - source_field_name1 TYPE zif_aff_types_v1=>ty_object_name_30, + source_field_name_1 TYPE zif_aff_types_v1=>ty_object_name_30, "!

Source Field Value 1

"! Source field value 1 - source_field_value1 TYPE ty_field_value, + source_field_value_1 TYPE ty_field_value, "!

Source Field Name 2

"! Source field name 2 - source_field_name2 TYPE zif_aff_types_v1=>ty_object_name_30, + source_field_name_2 TYPE zif_aff_types_v1=>ty_object_name_30, "!

Source Field Value 2

"! Source field value 2 - source_field_value2 TYPE ty_field_value, + source_field_value_2 TYPE ty_field_value, "!

Result Process

"! Result process result_process TYPE ty_result_process, From 1bddfdaf8f5a2ad0d849c158a61a545fa51ba03e Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 16:56:14 +0530 Subject: [PATCH 20/21] commit to abap lint From 2f6621a252562f177baa08924a308eeb53c11232 Mon Sep 17 00:00:00 2001 From: KUMARMUKULSAP Date: Thu, 24 Oct 2024 17:02:09 +0530 Subject: [PATCH 21/21] abap_lint fix --- file-formats/edcc/type/zif_aff_edcc_v1.intf.abap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap index 92c9aa20a..d8a32fe70 100644 --- a/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap +++ b/file-formats/edcc/type/zif_aff_edcc_v1.intf.abap @@ -73,10 +73,10 @@ INTERFACE zif_aff_edcc_v1 BEGIN OF ty_status_check, "!

Check Id

"! Check id - check_id TYPE zif_aff_types_v1=>ty_object_name_30, + check_id TYPE zif_aff_types_v1=>ty_object_name_30, "!

Sequence Number

"! Sequence number - sequence_number TYPE ty_sequence_number, + sequence_number TYPE ty_sequence_number, "!

Source Field Name 1

"! Source field name 1 source_field_name_1 TYPE zif_aff_types_v1=>ty_object_name_30, @@ -91,7 +91,7 @@ INTERFACE zif_aff_edcc_v1 source_field_value_2 TYPE ty_field_value, "!

Result Process

"! Result process - result_process TYPE ty_result_process, + result_process TYPE ty_result_process, END OF ty_status_check. "!

Status Checks

"! Assigned status checks