Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 [HCPSDKFIORIUIKIT-2685] FilterFormView Refactor #981

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

hengyi-zhang
Copy link
Collaborator

No description provided.

@@ -2,8 +2,12 @@ import FioriSwiftUICore
import SwiftUI

struct TextFieldFormViewExample: View {
// var key1: AttributedString {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented codes to be deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code cleanup

@hengyi-zhang hengyi-zhang requested a review from dyongxu February 14, 2025 02:06
@hengyi-zhang
Copy link
Collaborator Author

code cleanup

fixed

@hengyi-zhang hengyi-zhang force-pushed the refactor/FilterFormView branch from cff56fa to a28b710 Compare February 14, 2025 07:59
@hengyi-zhang hengyi-zhang force-pushed the refactor/FilterFormView branch from a28b710 to 3f8c78c Compare February 14, 2025 08:07
@dyongxu dyongxu merged commit 00a82cf into SAP:main Feb 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants