Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 [HCPSDKFIORIUIKIT-2891]FilterFeedbackbar FilterForm #988

Merged

Conversation

restaurantt
Copy link
Collaborator

@restaurantt restaurantt commented Feb 21, 2025

Replace old view by FilterFormView

…o main-HCPSDKFIORIUIKIT-2891-FilterFormView

# Conflicts:
#	Sources/FioriSwiftUICore/Views/OptionListPickerItem+View.swift
#	Sources/FioriSwiftUICore/_generated/ViewModels/API/OptionListPickerItem+API.generated.swift
@restaurantt restaurantt requested a review from a team as a code owner February 21, 2025 09:47
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team February 21, 2025 09:47
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API doc change

Copy link

cla-assistant bot commented Feb 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ restaurantt
✅ dyongxu
❌ Gu, Jiajun (external - Project)


Gu, Jiajun (external - Project) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@restaurantt restaurantt requested a review from dyongxu February 25, 2025 01:17
@zzchao-1999 zzchao-1999 self-requested a review February 26, 2025 03:28
@dyongxu dyongxu merged commit 864c7eb into SAP:main Feb 26, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants