From 33f1ec53df317788fbf136db9eab4088fc144ab9 Mon Sep 17 00:00:00 2001 From: fundamental-bot Date: Tue, 7 Jan 2025 15:09:31 +0000 Subject: [PATCH 1/5] chore(release): publish 0.54.2-rc.2 [ci skip] --- CHANGELOG.md | 11 +++++++++++ lerna.json | 2 +- libs/btp/CHANGELOG.md | 8 ++++++++ libs/btp/package.json | 2 +- libs/cdk/CHANGELOG.md | 8 ++++++++ libs/cdk/package.json | 2 +- libs/core/CHANGELOG.md | 8 ++++++++ libs/core/package.json | 2 +- libs/cx/CHANGELOG.md | 8 ++++++++ libs/cx/package.json | 2 +- libs/datetime-adapter/CHANGELOG.md | 8 ++++++++ libs/datetime-adapter/package.json | 2 +- libs/i18n/CHANGELOG.md | 8 ++++++++ libs/i18n/package.json | 2 +- libs/moment-adapter/CHANGELOG.md | 8 ++++++++ libs/moment-adapter/package.json | 2 +- libs/nx-plugin/CHANGELOG.md | 8 ++++++++ libs/nx-plugin/package.json | 2 +- libs/platform/CHANGELOG.md | 11 +++++++++++ libs/platform/package.json | 2 +- 20 files changed, 96 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 44180e036e8..48dedea3cbc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + + +### Features + +* **platform:** fdp table - make responsive pop-in areas navigable ([#12673](https://github.com/SAP/fundamental-ngx/issues/12673)) ([38cf776](https://github.com/SAP/fundamental-ngx/commit/38cf776b498e1b4facffeb96ddd014f05536d549)), closes [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) diff --git a/lerna.json b/lerna.json index d966937bc0d..3f1fabeb54c 100644 --- a/lerna.json +++ b/lerna.json @@ -1,7 +1,7 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "packages": ["libs/*"], - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "conventionalCommits": true, "tagVersionPrefix": "v", "message": "chore(release): publish %v", diff --git a/libs/btp/CHANGELOG.md b/libs/btp/CHANGELOG.md index 2898662a736..bf080591e00 100644 --- a/libs/btp/CHANGELOG.md +++ b/libs/btp/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/btp + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/btp diff --git a/libs/btp/package.json b/libs/btp/package.json index 3160a49f441..fe8c6ca8b0f 100644 --- a/libs/btp/package.json +++ b/libs/btp/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/btp", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "peerDependencies": { "@angular/common": "ANGULAR_VER_PLACEHOLDER", "@angular/core": "ANGULAR_VER_PLACEHOLDER", diff --git a/libs/cdk/CHANGELOG.md b/libs/cdk/CHANGELOG.md index f577ca5ae81..1d45691b04a 100644 --- a/libs/cdk/CHANGELOG.md +++ b/libs/cdk/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/cdk + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/cdk diff --git a/libs/cdk/package.json b/libs/cdk/package.json index 7e77f8fdac1..ec2e98672ec 100644 --- a/libs/cdk/package.json +++ b/libs/cdk/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/cdk", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - CDK", "license": "Apache-2.0", diff --git a/libs/core/CHANGELOG.md b/libs/core/CHANGELOG.md index ca6fc8811b3..3c12172e881 100644 --- a/libs/core/CHANGELOG.md +++ b/libs/core/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/core + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) diff --git a/libs/core/package.json b/libs/core/package.json index 8e2a329fdb5..26d4a297e29 100644 --- a/libs/core/package.json +++ b/libs/core/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/core", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "schematics": "./schematics/collection.json", "ng-update": { "migrations": "./schematics/migrations.json" diff --git a/libs/cx/CHANGELOG.md b/libs/cx/CHANGELOG.md index ffd6c34ba5c..f6859760d95 100644 --- a/libs/cx/CHANGELOG.md +++ b/libs/cx/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/cx + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/cx diff --git a/libs/cx/package.json b/libs/cx/package.json index 19b44533d57..e6c72838d1b 100644 --- a/libs/cx/package.json +++ b/libs/cx/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/cx", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - cx", "license": "Apache-2.0", diff --git a/libs/datetime-adapter/CHANGELOG.md b/libs/datetime-adapter/CHANGELOG.md index 9a292f17aed..1435f894b47 100644 --- a/libs/datetime-adapter/CHANGELOG.md +++ b/libs/datetime-adapter/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/datetime-adapter + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/datetime-adapter diff --git a/libs/datetime-adapter/package.json b/libs/datetime-adapter/package.json index 24381e91e43..9dc27494fae 100644 --- a/libs/datetime-adapter/package.json +++ b/libs/datetime-adapter/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/datetime-adapter", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "description": "Datetime adapter for SAP Fundamentals, based on Day.js package", "license": "Apache-2.0", "homepage": "https://sap.github.io/fundamental-ngx/home", diff --git a/libs/i18n/CHANGELOG.md b/libs/i18n/CHANGELOG.md index 0be9b1a6a98..54a69a2d578 100644 --- a/libs/i18n/CHANGELOG.md +++ b/libs/i18n/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/i18n + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/i18n diff --git a/libs/i18n/package.json b/libs/i18n/package.json index 5c006324616..698a79bfc39 100644 --- a/libs/i18n/package.json +++ b/libs/i18n/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/i18n", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "peerDependencies": { "@angular/common": "ANGULAR_VER_PLACEHOLDER", "@angular/core": "ANGULAR_VER_PLACEHOLDER", diff --git a/libs/moment-adapter/CHANGELOG.md b/libs/moment-adapter/CHANGELOG.md index bde3d5d3f45..94a46972a58 100644 --- a/libs/moment-adapter/CHANGELOG.md +++ b/libs/moment-adapter/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/moment-adapter + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/moment-adapter diff --git a/libs/moment-adapter/package.json b/libs/moment-adapter/package.json index b6c98321a8e..c8de4f2a3b3 100644 --- a/libs/moment-adapter/package.json +++ b/libs/moment-adapter/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/moment-adapter", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "description": "Datetime adapter for SAP Fundamentals, based on Moment.js package", "license": "Apache-2.0", "homepage": "https://sap.github.io/fundamental-ngx/home", diff --git a/libs/nx-plugin/CHANGELOG.md b/libs/nx-plugin/CHANGELOG.md index 69136bad393..f64aa6e11fe 100644 --- a/libs/nx-plugin/CHANGELOG.md +++ b/libs/nx-plugin/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + +**Note:** Version bump only for package @fundamental-ngx/nx-plugin + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/nx-plugin diff --git a/libs/nx-plugin/package.json b/libs/nx-plugin/package.json index 16f06509c8c..7ed3758cdfb 100644 --- a/libs/nx-plugin/package.json +++ b/libs/nx-plugin/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/nx-plugin", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "main": "src/index.js", "generators": "./generators.json", "executors": "./executors.json", diff --git a/libs/platform/CHANGELOG.md b/libs/platform/CHANGELOG.md index 45bb0589bf8..d17efa9ff84 100644 --- a/libs/platform/CHANGELOG.md +++ b/libs/platform/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) + + +### Features + +* **platform:** fdp table - make responsive pop-in areas navigable ([#12673](https://github.com/SAP/fundamental-ngx/issues/12673)) ([38cf776](https://github.com/SAP/fundamental-ngx/commit/38cf776b498e1b4facffeb96ddd014f05536d549)), closes [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) [#11004](https://github.com/SAP/fundamental-ngx/issues/11004) + + + + + ## [0.54.2-rc.1](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.0...v0.54.2-rc.1) (2024-12-30) **Note:** Version bump only for package @fundamental-ngx/platform diff --git a/libs/platform/package.json b/libs/platform/package.json index b47a0fa196d..c3f5e4f2905 100644 --- a/libs/platform/package.json +++ b/libs/platform/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/platform", - "version": "0.54.2-rc.1", + "version": "0.54.2-rc.2", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - platform", "license": "Apache-2.0", From 31526492811f383425dc3cde9c31de4625dd34c3 Mon Sep 17 00:00:00 2001 From: Mike O'Donnell Date: Tue, 7 Jan 2025 11:40:29 -0500 Subject: [PATCH 2/5] fix(platform): add configuration options to truncate titles and descriptions in the settings generator (#12811) * fix(platform): add configuration options to truncate titles and descriptions in the settings generator * fix: default should truncate, add option for wrap --------- Co-authored-by: deno --- ...-generator-custom-control-example.component.ts | 15 ++++++++++++--- ...ttings-generator-sidebar-layout.component.html | 4 ++-- .../settings-generator/models/settings.model.ts | 12 +++++++++--- .../settings-generator-content.component.html | 2 +- 4 files changed, 24 insertions(+), 9 deletions(-) diff --git a/libs/docs/platform/settings-generator/examples/custom-control/settings-generator-custom-control-example.component.ts b/libs/docs/platform/settings-generator/examples/custom-control/settings-generator-custom-control-example.component.ts index cb83a419ac1..093d777037b 100644 --- a/libs/docs/platform/settings-generator/examples/custom-control/settings-generator-custom-control-example.component.ts +++ b/libs/docs/platform/settings-generator/examples/custom-control/settings-generator-custom-control-example.component.ts @@ -82,10 +82,18 @@ export class SettingsGeneratorCustomControlExampleComponent { this._formGeneratorService.addComponent(PlatformFormGeneratorCustomSliderElementComponent, ['slider']); this.schema = { appearance: 'sidebar', - sidebarWidth: '20rem', + sidebarWidth: { + minWidth: '20rem', + width: '20rem', + maxWidth: '20rem', + wrapSidebarTitle: true, + wrapSidebarDescription: true + }, items: [ { - title: 'First list item', + title: 'First list item with long title text that wraps rather than truncates at certain screen sizes due to custom properties in the sidebar configuration', + description: + 'This is an example of a description with long text that wraps rather than truncates due to custom properties in the sidebar width configuration', id: 'sliderExample', thumbnail: { icon: { @@ -111,7 +119,8 @@ export class SettingsGeneratorCustomControlExampleComponent { showTicksLabels: true } } - ] + ], + wrapSectionTitle: true } ] }; diff --git a/libs/platform/settings-generator/layouts/settings-generator-sidebar-layout/settings-generator-sidebar-layout.component.html b/libs/platform/settings-generator/layouts/settings-generator-sidebar-layout/settings-generator-sidebar-layout.component.html index 7eae609e963..b9202e45332 100644 --- a/libs/platform/settings-generator/layouts/settings-generator-sidebar-layout/settings-generator-sidebar-layout.component.html +++ b/libs/platform/settings-generator/layouts/settings-generator-sidebar-layout/settings-generator-sidebar-layout.component.html @@ -39,7 +39,7 @@

}
@if (item.title | fdkAsyncOrSync; as titleValue) { -
{{ titleValue }}
+
{{ titleValue }}
} @else {
} @if (item.description) { -
+
@if (item.description | fdkAsyncOrSync; as descriptionValue) { {{ descriptionValue }} } @else { diff --git a/libs/platform/settings-generator/models/settings.model.ts b/libs/platform/settings-generator/models/settings.model.ts index 09331051aa2..c0ab0ae27b0 100644 --- a/libs/platform/settings-generator/models/settings.model.ts +++ b/libs/platform/settings-generator/models/settings.model.ts @@ -72,6 +72,8 @@ export interface BaseSettingsItem { description?: FdkAsyncProperty; /** Settings section title. */ sectionTitle?: FdkAsyncProperty; + /** Whether to wrap the title text in the main section content. By default, the text will be truncated. */ + wrapSectionTitle?: boolean; } export interface IconBaseSettingsItem { @@ -141,9 +143,13 @@ export interface GroupedTemplateSettingsItem extends BaseSettingsItem { export interface SidebarWidthConfiguration { /** Min width. */ - minWidth: string; + minWidth?: string; /** Max width. */ - maxWidth: string; + maxWidth?: string; /** Width. */ - width: string; + width?: string; + /** Whether to wrap the title text in the sidebar. By default, the text will truncate. */ + wrapSidebarTitle?: boolean; + /** Whether to wrap the description text in the sidebar. By default, the text will truncate. */ + wrapSidebarDescription?: boolean; } diff --git a/libs/platform/settings-generator/settings-generator-content/settings-generator-content.component.html b/libs/platform/settings-generator/settings-generator-content/settings-generator-content.component.html index 34ab72afeab..1bb7622c2f0 100644 --- a/libs/platform/settings-generator/settings-generator-content/settings-generator-content.component.html +++ b/libs/platform/settings-generator/settings-generator-content/settings-generator-content.component.html @@ -1,4 +1,4 @@ -

+

@if (mobile) { } From 26fd691e14e8b8e609cd2e554074fdb4c195a537 Mon Sep 17 00:00:00 2001 From: Mike O'Donnell Date: Wed, 8 Jan 2025 14:37:06 -0500 Subject: [PATCH 3/5] fix(core): combobox communicateByObject bugs (#12815) * fix(core): only trigger onChange when matching object is found * fix(core): fix bug where selecting item via click would not properly select if there are matching displayed names * fix(core): fix match object via typing and unit tests --- libs/core/combobox/combobox.component.spec.ts | 19 ++++++++++++++----- libs/core/combobox/combobox.component.ts | 5 ++++- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/libs/core/combobox/combobox.component.spec.ts b/libs/core/combobox/combobox.component.spec.ts index 6ec63592162..e2d233b37de 100644 --- a/libs/core/combobox/combobox.component.spec.ts +++ b/libs/core/combobox/combobox.component.spec.ts @@ -79,7 +79,6 @@ describe('ComboboxComponent', () => { it('should handle wrong input entry on dropdown mode', () => { jest.spyOn(component, 'onChange'); - component.communicateByObject = true; component.displayFn = (item: any): string => { if (item) { return item.displayedValue; @@ -91,6 +90,20 @@ describe('ComboboxComponent', () => { expect(component.onChange).toHaveBeenCalledWith('otherDisplayedValue'); }); + it('should not call onChange when using wrong input entry on dropdown mode with communicateByObject', () => { + jest.spyOn(component, 'onChange'); + component.communicateByObject = true; + component.displayFn = (item: any): string => { + if (item) { + return item.displayedValue; + } else { + return ''; + } + }; + component.inputText = 'otherDisplayedValue'; + expect(component.onChange).not.toHaveBeenCalled(); + }); + it('should handle write value from outside on dropdown mode', () => { component.communicateByObject = true; component.displayFn = (item: any): string => item.displayedValue; @@ -342,8 +355,6 @@ describe('ComboboxComponent', () => { component.displayFn = (product: Product): string => product?.name ?? ''; - component.communicateByObject = true; - component.dropdownValues = allProducts; component.groupFn = (products: Product[]) => { @@ -369,8 +380,6 @@ describe('ComboboxComponent', () => { component.displayFn = (product: Product): string => product?.name ?? ''; - component.communicateByObject = true; - component.dropdownValues = allProducts; component.groupFn = (products: Product[]) => { diff --git a/libs/core/combobox/combobox.component.ts b/libs/core/combobox/combobox.component.ts index dbc811394d8..7df3d90fe79 100644 --- a/libs/core/combobox/combobox.component.ts +++ b/libs/core/combobox/combobox.component.ts @@ -829,7 +829,10 @@ export class ComboboxComponent } else if (values.length === 0) { this.setValue(this.inputText); } - this.onChange(this.getValue()); + const thisValue = this.getValue(); + if (typeof thisValue === 'object') { + this.onChange(thisValue); + } } else { this.onChange(this.inputText); } From b908419673a8422c1140e3d0110a176a1a1985db Mon Sep 17 00:00:00 2001 From: Mike O'Donnell Date: Wed, 8 Jan 2025 15:43:55 -0500 Subject: [PATCH 4/5] fix(core,platform): add input to list item to prevent click selection. fix issue with toggling column on p13 dialog (#12878) --- .../list/list-item/list-item.component.ts | 25 ++++++++++++------- .../columns/columns.component.html | 1 + 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/libs/core/list/list-item/list-item.component.ts b/libs/core/list/list-item/list-item.component.ts index b96cda6048d..b6aeb747afe 100644 --- a/libs/core/list/list-item/list-item.component.ts +++ b/libs/core/list/list-item/list-item.component.ts @@ -113,6 +113,11 @@ export class ListItemComponent extends ListFocusItem implements Afte @Input() id: Nullable = 'fd-list-item-' + ++listItemUniqueId; + /** Whether to prevent built-in click event logic on the list item. + * Helpful when using lists with checkboxes or radio buttons when the list item should be clickable, but should not select/deselect the list item. */ + @Input() + preventClick = false; + /** @hidden Implementation of KeyboardSupportItemInterface | TODO Revisit KeyboardSupportItemInterface*/ @Output() keyDown: EventEmitter = new EventEmitter(); @@ -229,16 +234,18 @@ export class ListItemComponent extends ListFocusItem implements Afte /** Handler for mouse events */ @HostListener('click', ['$event']) onClick(event: MouseEvent): void { - this._clicked$.next(event); - if (this.checkbox && !this.link) { - if (!this.checkbox.elementRef.nativeElement.contains(event.target as Node)) { - // clicking on the checkbox is not suppressed - // so we should only process clicks if clicked on the list-item, not checkbox itself - this.checkbox.nextValue(); + if (!this.preventClick) { + this._clicked$.next(event); + if (this.checkbox && !this.link) { + if (!this.checkbox.elementRef.nativeElement.contains(event.target as Node)) { + // clicking on the checkbox is not suppressed + // so we should only process clicks if clicked on the list-item, not checkbox itself + this.checkbox.nextValue(); + } + } + if (this.radio && !this.link) { + this.radio.labelClicked(event, false); } - } - if (this.radio && !this.link) { - this.radio.labelClicked(event, false); } } diff --git a/libs/platform/table/components/table-p13-dialog/columns/columns.component.html b/libs/platform/table/components/table-p13-dialog/columns/columns.component.html index 48e8d82c8d9..0dcbcc2f5cd 100644 --- a/libs/platform/table/components/table-p13-dialog/columns/columns.component.html +++ b/libs/platform/table/components/table-p13-dialog/columns/columns.component.html @@ -59,6 +59,7 @@

@for (item of _filteredColumns; track _filterByColumnKy($index, item)) {
  • Date: Wed, 8 Jan 2025 20:46:05 +0000 Subject: [PATCH 5/5] chore(release): publish 0.54.2-rc.3 [ci skip] --- CHANGELOG.md | 13 +++++++++++++ lerna.json | 2 +- libs/btp/CHANGELOG.md | 8 ++++++++ libs/btp/package.json | 2 +- libs/cdk/CHANGELOG.md | 8 ++++++++ libs/cdk/package.json | 2 +- libs/core/CHANGELOG.md | 12 ++++++++++++ libs/core/package.json | 2 +- libs/cx/CHANGELOG.md | 8 ++++++++ libs/cx/package.json | 2 +- libs/datetime-adapter/CHANGELOG.md | 8 ++++++++ libs/datetime-adapter/package.json | 2 +- libs/i18n/CHANGELOG.md | 8 ++++++++ libs/i18n/package.json | 2 +- libs/moment-adapter/CHANGELOG.md | 8 ++++++++ libs/moment-adapter/package.json | 2 +- libs/nx-plugin/CHANGELOG.md | 8 ++++++++ libs/nx-plugin/package.json | 2 +- libs/platform/CHANGELOG.md | 12 ++++++++++++ libs/platform/package.json | 2 +- 20 files changed, 103 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 48dedea3cbc..4095326f2b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,19 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + + +### Bug Fixes + +* **core,platform:** add input to list item to prevent click selection. fix issue with toggling column on p13 dialog ([#12878](https://github.com/SAP/fundamental-ngx/issues/12878)) ([b908419](https://github.com/SAP/fundamental-ngx/commit/b908419673a8422c1140e3d0110a176a1a1985db)) +* **core:** combobox communicateByObject bugs ([#12815](https://github.com/SAP/fundamental-ngx/issues/12815)) ([26fd691](https://github.com/SAP/fundamental-ngx/commit/26fd691e14e8b8e609cd2e554074fdb4c195a537)) +* **platform:** add configuration options to truncate titles and descriptions in the settings generator ([#12811](https://github.com/SAP/fundamental-ngx/issues/12811)) ([3152649](https://github.com/SAP/fundamental-ngx/commit/31526492811f383425dc3cde9c31de4625dd34c3)) + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) diff --git a/lerna.json b/lerna.json index 3f1fabeb54c..5173c7f5174 100644 --- a/lerna.json +++ b/lerna.json @@ -1,7 +1,7 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "packages": ["libs/*"], - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "conventionalCommits": true, "tagVersionPrefix": "v", "message": "chore(release): publish %v", diff --git a/libs/btp/CHANGELOG.md b/libs/btp/CHANGELOG.md index bf080591e00..4e1989be8f2 100644 --- a/libs/btp/CHANGELOG.md +++ b/libs/btp/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/btp + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/btp diff --git a/libs/btp/package.json b/libs/btp/package.json index fe8c6ca8b0f..0ab94550b96 100644 --- a/libs/btp/package.json +++ b/libs/btp/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/btp", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "peerDependencies": { "@angular/common": "ANGULAR_VER_PLACEHOLDER", "@angular/core": "ANGULAR_VER_PLACEHOLDER", diff --git a/libs/cdk/CHANGELOG.md b/libs/cdk/CHANGELOG.md index 1d45691b04a..55cfdd745c2 100644 --- a/libs/cdk/CHANGELOG.md +++ b/libs/cdk/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/cdk + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/cdk diff --git a/libs/cdk/package.json b/libs/cdk/package.json index ec2e98672ec..6905f296c23 100644 --- a/libs/cdk/package.json +++ b/libs/cdk/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/cdk", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - CDK", "license": "Apache-2.0", diff --git a/libs/core/CHANGELOG.md b/libs/core/CHANGELOG.md index 3c12172e881..6b381ae922e 100644 --- a/libs/core/CHANGELOG.md +++ b/libs/core/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + + +### Bug Fixes + +* **core,platform:** add input to list item to prevent click selection. fix issue with toggling column on p13 dialog ([#12878](https://github.com/SAP/fundamental-ngx/issues/12878)) ([b908419](https://github.com/SAP/fundamental-ngx/commit/b908419673a8422c1140e3d0110a176a1a1985db)) +* **core:** combobox communicateByObject bugs ([#12815](https://github.com/SAP/fundamental-ngx/issues/12815)) ([26fd691](https://github.com/SAP/fundamental-ngx/commit/26fd691e14e8b8e609cd2e554074fdb4c195a537)) + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/core diff --git a/libs/core/package.json b/libs/core/package.json index 26d4a297e29..3cdd6840097 100644 --- a/libs/core/package.json +++ b/libs/core/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/core", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "schematics": "./schematics/collection.json", "ng-update": { "migrations": "./schematics/migrations.json" diff --git a/libs/cx/CHANGELOG.md b/libs/cx/CHANGELOG.md index f6859760d95..c399e99a9f4 100644 --- a/libs/cx/CHANGELOG.md +++ b/libs/cx/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/cx + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/cx diff --git a/libs/cx/package.json b/libs/cx/package.json index e6c72838d1b..905a1a26d66 100644 --- a/libs/cx/package.json +++ b/libs/cx/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/cx", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - cx", "license": "Apache-2.0", diff --git a/libs/datetime-adapter/CHANGELOG.md b/libs/datetime-adapter/CHANGELOG.md index 1435f894b47..b2e0a9b71b7 100644 --- a/libs/datetime-adapter/CHANGELOG.md +++ b/libs/datetime-adapter/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/datetime-adapter + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/datetime-adapter diff --git a/libs/datetime-adapter/package.json b/libs/datetime-adapter/package.json index 9dc27494fae..e16da4a94c4 100644 --- a/libs/datetime-adapter/package.json +++ b/libs/datetime-adapter/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/datetime-adapter", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "description": "Datetime adapter for SAP Fundamentals, based on Day.js package", "license": "Apache-2.0", "homepage": "https://sap.github.io/fundamental-ngx/home", diff --git a/libs/i18n/CHANGELOG.md b/libs/i18n/CHANGELOG.md index 54a69a2d578..af59168eca2 100644 --- a/libs/i18n/CHANGELOG.md +++ b/libs/i18n/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/i18n + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/i18n diff --git a/libs/i18n/package.json b/libs/i18n/package.json index 698a79bfc39..532e1ef60e6 100644 --- a/libs/i18n/package.json +++ b/libs/i18n/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/i18n", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "peerDependencies": { "@angular/common": "ANGULAR_VER_PLACEHOLDER", "@angular/core": "ANGULAR_VER_PLACEHOLDER", diff --git a/libs/moment-adapter/CHANGELOG.md b/libs/moment-adapter/CHANGELOG.md index 94a46972a58..628518108ff 100644 --- a/libs/moment-adapter/CHANGELOG.md +++ b/libs/moment-adapter/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/moment-adapter + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/moment-adapter diff --git a/libs/moment-adapter/package.json b/libs/moment-adapter/package.json index c8de4f2a3b3..82b2168fe05 100644 --- a/libs/moment-adapter/package.json +++ b/libs/moment-adapter/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/moment-adapter", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "description": "Datetime adapter for SAP Fundamentals, based on Moment.js package", "license": "Apache-2.0", "homepage": "https://sap.github.io/fundamental-ngx/home", diff --git a/libs/nx-plugin/CHANGELOG.md b/libs/nx-plugin/CHANGELOG.md index f64aa6e11fe..3a7c7068815 100644 --- a/libs/nx-plugin/CHANGELOG.md +++ b/libs/nx-plugin/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + +**Note:** Version bump only for package @fundamental-ngx/nx-plugin + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) **Note:** Version bump only for package @fundamental-ngx/nx-plugin diff --git a/libs/nx-plugin/package.json b/libs/nx-plugin/package.json index 7ed3758cdfb..4d91e3b27dd 100644 --- a/libs/nx-plugin/package.json +++ b/libs/nx-plugin/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/nx-plugin", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "main": "src/index.js", "generators": "./generators.json", "executors": "./executors.json", diff --git a/libs/platform/CHANGELOG.md b/libs/platform/CHANGELOG.md index d17efa9ff84..368410c526a 100644 --- a/libs/platform/CHANGELOG.md +++ b/libs/platform/CHANGELOG.md @@ -3,6 +3,18 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.54.2-rc.3](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.2...v0.54.2-rc.3) (2025-01-08) + + +### Bug Fixes + +* **core,platform:** add input to list item to prevent click selection. fix issue with toggling column on p13 dialog ([#12878](https://github.com/SAP/fundamental-ngx/issues/12878)) ([b908419](https://github.com/SAP/fundamental-ngx/commit/b908419673a8422c1140e3d0110a176a1a1985db)) +* **platform:** add configuration options to truncate titles and descriptions in the settings generator ([#12811](https://github.com/SAP/fundamental-ngx/issues/12811)) ([3152649](https://github.com/SAP/fundamental-ngx/commit/31526492811f383425dc3cde9c31de4625dd34c3)) + + + + + ## [0.54.2-rc.2](https://github.com/SAP/fundamental-ngx/compare/v0.54.2-rc.1...v0.54.2-rc.2) (2025-01-07) diff --git a/libs/platform/package.json b/libs/platform/package.json index c3f5e4f2905..c7235b9fedd 100644 --- a/libs/platform/package.json +++ b/libs/platform/package.json @@ -1,6 +1,6 @@ { "name": "@fundamental-ngx/platform", - "version": "0.54.2-rc.2", + "version": "0.54.2-rc.3", "schematics": "./schematics/collection.json", "description": "Fundamental Library for Angular - platform", "license": "Apache-2.0",