Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question/Documentation - preview-middleware: How to disable LocalStorage as Flexibility Service #2805

Open
1 of 4 tasks
Kyrodan opened this issue Jan 22, 2025 · 3 comments
Open
1 of 4 tasks
Assignees
Labels
preview-middleware @sap-ux/preview-middleware

Comments

@Kyrodan
Copy link

Kyrodan commented Jan 22, 2025

Issue Description

The Preview-FLP uses LocalStorageConnector for Customer and User layer. How can this be avoided and instead use the LRep-Service from a NetWeaver Backend?
From the flp.html I can see, that the Backend-LRep is queried but not for Customer and User Layer. So the results are not used for Table Personalization/Table Variants:

data-sap-ui-flexibilityServices='[{"connector":"LrepConnector","layers":[],"url":"/sap/bc/lrep"},{"applyConnector":"custom.connectors.WorkspaceConnector","writeConnector":"custom.connectors.WorkspaceConnector","custom":true},{"connector":"LocalStorageConnector","layers":["CUSTOMER","USER"]}]'

Issue Type

  • Documentation is unclear
  • Documentation is incorrect
  • Documentation is missing
  • Other
@tobiasqueck tobiasqueck added the preview-middleware @sap-ux/preview-middleware label Jan 24, 2025
@heimwege heimwege self-assigned this Jan 27, 2025
@heimwege
Copy link
Contributor

Hey @Kyrodan, could you please elaborate the use case a little bit? Why do you want to use a remote lrep for the local preview of an app during development?

@Kyrodan
Copy link
Author

Kyrodan commented Jan 27, 2025

Hi @heimwege

thanks for your reply.

I have these cases:

  1. There is a pending bug-report BUG - preview-middleware: enableFakeConnector throws exception on saving a table variant #2804 from me in enableFakeConnector: currently Table Variants (p13n) could not be saved, so I don't haver a working Variant Management in development.
  2. A development team is sharing it's table variants. With LocalStorageConnector only everyone has to create it's own table p13n - that's much more work.
  3. LocalStorageConnector: the data is bound to a specific browser type/instance; you cannot test the same variant in several browsers.
  4. Sometimes we have to dig into problems regarding table variants: without the exact variant of the source system it's hard to analyze/debug such kind of problems

@heimwege
Copy link
Contributor

Hey @Kyrodan,

Thanks for sharing all the use cases.

A fix for 1. will be provided in #2832.

I think the other ones are valid as well but I'm, afraid the priority working on those will be rather low.
But the benefit of having the code of this middleware open source is that we very welcome contributions. So if you want these use cases to be supported rather sooner than later, feel free to have a look at our contributions howTo document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

No branches or pull requests

3 participants