diff --git a/src/linter/json/ManifestLinter.ts b/src/linter/json/ManifestLinter.ts index b93104ff2..a0cab52bb 100644 --- a/src/linter/json/ManifestLinter.ts +++ b/src/linter/json/ManifestLinter.ts @@ -20,19 +20,22 @@ interface locType { const deprecatedLibraries: string[] = [ "sap.ca.scfld.md", "sap.ca.ui", - "sap.dragonfly", - "sap.landviz", + "sap.fe.common", // Internal, removed in 1.110 + "sap.fe.plugins", // Internal, removed in 1.102 + "sap.fe.semantics", // Internal, removed in 1.104 + "sap.landvisz", // Removed in 1.120 "sap.makit", "sap.me", + "sap.sac.grid", // Removed in 1.114 "sap.ui.commons", "sap.ui.suite", "sap.ui.ux3", "sap.ui.vtm", "sap.uiext.inbox", "sap.webanalytics.core", - "sap.zen.dsh", "sap.zen.commons", "sap.zen.crosstab", + "sap.zen.dsh", ]; const deprecatedComponents: string[] = [ diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/manifest.json b/test/fixtures/linter/rules/NoDeprecatedApi/manifest.json index d948cbe38..3236d55b2 100644 --- a/test/fixtures/linter/rules/NoDeprecatedApi/manifest.json +++ b/test/fixtures/linter/rules/NoDeprecatedApi/manifest.json @@ -43,22 +43,25 @@ "minUI5Version": "1.119.0", "libs": { "sap.ui.core": {}, - "sap.m": {}, + "sap.m": {}, "sap.ca.scfld.md": {}, "sap.ca.ui": {}, - "sap.dragonfly": {}, - "sap.landviz": {}, + "sap.fe.common": {}, + "sap.fe.plugins": {}, + "sap.fe.semantics": {}, + "sap.landvisz": {}, "sap.makit": {}, "sap.me": {}, + "sap.sac.grid": {}, "sap.ui.commons": {}, "sap.ui.suite": {}, "sap.ui.ux3": {}, "sap.ui.vtm": {}, "sap.uiext.inbox": {}, "sap.webanalytics.core": {}, - "sap.zen.dsh": {}, "sap.zen.commons": {}, - "sap.zen.crosstab": {} + "sap.zen.crosstab": {}, + "sap.zen.dsh": {} }, "components": { "sap.zen.dsh.fioriwrapper": {} diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md index b8dc00165..12c97140b 100644 --- a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md +++ b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md @@ -795,7 +795,7 @@ Generated by [AVA](https://avajs.dev). [ { coverageInfo: [], - errorCount: 20, + errorCount: 23, fatalErrorCount: 0, filePath: 'manifest.json', messages: [ @@ -819,7 +819,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 49, - message: 'Use of deprecated library \'sap.dragonfly\'', + message: 'Use of deprecated library \'sap.fe.common\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -827,7 +827,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 50, - message: 'Use of deprecated library \'sap.landviz\'', + message: 'Use of deprecated library \'sap.fe.plugins\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -835,7 +835,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 51, - message: 'Use of deprecated library \'sap.makit\'', + message: 'Use of deprecated library \'sap.fe.semantics\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -843,7 +843,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 52, - message: 'Use of deprecated library \'sap.me\'', + message: 'Use of deprecated library \'sap.landvisz\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -851,7 +851,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 53, - message: 'Use of deprecated library \'sap.ui.commons\'', + message: 'Use of deprecated library \'sap.makit\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -859,7 +859,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 54, - message: 'Use of deprecated library \'sap.ui.suite\'', + message: 'Use of deprecated library \'sap.me\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -867,7 +867,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 55, - message: 'Use of deprecated library \'sap.ui.ux3\'', + message: 'Use of deprecated library \'sap.sac.grid\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -875,7 +875,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 56, - message: 'Use of deprecated library \'sap.ui.vtm\'', + message: 'Use of deprecated library \'sap.ui.commons\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -883,7 +883,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 57, - message: 'Use of deprecated library \'sap.uiext.inbox\'', + message: 'Use of deprecated library \'sap.ui.suite\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -891,7 +891,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 58, - message: 'Use of deprecated library \'sap.webanalytics.core\'', + message: 'Use of deprecated library \'sap.ui.ux3\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -899,7 +899,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 59, - message: 'Use of deprecated library \'sap.zen.dsh\'', + message: 'Use of deprecated library \'sap.ui.vtm\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -907,7 +907,7 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 60, - message: 'Use of deprecated library \'sap.zen.commons\'', + message: 'Use of deprecated library \'sap.uiext.inbox\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, }, @@ -915,6 +915,22 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 61, + message: 'Use of deprecated library \'sap.webanalytics.core\'', + ruleId: 'ui5-linter-no-deprecated-library', + severity: 2, + }, + { + column: 17, + fatal: undefined, + line: 62, + message: 'Use of deprecated library \'sap.zen.commons\'', + ruleId: 'ui5-linter-no-deprecated-library', + severity: 2, + }, + { + column: 17, + fatal: undefined, + line: 63, message: 'Use of deprecated library \'sap.zen.crosstab\'', ruleId: 'ui5-linter-no-deprecated-library', severity: 2, @@ -923,6 +939,14 @@ Generated by [AVA](https://avajs.dev). column: 17, fatal: undefined, line: 64, + message: 'Use of deprecated library \'sap.zen.dsh\'', + ruleId: 'ui5-linter-no-deprecated-library', + severity: 2, + }, + { + column: 17, + fatal: undefined, + line: 67, message: 'Use of deprecated component \'sap.zen.dsh.fioriwrapper\'', ruleId: 'ui5-linter-no-deprecated-component', severity: 2, @@ -930,7 +954,7 @@ Generated by [AVA](https://avajs.dev). { column: 13, fatal: undefined, - line: 76, + line: 79, message: 'Use of deprecated property \'sap.ui5/resources/js\'', ruleId: 'ui5-linter-no-deprecated-api', severity: 2, @@ -938,7 +962,7 @@ Generated by [AVA](https://avajs.dev). { column: 21, fatal: undefined, - line: 89, + line: 92, message: 'Use of deprecated property \'sap.ui5/models/odata-v4/settings/synchronizationMode\' of sap.ui.model.odata.v4.ODataModel', ruleId: 'ui5-linter-no-deprecated-api', severity: 2, @@ -946,7 +970,7 @@ Generated by [AVA](https://avajs.dev). { column: 21, fatal: undefined, - line: 95, + line: 98, message: 'Use of deprecated property \'sap.ui5/models/odata-v4-via-dataSource/settings/synchronizationMode\' of sap.ui.model.odata.v4.ODataModel', ruleId: 'ui5-linter-no-deprecated-api', severity: 2, @@ -954,7 +978,7 @@ Generated by [AVA](https://avajs.dev). { column: 17, fatal: undefined, - line: 99, + line: 102, message: 'Use of deprecated model type \'sap.ui5/models/odata/type="sap.ui.model.odata.ODataModel"\'', ruleId: 'ui5-linter-no-deprecated-api', severity: 2, diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap index 0051e45c0..212108067 100644 Binary files a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap and b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap differ