diff --git a/test/fixtures/linter/rules/BestPractices/Negative_7/Component.js b/test/fixtures/linter/rules/BestPractices/Negative_7/Component.js new file mode 100644 index 000000000..110f10e4a --- /dev/null +++ b/test/fixtures/linter/rules/BestPractices/Negative_7/Component.js @@ -0,0 +1,9 @@ +sap.ui.define(["sap/fe/core/AppComponent"], function (AppComponent) { + "use strict"; + + return AppComponent.extend("mycomp.Component", { + metadata: { + manifest: "json", + }, + }); +}); diff --git a/test/fixtures/linter/rules/BestPractices/Negative_7/manifest.json b/test/fixtures/linter/rules/BestPractices/Negative_7/manifest.json new file mode 100644 index 000000000..63a4fffc3 --- /dev/null +++ b/test/fixtures/linter/rules/BestPractices/Negative_7/manifest.json @@ -0,0 +1,45 @@ +{ + "_version": "1.12.0", + + "sap.app": { + "id": "mycomp", + "type": "application", + "i18n": "i18n/i18n.properties", + "title": "{{appTitle}}", + "description": "{{appDescription}}", + "applicationVersion": { + "version": "1.0.0" + } + }, + + "sap.ui5": { + "rootView": { + "viewName": "mycomp.view.App", + "type": "XML", + "id": "app" + }, + + "routing": { + "config": { + "routerClass": "sap.m.routing.Router", + "viewType": "XML", + "viewPath": "mycomp.view", + "controlId": "app", + "controlAggregation": "pages" + }, + "routes": [ + { + "pattern": "", + "name": "main", + "target": "main" + } + ], + "targets": { + "main": { + "viewId": "main", + "viewName": "Main" + } + } + } + } +} diff --git a/test/lib/linter/rules/snapshots/BestPractices.ts.md b/test/lib/linter/rules/snapshots/BestPractices.ts.md index 6fd4ab49e..4c2b06296 100644 --- a/test/lib/linter/rules/snapshots/BestPractices.ts.md +++ b/test/lib/linter/rules/snapshots/BestPractices.ts.md @@ -110,6 +110,21 @@ Generated by [AVA](https://avajs.dev). }, ] +## General: Negative_7/Component.js + +> Snapshot 1 + + [ + { + coverageInfo: [], + errorCount: 0, + fatalErrorCount: 0, + filePath: 'Negative_7/Component.js', + messages: [], + warningCount: 0, + }, + ] + ## General: Positive_1/Component.js > Snapshot 1 diff --git a/test/lib/linter/rules/snapshots/BestPractices.ts.snap b/test/lib/linter/rules/snapshots/BestPractices.ts.snap index 78358ed40..60f46b8e7 100644 Binary files a/test/lib/linter/rules/snapshots/BestPractices.ts.snap and b/test/lib/linter/rules/snapshots/BestPractices.ts.snap differ