From e71b63ed8b11bdf38e729fa1e844a4d0f5f50404 Mon Sep 17 00:00:00 2001 From: Merlin Beutlberger Date: Mon, 16 Sep 2024 12:20:55 +0200 Subject: [PATCH] fix(asyncComponentFlags): Fix detection of manifest: 'json' (single quotes) Resolves https://github.com/SAP/ui5-linter/issues/306 --- src/linter/ui5Types/asyncComponentFlags.ts | 2 +- .../linter/rules/AsyncComponentFlags/Negative_10/Component.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/linter/ui5Types/asyncComponentFlags.ts b/src/linter/ui5Types/asyncComponentFlags.ts index c30b90e06..7020b938b 100644 --- a/src/linter/ui5Types/asyncComponentFlags.ts +++ b/src/linter/ui5Types/asyncComponentFlags.ts @@ -269,7 +269,7 @@ function doPropsCheck(metadata: ts.PropertyDeclaration, manifestContent: string hasManifestDefinition = !!(componentManifest && ts.isPropertyAssignment(componentManifest) && - componentManifest.initializer.getText() === "\"json\""); + getPropertyName(componentManifest.initializer) === "json"); } return { diff --git a/test/fixtures/linter/rules/AsyncComponentFlags/Negative_10/Component.ts b/test/fixtures/linter/rules/AsyncComponentFlags/Negative_10/Component.ts index 0a56f6c3d..9de89cbc5 100644 --- a/test/fixtures/linter/rules/AsyncComponentFlags/Negative_10/Component.ts +++ b/test/fixtures/linter/rules/AsyncComponentFlags/Negative_10/Component.ts @@ -5,6 +5,6 @@ import * as library from "sap/ui/core/library"; // Unused core library import fo export default class Component extends ParentComponent { static metadata = { - manifest: "json" + manifest: 'json' }; }