Change the default to error on missing SConscript #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes a change begun in 3.0.2, when the behavior changed from "skip silently" to "skip but issue a warning"; that behavior was marked deprecated in 3.1. Use must_exist=False to get the old "skip silently" behavior. Fixes SCons#3958 Signed-off-by: Mats Wichmann <[email protected]>
|
Goody... revised test fails on Windows. Possibly path-separator thing. |
|
Yes, indeed. That should be a straightforward fix: |
Make the path to the missing script in expected errors be OS-independent to avoid Windows failing on wrong path separator Signed-off-by: Mats Wichmann <[email protected]>
|
Grumble... still broken. Now it says |
Also dropped the word Fatal from the error, it's not consistent with any other scons-generated exception. Signed-off-by: Mats Wichmann <[email protected]>
|
This time I've actually tested it on Windows. Also dropped the word "Fatal" from the exception, SCons doesn't say that anywhere else (tests adjusted to match). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes a change begun in 3.0.2, when the behavior changed from "skip silently" to "skip but issue a warning"; that behavior was marked deprecated in 3.1. Use
must_exist=Falseto get the old "skip silently" behavior - this option has been available since the change in 3.0.2, this PR flips the default for that kwarg fromNonemeaning "Falsebut warn", toTrue, meaning by default aUserErroris raised for missing SConscript, the flag is now treated as boolean rather than tri-state since there is no further need for the warn behavior.Fixes #3958
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)