Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceProviderFragment - minor improvement. #165

Open
ghost opened this issue Dec 2, 2018 · 1 comment
Open

ServiceProviderFragment - minor improvement. #165

ghost opened this issue Dec 2, 2018 · 1 comment
Labels
good first issue Good for newcomers low-priority Low priority issues that are extra but not bonus for any of the deliverables.

Comments

@ghost
Copy link

ghost commented Dec 2, 2018

Currently starts the ServiceSelectorActivity with a reqeusted code of ServiceSelectorActivity.SERVICE_SELECTED_RESULT. Since this value is not really relevant (since this fragment only makes one type of request from the ServiceSelectorActivity), this should be replaced with some constant or even 0.
@ghost ghost added good first issue Good for newcomers low-priority Low priority issues that are extra but not bonus for any of the deliverables. labels Dec 2, 2018
@ghost
Copy link
Author

ghost commented Dec 5, 2018

This might be fixed in the latest, code needs to be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low-priority Low priority issues that are extra but not bonus for any of the deliverables.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants