Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extreme slowdown from periodic boundary conditions #16

Closed
Chelsea486MHz opened this issue Nov 20, 2019 · 2 comments
Closed

Extreme slowdown from periodic boundary conditions #16

Chelsea486MHz opened this issue Nov 20, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Chelsea486MHz
Copy link
Member

As per this revelation -> #9 (comment)

The way periodic boundary conditions are handled is beyond inefficient. Claiming I am surprised would be lying, but I am still speechless.

@raresraf
Copy link
Contributor

Seems that this in not a Cataclysmic problem of cosmological proportions after all. 😄
Only when I ran
./senpai.bin --in examples/DES.mol --out render.xyz --density 0.001 --time 0.01 this issue appeared. If we run with --copy 5, periodic boundary conditions total time drops below 0.1%

@Chelsea486MHz
Copy link
Member Author

Well, the force computations do scale at O(n²), while the PBCs scale at O(n).

I'll look into optimizing the PBCs anyway, since a lot of research went behind that.

Still, it's nice to know the impact isn't so bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants