Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Rebuild button only when build status is error or fail #72

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Show Rebuild button only when build status is error or fail #72

merged 1 commit into from
Aug 11, 2017

Conversation

cpolcyn
Copy link
Contributor

@cpolcyn cpolcyn commented Aug 11, 2017

Fixes #50

@cpolcyn cpolcyn requested review from cdcarter and jlantz August 11, 2017 21:01
@cpolcyn
Copy link
Contributor Author

cpolcyn commented Aug 11, 2017 •
edited
Loading

For build in waiting/queued/running we would want to first cancel the build (see #3) which should set status to error, then rebuild would be possible. Until we can cancel a build, this will prevent some problems as described in #50. Builds stuck in waiting/queued/running should be manually set to error by an admin.

@cpolcyn cpolcyn merged commit 659cee7 into master Aug 11, 2017
@cpolcyn cpolcyn deleted the issue-50 branch August 11, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcarter cdcarter cdcarter approved these changes

@jlantz jlantz Awaiting requested review from jlantz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpolcyn @cdcarter