Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNN reconstruction algorithm #36

Open
Nicolaas94 opened this issue Feb 16, 2023 · 1 comment
Open

PNN reconstruction algorithm #36

Nicolaas94 opened this issue Feb 16, 2023 · 1 comment

Comments

@Nicolaas94
Copy link

Dear SINTEF developers,

In the documentation of the PNN algorithm, the following is written down: "If the voxel already has a value, different approaches are possible: Taking the average, taking the maximum, taking the most recent value, or taking the first value."

However, in CustusX 18.04 in the tab Acquisition>Reconstruction I can select the algorithm "pnn" but there is no option between the different approaches as stated in the documentation.
I found in this GitHub that the algorithm used the maximum value as default, but I could not recognize any code for selecting an approach.

Is there a bug in my CustusX 18.04 or am I missing something?

@olevs
Copy link
Contributor

olevs commented Feb 17, 2023

Thank you for bringing this to our attention.
This is indeed an error in the documentation.

Some code changes in PNNReconstructionMethodService::fillHole would be needed in order to try out some of the other possibilities.

Best Regards,
Ole Vegard Solberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants