Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: generic tags #10

Open
wyrnat opened this issue Dec 5, 2023 · 0 comments · May be fixed by #12
Open

Feature: generic tags #10

wyrnat opened this issue Dec 5, 2023 · 0 comments · May be fixed by #12

Comments

@wyrnat
Copy link

wyrnat commented Dec 5, 2023

I propose to implement generic tags to release this feature to machines outside of slac.
I am already working on it, so if you have objections or advice (or you completely reject this idea), please let me know.

what

  • outsource the tags to Plugins
  • offer generic tags for every machine (XFEL, SLCS, FLASH)
  • add machine as main tag on top, refresh GUI accordingly to tags in plugin

why

  • default tags and options are not usable for every machine, eg. 'LI21:201' or 'HXR' do not exist at XFEL
  • instead, eg. XFEL need region='SASE1' or objective='launch'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant