Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bcftools #288

Closed
wants to merge 1 commit into from
Closed

Update bcftools #288

wants to merge 1 commit into from

Conversation

Jakob37
Copy link
Contributor

@Jakob37 Jakob37 commented Jan 21, 2025

Description and reviewer info

What is changed? How does this update improve the pipeline? (For reviewers) How to test it?

Close #281

Type of change

  • Documentation
  • Patch
  • Minor change
  • Major change

Checklist

  • Self-review of my code
  • Update the CHANGELOG
  • Tag the latest commit (vX.Y.Z format)

Documentation

  • At least one other person has reviewed my changes (not required for trivial changes)

Patch

  • Stub run completes without errors or new warnings
  • At least one other person has reviewed and approved my code (not required for trivial changes)

Major / Minor change

  • Stub run completes without errors or new warnings
  • GIAB single (wgs) finishes and differences to current master branch have been investigated (using PipeEval)
  • GIAB trio (wgs) finishes and differences to current master branch have been investigated
  • Seracare (onco) sample finishes and differences to current master branch have been investigated
  • Output from processes with altered code have been inspected (i.e. in the work folder: .command.sh, .command.log, .command.err and result files)
  • All three samples can be loaded into Scout
  • At least one other person has reviewed and approved my code
  • I have made corresponding changes to the documentation (software versions, etc.)

Test/review documentation

Review performed by

  • Alexander
  • Jakob
  • Paul
  • Ryan
  • Viktor

(Add if missing)

Testing performed by

  • Alexander
  • Jakob
  • Paul
  • Ryan
  • Viktor

@Jakob37
Copy link
Contributor Author

Jakob37 commented Jan 21, 2025

Will wait with this one until the multi-process container / processes has been divided

@Jakob37 Jakob37 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bcftools
1 participant