[Style/#20] 즐겨찾기 컴포넌트 구현 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N-WEB-MCDONALD into style/#20/LikeButton
…N-WEB-MCDONALD into style/#20/LikeButton
…N-WEB-MCDONALD into style/#20/LikeButton
youtheyeon
approved these changes
Nov 25, 2024
imddoy
approved these changes
Nov 25, 2024
| @@ -17,6 +18,7 @@ const BurgerPost = ({ titleEn, titleKo }: BugerPostProps) => ( | |||
| <div css={postStyleContainer}> | |||
There was a problem hiding this comment.
여기에 ThemeProvider를 넣어주신 이유가 무엇인가요??
App에 해둬서 지워두셔도 될 것 같습니다!
Comment on lines
2
to
6
| import { | ||
| postStyleContainer, | ||
| titleSection, | ||
| imageSection, | ||
| } from './BugerPost.style'; |
There was a problem hiding this comment.
스타일이 많다면 전체를 import해서 접근하는타일이 많다면 전체를 import해서 접근하는 것도 좋을 것 같습니다 ㅎㅎ
There was a problem hiding this comment.
컴포넌트가 원 색깔과, 하트 색깔말고는 다 같은데 하나의 컴포넌트로 2개의 컬러를 props로 관리하는것이 코드도 적어지고, 렌더링 측면에서도 좋을 것 같은데 어떻게 생각하시나요?
Comment on lines
+12
to
+14
| x={0.5} | ||
| fill="#fff" | ||
| fillOpacity={0.8} |
There was a problem hiding this comment.
이 값이랑 아래에 path에 있는 fill을 props로 관리하면 어떨까요?
Comment on lines
13
to
15
| background-color: ${theme.colors.gray000}; | ||
| `; | ||
| export const imageSection = css` |
There was a problem hiding this comment.
한줄 띄우고 작성하면 가독성이 더 좋을 것 같아요!
| @@ -13,6 +13,7 @@ export const postStyleContainer = (theme: Theme) => css` | |||
| background-color: ${theme.colors.gray000}; | |||
| `; | |||
| export const imageSection = css` | |||
| position: relative; | |||
| display: flex; | |||
| height: 11rem; | |||
| justify-content: center; | |||
There was a problem hiding this comment.
이전 코드라 코리가 안달리네요...ㅜㅜ
flex-shrink를 주신 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
즐겨찾기 하트 컴포넌트 퍼블리싱 및 기능구현
📢 To Reviewers
📸 스크린샷
20241125_185856.mp4
🔗 참고 자료