Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#26] 상세 페이지 퍼블리싱 #39

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Feat/#26] 상세 페이지 퍼블리싱 #39

wants to merge 3 commits into from

Conversation

bongtta
Copy link
Collaborator

@bongtta bongtta commented Nov 25, 2024 •
edited
Loading

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 버거 상세 페이지 퍼블리싱
  2. 아코디언

📢 To Reviewers

  • 버거랑 뒤에 동그라미(?)의 위치가 미묘하게 다른데.... 더이상의 방법을 모르겠습니다......ㅜ
  • \u00ae(®) 얘가 다른 텍스트처럼 중앙 정렬이 아니라 아래쪽으로 정렬되어야 해서 중간에 태그로 시도했는데 안돼서 포기했어요 죄송해요...ㅜㅜㅜ
  • useState 타입 설정하는 거... interface로 시도했는데 안 돼서 지피티한테 물어봤어요.....ㅎ ㅠㅠ
  • 아 맞다 <알레르기 정보>에 줄바꿈 수정한다는 거 까먹었다..! 반영할 때 하겠습니당...

📸 스크린샷

image
image

🔗 참고 자료

@bongtta bongtta self-assigned this Nov 25, 2024
@bongtta bongtta changed the title Feat/#26/burger detail page [Feat/#26] 상세페이지 퍼블리싱 Nov 25, 2024
@bongtta bongtta changed the title [Feat/#26] 상세페이지 퍼블리싱 [Feat/#26] 상세 페이지 퍼블리싱 Nov 25, 2024
youtheyeon
youtheyeon approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@youtheyeon youtheyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생해따!!!!! 이제보니 버거 이미지 뒤에 원 띄우는 것도 그렇고 테이블도 그렇고 아코디언까지 신경 쓸 부분이 많았네 근데 너무 잘 해냄...🥹👍 수고 많이 했어!

src/assets/svgs/Ellipse.tsx Show resolved Hide resolved
src/assets/svgs/IcMinus.tsx Show resolved Hide resolved
src/assets/svgs/index.ts Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.tsx Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.tsx
<th>영양소기준치</th>
</tr>
</thead>
<tbody>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 부분 데이터를 따로 배열로 분리해서 우리 3주차 세미나 실습 때 했던 것처럼 map 함수 돌려서 띄우는 방식으로 바꾸면 더 좋을 것 같아요!

src/pages/burgerdetail/BurgerDetailPage.style.ts Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.style.ts Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.style.ts Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.style.ts Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.style.ts Show resolved Hide resolved
imddoy
imddoy approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@imddoy imddoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸푸어푸

src/pages/burgerdetail/BurgerDetailPage.tsx Show resolved Hide resolved
src/pages/burgerdetail/BurgerDetailPage.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtheyeon youtheyeon youtheyeon approved these changes

@imddoy imddoy imddoy approved these changes

@gwagjiug gwagjiug Awaiting requested review from gwagjiug

Assignees

@bongtta bongtta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Feat ] 버거 상세 페이지 퍼블리싱
3 participants
@bongtta @imddoy @youtheyeon