[Style/#37] 즐겨찾기 리스트 페이지 퍼블리싱 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N-WEB-MCDONALD into style/#20/LikeButton
…N-WEB-MCDONALD into style/#20/LikeButton
…N-WEB-MCDONALD into style/#20/LikeButton
youtheyeon
approved these changes
Nov 25, 2024
| import BurgerPost from '@components/BurgerPost/BurgerPost'; | ||
| const FavoriteListPage = () => { | ||
| const productLength = PRODUCT_LIST.length; | ||
| const bannerTitle = ['내 메뉴']; |
There was a problem hiding this comment.
여기를 배열로 지정해 줄 이유가 있나요? 그냥 string으로 줘도 될 것 같습니당
There was a problem hiding this comment.
나중에 뭐가 추가될 수 있을 것 같아서 배열로 하긴했는뎅 string으로 할게용~
| @@ -2,14 +2,15 @@ import { createBrowserRouter } from 'react-router-dom'; | |||
| import Main from '@pages/main/Main'; | |||
| import Layout from '@layouts/Layout'; | |||
| import BurgerListPage from '@pages/burgerlist/BurgerListPage'; | |||
|
|
|||
| import FavoriteListPage from '@pages/favoriteList/FavoriteListPage'; | |||
There was a problem hiding this comment.
진짜 별 거 아니지만 혹시 여기 임포트랑 라우터 사이에 한 줄 띄워주실 수 있나요?
imddoy
approved these changes
Nov 25, 2024
Comment on lines
+8
to
+10
| flex-shrink: 0; | ||
| background: var(--Blackgrad, rgba(0, 0, 0, 0.5)); | ||
| .banner__title { |
Comment on lines
+7
to
+9
| height: 16.6rem; | ||
| flex-shrink: 0; | ||
| background: var(--Blackgrad, rgba(0, 0, 0, 0.5)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료