Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feat ] 호텔 섹션 퍼블리싱 #39

Merged
merged 6 commits into from
Nov 26, 2024
Merged

[ feat ] 호텔 섹션 퍼블리싱 #39

merged 6 commits into from
Nov 26, 2024

Conversation

heesunee
Copy link
Collaborator

🔥 Related Issues

✅ 작업 리스트

  • 호텔 카드 컴포넌트
  • 더보기 버튼

🔧 작업 내용

  • 호텔 데이터를 만들어서 호텔 카드를 구현했습니다.! 근데 카드 내 가격글씨를 피그마랑 똑같게 했는데 엄청 작게 나오네요 .... Inter 폰트 설정이 안되어있어서 그런지 (?) 추후 수정하겠습니다

🧐 새로 알게된 점

🤔 궁금한 점

📸 스크린샷 / GIF / Link

image

@heesunee heesunee added ✨ feat 기능 구현 💄style 기능에 영향을 주지 않는 커밋, 코드 순서, css등의 포맷에 관한 커밋 labels Nov 25, 2024
@heesunee heesunee self-assigned this Nov 25, 2024
@heesunee heesunee removed the 💄style 기능에 영향을 주지 않는 커밋, 코드 순서, css등의 포맷에 관한 커밋 label Nov 25, 2024
Copy link
Member

@KIMGEONHWI KIMGEONHWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

희선님 고생 많으셨습니다! 역시 씨박희선.

<Bottom>
<Rating>{rating}</Rating>
<Review>{review}</Review>
<OwlImage src={OwlImg} alt="부엉이 이미지" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: 부엉이 이미지는 svg로 사용안한 이유가 있을까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svg로 변경했습니다!

isClicked={selectedFilter === '3성급'}
onClick={() => handleFilterClick('3성급')}
/>
<TabButton content={'후기'} isClicked={selectedFilter === '후기'} onClick={() => handleFilterClick('후기')} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5: 근데 정말 단순 궁금증... 이 줄만 왜 컨벤션이 안맞을까요? ㅋㅋㅋㅋㅋ

Copy link
Collaborator

@ayla-12 ayla-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 군더더기 없는 코드네요.... 수고 많으셨습니다!!!

Copy link
Collaborator

@minjeoong minjeoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👏🏻👏🏻👏🏻

}
const HotelCard = ({ hotel }: HotelCardProps) => {
const { name, image, price, star, description, rating, review } = hotel;
console.log(image);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: 콘솔 나중에 지워주세용

@heesunee heesunee merged commit d57ddc4 into develop Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feat ] 호텔 섹션 퍼블리싱
4 participants