Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: self.size or other.size may be None #8

Open
wants to merge 1 commit into
base: demo
Choose a base branch
from
Open

Fix: self.size or other.size may be None #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions panda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,20 @@ class WorklistOrder:
# - Decending order of size: the larger the less
class LongestJobFirstWorklistOrder(WorklistOrder):
def itemlt(self, other):
# assume None it is the largest.
if self.size is None: return True
elif other.size is None: return False

return self.size > other.size

# Shortest job first order:
# - CDB tasks to back: the largest
# - Decending order of size: the less the less
class ShortestJobFirstWorklistOrder(WorklistOrder):
def itemlt(self, other):
# assume None it is the largest.
if self.size is None: return False
elif other.size is None: return True
return self.size < other.size


Expand Down