Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements for link checking #90

Open
1 of 2 tasks
SReichelt opened this issue Jan 6, 2021 · 0 comments
Open
1 of 2 tasks

Enhancements for link checking #90

SReichelt opened this issue Jan 6, 2021 · 0 comments
Labels
enhancement New feature or request external dependency Waiting for a bugfix or feature in another product good first issue Good for newcomers

Comments

@SReichelt
Copy link
Owner

SReichelt commented Jan 6, 2021 •
edited
Loading

Enhancements for #45 (checkLinks.ts, called via checkLibraryLinks.sh):

  • The link-check library that we currently use ignores anchors. Those do break from time to time, particularly in Lean's mathlib, so checking them would be beneficial.
  • It would be nice to run this in a GitHub action within the library repository, on a fixed schedule (maybe once per week or so). A prerequisite is that the script actually returns an error when a broken link is found. This error should be emailed to maintainers.
@SReichelt SReichelt added enhancement New feature or request good first issue Good for newcomers external dependency Waiting for a bugfix or feature in another product labels Jan 6, 2021
SReichelt added a commit that referenced this issue Jan 30, 2021
@SReichelt
Add GitHub action to check links regularly. #90
dea8bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request external dependency Waiting for a bugfix or feature in another product good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SReichelt