Turn off cpplint and cppcheck options but test them in CI #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reserve it for power developers Fix #452 First time build fails on Windows with MSVC due to carriage return characters
Make sure to use raw strings for all regular expressions using a backslash
Same fix as nodejs/node#49731 tools: remove deprecated python api
It's now possible to run the C++ linter without building the library
SRombauts
force-pushed
the
cpplint-off-by-default-enabled-in-ci
branch
from
dd37e1c
to
8475fa8
Compare
SRombauts
force-pushed
the
cpplint-off-by-default-enabled-in-ci
branch
from
8475fa8
to
525b7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable running cpplint and cppcheck tools by default
Add Github Actions to run them on CI
Fix #452 First time build fails on Windows with MSVC due to carriage return characters