iptables args given in wrong order

[davidkarlsen]

state declaration:
iptables.insert:
- table: filter
- chain: INPUT
- position: 1
- protocol: tcp
- dport: 22
- match: state
- connstate: NEW,ESTABLISHED
- jump: ACCEPT
- save: True

Fails with:
Function: iptables.insert
Result: False
Comment: Failed to set iptables rule for openssh.
Attempted rule was iptables -t filter -I INPUT 1 -m state --state NEW,ESTABLISHED --dport 22 --protocol tcp --jump ACCEPT
Changes:

The generated command line should give --protocol before --dport, e.g.
tables -t filter -I INPUT 1 -m state --state NEW,ESTABLISHED --protocol tcp --dport 22 --jump ACCEPT would work.

[techhat]

Thanks for the report, @davidkarlsen. What version of Salt are you running?

[davidkarlsen]

Hm, it seems the param should be proto and not protocol - so closing (at least it works correctly if I use proto instead)

[techhat]

Ah, that would do it.

[davidkarlsen]

salt-minion --version
salt-minion 2014.1.3