tests: housekeeping - test_logging.py

[danlavu]

housekeeping, the following is looked at and may have been done:

• fixed typos and standardized formatting
• renamed test cases to improve the clarity of what the test does
• improved docstring language, setup, steps and expected results
• synced code with the docstring order
• removed necessary configuration relevant to the test
• added pytest.mark.importance to test cases
• added error messages to assertions

[alexey-tikhonov]

Is this updated to match PR that was merged to sssd-2.10?

[danlavu]

@alexey-tikhonov yes, had to re-run black for formatting and the only different is that it still contains the test for file permissions which did not write to journald

git diff master test_logging.py

diff --git a/src/tests/system/tests/test_logging.py b/src/tests/system/tests/test_logging.py
index 3be50e35b..5ad036743 100644
--- a/src/tests/system/tests/test_logging.py
+++ b/src/tests/system/tests/test_logging.py
@@ -74,6 +74,38 @@ def test_logging__default_settings_does_not_log_user_logins(client: Client):
     assert not client.host.conn.run("diff /var/log/sssd /tmp/copy").stdout, "Debug messages were generated!"
 
 
[email protected]
[email protected]("low")
[email protected](bz=1893159)
[email protected](KnownTopology.Client)
+def test_logging__default_settings_logs_sssd_conf_permissions_errors(client: Client):
+    """
+    :title: Default debug_level logs sssd.conf unreadable ssd.conf permission errors
+    :setup:
+        1. Configure SSSD for local system authentication
+        2. Start SSSD, note this configures SSSD, the config file is created here
+        3. Set invalid file permissions for sssd.conf
+        4. Stop SSSD
+    :steps:
+        1. Start SSSD with default debug level
+    :expectedresults:
+        1. SSSD failed to start with expected error code
+    :customerscenario: True
+    """
+    client.sssd.common.local()
+    client.sssd.default_domain = "local"
+    client.sssd.start(debug_level=None)
+    client.fs.chmod(mode="444", path="/etc/sssd/sssd.conf")
+    client.sssd.stop()
+
+    assert (
+        client.sssd.start(debug_level=None, raise_on_error=False, apply_config=False).rc != 0
+    ), "SSSD erroneously started!"
+    assert "File ownership and permissions check failed" in client.fs.read(
+        client.sssd.logs.monitor
+    ), "File check error messages are not in logs!"
+
+
 @pytest.mark.integration
 @pytest.mark.importance("low")
 @pytest.mark.ticket(bz=1893159)

[alexey-tikhonov]

Pushed PR: #7559

• sssd-2-9
  • 5a6093f - tests: housekeeping - test_logging.py