Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Font size for consulting components too small #3585

Closed
4 tasks done
Calinator444 opened this issue Feb 6, 2025 · 2 comments · Fixed by #3590
Closed
4 tasks done

💄 Font size for consulting components too small #3585

Calinator444 opened this issue Feb 6, 2025 · 2 comments · Fixed by #3590
Assignees
@babakamyljanovssw

Comments

@Calinator444
Copy link
Member

Calinator444 commented Feb 6, 2025 •
edited by babakamyljanovssw
Loading

CC: @uly1, @bettybondoc

Description

As per my conversation with Betty, the font size for some of the consulting page components is too small.
The components I've identified thus far are:

  • The breadcrumbs component (should use sm text)
  • The Accordion dropdowns & content (should use text-base)

Acceptance criteria

  • New font sizes test passed by Adam or a designer
  • New font sizes match the Figma prototype

Image
@github-project-automation github-project-automation bot moved this to 🤷‍♂️ Needs Triage in SSW.Website Feb 6, 2025
@Calinator444 Calinator444 moved this from 🤷‍♂️ Needs Triage to 🔖 Backlog - Ready in SSW.Website Feb 7, 2025
@babakamyljanovssw babakamyljanovssw self-assigned this Feb 7, 2025
@babakamyljanovssw babakamyljanovssw moved this from 🔖 Backlog - Ready to 🏗 In progress in SSW.Website Feb 7, 2025
@babakamyljanovssw babakamyljanovssw mentioned this issue Feb 7, 2025
Merged
2 tasks
@Calinator444 Calinator444 moved this from 🏗 In progress to 👀 In review in SSW.Website Feb 10, 2025
@babakamyljanovssw
Copy link
Member

babakamyljanovssw commented Feb 11, 2025 •
edited
Loading

I asked @bettybondoc to test it out.
Changes are deployed to https://app-sswwebsite-9eb3-pr-3590.azurewebsites.net/
PR - #3590

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in SSW.Website Feb 11, 2025
@babakamyljanovssw
Copy link
Member

✅ Done

Test pass by @bettybondoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babakamyljanovssw babakamyljanovssw

Labels
None yet
Projects
SSW.Website
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed font size for consulting components SSWConsulting/SSW.Website
2 participants
@Calinator444 @babakamyljanovssw