Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems displaying Google maps #291

Open
stevetheboater opened this issue Jul 25, 2015 · 2 comments
Open

Problems displaying Google maps #291

stevetheboater opened this issue Jul 25, 2015 · 2 comments
Assignees
Milestone

Comments

@stevetheboater
Copy link

I've been using Open Framework recently as it seems to be a really good way to deliver responsive sites. I'm still learning about it but have hit a brick wall with an issue and wondered if anyone else had seen it or knew how to solve it.

I am using Gmap and Location to add information about the of points of interest in our area. If I use Bartik or Seven the map displays fine but as soon as I switch to Open Framework or my modified subtheme (CSS changes only)

I've enabled a theme switcher to demonstrate what is going on: http://churnet-valley.guide/place/crumpwood-weir

If I look with the web developer toolbar in Firefox the error I see in the unmodified Open Framework or my subtheme is:
Syntax error, unrecognized expression: a[href^=http://]
Source File: http://churnet-valley.guide/sites/all/themes/open_framework/js/jquery-1.9.1.min.js?v=1.9.1
Line: 4

I've just tried upgrading from 2.3 to the latest version (2.5) but it has made no difference. Can anyone offer any advice?

@hyperboy hyperboy self-assigned this Jul 29, 2015
@hyperboy
Copy link
Collaborator

Hi Steve,

It looks like the culprit is actually http://churnet-valley.guide/sites/all/modules/external/external.js

The Google map loads when that particular line of javascript is removed from the code.

We're including an older version of jQuery for compatibility reasons. You can try loading later versions of jQuery (e.g., jQuery 1.11.3) in your subtheme to see if it makes a difference.

@stevetheboater
Copy link
Author

Many thanks for that. You're right the page loads if I disable the External module. Not quite sure if that makes it a problem in External or Open Framework though, given that other themes are fine with it enabled. I'll try your suggestion of loading later versions of jQuery. What are the compatibility issues you refer to?

As a matter of interest, how did you diagnose this? I'm still very new to jQuery and wouldn't know how to go about identifying such an issue beyond what Firefox can tell me. Always keen to learn :)

@meganem meganem modified the milestone: Icebox Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants