Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked thumbnail images should be taken out of the flow for screenreaders #20

Open
jbickar opened this issue May 27, 2014 · 2 comments
Open

Comments

@jbickar
Copy link
Contributor

jbickar commented May 27, 2014

If you look at the View here (https://sites.stanford.edu/sociology/people/faculty), which is the stanford_person_faculty View, it generates accessibility errors because the images are hyperlinked and do not have descriptive alt text. Because we also are hyperlinking the neighboring h3 element to the same destination, best practice would be:

<a href="foo"><img src="img.jpg" /><h3>Jane Stanford</h3></a>

However, that might cause problems with styling. We may instead want to add the role="presentation" attribute to the img element.

@jbickar
Copy link
Contributor Author

jbickar commented May 27, 2014

Eh, and I'm not sure how severe this is, will have to check with Jennifer. It's certainly a problem of link overload, but Voice Over on Safari, at least, announces the hyperlinked path for the image, which (because we're using pathauto) actually provides some semantic information.

@jbickar
Copy link
Contributor Author

jbickar commented Jun 16, 2014

We want to wrap the image and the h3 in the <a> tag. See https://devspace.stanford.edu/jira/browse/FEATURES-90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant